Project

General

Profile

Bug #967

Rearranging item with up/down arrow problem

Added by Hubert Borderiou over 9 years ago. Updated over 9 years ago.

Status:
Bug resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
09/04/2010
Due date:
% Done:

100%

Estimated time:
Complexity:
Challenging
SCRUM pts - complexity:
5

Description

When you click several time (fast) on the arrow to change the order of Learning Path items (for exemple), arrow have weird behaviour... and everything go crazy
(go in the wrong place)
It can occure on all tools with these arrows.
Bad info are stored in the database then.
See attached


Files

2010-04-08_1625.png (10.2 KB) 2010-04-08_1625.png Database for learning path item Hubert Borderiou, 09/04/2010 16:21
2010-04-08_1623.png (53.2 KB) 2010-04-08_1623.png Arrows on a weird state Hubert Borderiou, 09/04/2010 16:21
2010-04-08_1624.png (23 KB) 2010-04-08_1624.png Detected pb with my tool Hubert Borderiou, 09/04/2010 16:21
2010-04-19_1700.png (73.5 KB) 2010-04-19_1700.png Hubert Borderiou, 19/04/2010 17:10
green_arrow_controller.swf (399 KB) green_arrow_controller.swf flw to use with mp4 file Hubert Borderiou, 20/04/2010 15:06
green_arrow.mp4 (4.3 MB) green_arrow.mp4 How the tool works.mp4 Hubert Borderiou, 20/04/2010 15:06
tools.tgz (17.7 KB) tools.tgz tools archive Hubert Borderiou, 20/04/2010 15:06
2010-04-21_1545.swf (1.23 MB) 2010-04-21_1545.swf Pb with arrows for Scorm imported files (swf 25sec) Hubert Borderiou, 21/04/2010 15:52
index.php (77.6 KB) index.php Tool file with the "dir" item-type for lp_item Hubert Borderiou, 21/04/2010 15:52
main.zip (15.7 KB) main.zip php files Hubert Borderiou, 22/04/2010 15:45
Sans-titre-1.png (33.7 KB) Sans-titre-1.png Screencopy of my solution Hubert Borderiou, 22/04/2010 15:45

History

#1

Updated by Yannick Warnier over 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
  • Priority changed from Normal to High
  • Complexity changed from Normal to Challenging
  • SCRUM pts - complexity changed from ? to 5
#2

Updated by Anonymous over 9 years ago

I couldn't reproduce this bug, even after clicking like crazy on the arrow icons in a learning path...

Hubert > Could you confirm whether it still happens for you, using the version of Chamilo that comes from the repository ?

#3

Updated by Hubert Borderiou over 9 years ago

Hi,
I did today a hg clone on repository https://classic.chamilo.googlecode.com/hg/
I have the same symptoms (see attached :s)

I think it may happend on a not-fast-enought mysql server or on huge learning path.

May be you can try with a 200 items learning path you can find here : http://projet.c2imes.org/V2/SCORM/moulines/B4TAB_EXCEL.zip

It's a good test, because these scorm files are (should be) used by all french universities for teacher and personnal internet certification

#4

Updated by Hubert Borderiou over 9 years ago

Hi,
see attached a tool I use to detect and repair Learning Path order.
I've attached a brief mp4 screencast for how the tool works.
Don't hesitate to ask me in IRC if you need.
I'll try to work on this issue too.
regards,

#5

Updated by Hubert Borderiou over 9 years ago

I think I may have a link with an error I have in my apache error_log :

Broken pipe: core_output_filter: writing data to the network

I have this error (even if I modify my httpd.conf with EnableSendfile Off) when I seem to reproduce the up/down order pb...
hope this help

#6

Updated by Hubert Borderiou over 9 years ago

Hi,
I've modified my lp_order tool to work with Scrom imported files.
Acutally, in database lp_item, there is "dokeos_chapter" as item_type, and for a scorm imported file, the label is "dir"
See attached my new index.php file for tools, with dokeos_chapter and dir
and a tiny swf file to see the result for the Scorm imported file with wrong arrows.

Because of the error "Broken pipe: core_output_filter: writing data to the network", I'm working on a client-side solution :-(

Hope this help.

Regards

#7

Updated by Hubert Borderiou over 9 years ago

Eventually, as I don't know how to fix the server behaviour, I've made a client-side solution :s

It displays a "Please wait" div on the arrow that have been clicked, and deactivate others arrows while processing.
It works for learningpath, exercice, link, glossary, survey, announcement, courses and forum.
I've protected as my script to avoid side effects, and have tested it on Firefox, IE, Safari, Chrome, Opera and it's ok.
It used common Javascript.

Attached a screencopy and files.

I put it on my production server (in a older version, but it doesn't care). I tell you if any problem.

There is another aspect on this solution, the user sees the "Please wait" div and knows he have to wait for a process that can be "long" for him (one second, two seconds ?). I guess he should be more aware that he has to avoid frantic clicking...

Regards.

#8

Updated by Yannick Warnier over 9 years ago

  • Target version changed from 1.8.7 beta to 1.8.7 RC1
#9

Updated by Julio Montoya over 9 years ago

Hello Hubert,

Did the modification you propose works fine in your production server?

Hubert Borderiou wrote:

Hi,
I did today a hg clone on repository https://classic.chamilo.googlecode.com/hg/
I have the same symptoms (see attached :s)

I think it may happend on a not-fast-enought mysql server or on huge learning path.

May be you can try with a 200 items learning path you can find here : http://projet.c2imes.org/V2/SCORM/moulines/B4TAB_EXCEL.zip

It's a good test, because these scorm files are (should be) used by all french universities for teacher and personnal internet certification

#10

Updated by Julio Montoya over 9 years ago

In the server side I will add a token when sending the move_item action ...
This will avoid the double clicking errors.

#11

Updated by Julio Montoya over 9 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Hubert Borderiou
  • % Done changed from 0 to 70

Hello Hubert,
I added the token validation that might resolve the problem

http://code.google.com/p/chamilo/source/detail?r=ef2162a889b08cf7dd767af9d2f726ece589871c&repo=classic

#12

Updated by Hubert Borderiou over 9 years ago

Hi,

I've used your file on my Chamilo 1.8.7.a install
and if I do frantic-crazy-clicks, the worst thing that happen, is that nothing is done.
If I click again (gently) still nothing is done.
It's ok if I quit the Learning Path organize page, and go to it again.
The most important thing is that there are no more error on the database.

Thanks a lot ^^

I guess this problem may occur on every page with Up and Down arrows ?

#14

Updated by Julio Montoya over 9 years ago

  • Status changed from Needs more info to Bug resolved
  • Assignee changed from Hubert Borderiou to Julio Montoya
  • % Done changed from 70 to 100

Also available in: Atom PDF