Project

General

Profile

Bug #8402

Essence requires PHP 5.5

Added by Yannick Warnier almost 5 years ago. Updated almost 5 years ago.

Status:
Bug resolved
Priority:
Immediate
Assignee:
Category:
Installation / Migration
Target version:
Start date:
16/08/2016
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Isn't there something we can do in composer to say that any dependency has to support PHP 5.4?
Maybe we can consider a minimum of PHP 5.5 for 2.0, but at this time it is still too soon for our users base to require 5.5.

This is not the first time the release of 1.11 beta is blocked by dependencies like this, which are difficult to fix if you don't know why the library was included (I understand this has something to do with the video player or converter, but that's all I know). Please fix asap.

ywarnier@zap:~/temp/chamilo-1.11-packaging$ composer update
> Chamilo\CoreBundle\Composer\ScriptHandler::deleteOldFilesFrom19x
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for essence/essence ^3.2 -> satisfiable by essence/essence[3.2.0].
    - essence/essence 3.2.0 requires php >=5.5.0 -> your PHP version (5.4.45) does not satisfy that requirement.

History

#1

Updated by Yannick Warnier almost 5 years ago

I see that Angel is the one who increased the essence library version requirement based on the fact that PHP 7.0 generates a conflict in the code with version 2.5: https://github.com/chamilo/chamilo-lms/commit/ce651aa02d9f6252e853ebe1bb4c76b14e153fa6

I'm also interested in supporting PHP 7.0. Is there a way we can support both PHP 5.4 and 7.0 with the same essence library?

#2

Updated by Julio Montoya almost 5 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

Yes, it was Angel.

According to this:

https://packagist.org/packages/essence/essence#2.5.2

Version 2.5.2 can be used since 5.4

PHP 5.5 for Chamilo 2.0 sounds good for me but It will be maybe better to use php 5.6

5.4 and 5.5 have already reached the end of life:

http://php.net/supported-versions.php

I think is a bad idea to support 7.0 if we still have dependencies of 5.4.
We cannot have it all!

#3

Updated by Julio Montoya almost 5 years ago

I checked the essence library version 3.x and they are using yield (only available since 5.5) I found also that they are depending in this library:

"fg/parkour" that requires php 5.5

https://github.com/essence/essence/commit/673ba352f90845c1dd0521f799eac61513ab7686

https://packagist.org/packages/fg/parkour#1.0.0

#4

Updated by Julio Montoya almost 5 years ago

I fixed the issue creating a fork if the essence lib and fixing the error:

PHP 7 Compatibility Issue: Cannot use 'Null' as class

https://github.com/chamilo/chamilo-lms/commit/277763de13dd9f7ca073036ec73451097a438543

#5

Updated by Yannick Warnier almost 5 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

I reported an issue to them here: https://github.com/essence/essence/issues/122

They're asking for us to make a PR now. Julio... this is up to you! (I cannot send a PR in your name without doing a fork of your branch :-))

#6

Updated by Yannick Warnier almost 5 years ago

  • % Done changed from 0 to 80
#7

Updated by Julio Montoya almost 5 years ago

  • Assignee changed from Julio Montoya to Yannick Warnier
#8

Updated by Yannick Warnier almost 5 years ago

OK, I'm leaving the task open for a while just in case they would tag a release soon, so we can switch the dependency back to the original package.

#9

Updated by Yannick Warnier almost 5 years ago

  • Status changed from Assigned to Bug resolved
  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 80 to 100

Oh, well he already published 2.6.0 with the change! :-)
Updated composer.json.

Also available in: Atom PDF