Project

General

Profile

Support #8361

Should composer update remove deprecated directories?

Added by Yannick Warnier about 5 years ago. Updated almost 5 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
Installation / Migration
Target version:
Start date:
26/07/2016
Due date:
% Done:

80%

Estimated time:
Complexity:
Piece of cake
SCRUM pts - complexity:
?

Description

This is more a question than a feature request:
When I overwrite 1.10.x with 1.11.x and I issue a "composer install" (or a composer update), I get this warning:

Warning: Ambiguous class resolution, "TicketManager" was found in both "$baseDir . '/main/inc/lib/TicketManager.php" and "/var/www/bla.beeznest.com/www/plugin/ticket/src/ticket.class.php", the first will be used.

Obviously, composer install should not be necessary with the stable package, but I was wondering if the removals that we have added to main/install/update-files-1.10.0-1.11.0.inc.php should also be somehow in composer...

Associated revisions

Revision ef32350b (diff)
Added by jmontoyaa almost 5 years ago

Fix path see #8361

History

#1

Updated by Julio Montoya about 5 years ago

  • Assignee changed from Julio Montoya to Yannick Warnier

Should composer update remove deprecated directories?

Yes.

Before doing a composer install or composer update this script is executed:

ScriptHandler::deleteOldFilesFrom19x"

See composer.json.

So to fix that TicketManager issue just add the file in that script.


 "scripts": {
        "pre-install-cmd": [
            "Chamilo\\CoreBundle\\Composer\\ScriptHandler::deleteOldFilesFrom19x" 
        ],
        "pre-update-cmd": [
            "Chamilo\\CoreBundle\\Composer\\ScriptHandler::deleteOldFilesFrom19x" 
        ],
        "post-install-cmd": [
            "Chamilo\\CoreBundle\\Composer\\ScriptHandler::dumpCssFiles" 
        ],
        "post-update-cmd": [
            "Chamilo\\CoreBundle\\Composer\\ScriptHandler::dumpCssFiles" 
        ]
    },
#2

Updated by Yannick Warnier almost 5 years ago

In the script, I see that the end of the $paths array has references to files, while there is another array called "$files" just after that. Apparently you put them there... https://github.com/chamilo/chamilo-lms/commit/59c1a9cb742403bc689e29170efa18a682751666 Is that a mistake or is it because there was something wrong with not doing it this way?

#3

Updated by Yannick Warnier almost 5 years ago

  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 0 to 80

Once you've checked that, you can close the task because I've added the directories removals I was describing above through commit 49438c8

#4

Updated by Yannick Warnier almost 5 years ago

  • Complexity changed from Normal to Piece of cake
#5

Updated by Julio Montoya almost 5 years ago

  • Status changed from Assigned to Bug resolved

Fixed.

Also available in: Atom PDF