Chamilo LMS

PR : https://github.com/chamilo/chamilo-lms/pull/1154

This change will cause some errors when the $formValidator use the html editor.

What's wrong with ckeditor?

One option could be to transform htmleditor to textarea if user is anonymous.

Also make sure "nobody else" uses ckeditor outside formValidator

Julio Montoya wrote:

José Loguercio wrote:

Yep, my bad, fixed now : https://github.com/chamilo/chamilo-lms/pull/1156

Escribiré esto en español, Yannick me pidió que para optimizar la página de inicio, quitara la llamada al plugin del ckeditor ya que pesa más 500kb.

not fixed yet, needs to convert ckeditor to textareas (block ckeditor js code) file HtmlEditor.php

Julio, could you be more specific about the problem it causes?
Normally, a user not logged in shouldn't have access to any textarea/ckeditor... The only exception I can see is the "Contact" form in 1.11, but this should already be a textarea...

If you call "$form->addHtmlEditor()" this code will use the ckeditor js code.
That function should be modifed so when rendering "$form->addHtmlEditor()" no js code should be added:

example:

"CKEDITOR.replace( 'editor1', {
    language: 'fr',
    uiColor: '#9AB8F3'
});" 

To avoid remember all the exceptions is better to modified that function/file (HtmlEditor.php)

That still doesn't give me a clue as to the specific problems it causes. Could you give an example of where we can see the error happening, so we can reproduce it and be satisfied with the patch? I think no textarea appears when a user is not connected...

As I said, maybe the new contact form gives a textarea, but otherwise all places where a textarea appears are places where the user is logged in.

One other exception I can see: if the registration form contains extra fields... (considering this, yes, it would make sense to modify the function you mention).

José, please change the HtmlEditor.php file as Julio suggests.

I changed the strategy: I added a constant on the homepage and in global.inc.php to avoid loading CKeditor. This is then taken and validated by template.lib.php and header.js.tpl to ignore the lib and dependencies. So if we know of a page we want to optimize but for which we're not going to need CKeditor, we can use it.

The definition of the additional constant in global.inc.php might have some very light efficiency impact, though. This should be watched (and possibly reverted in future versions if we find a more efficient way).

https://github.com/chamilo/chamilo-lms/commit/cbca6874407130615849ac3b70f6b19e9ada7cc8