Project

General

Profile

Bug #8045

Conflict between 2 CourseDescription classes

Added by Yannick Warnier almost 4 years ago. Updated almost 4 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
Global / Others / Misc
Target version:
Start date:
12/01/2016
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

The CourseDescription class is defined in main/inc/lib/course_description.lib.php and main/coursecopy/classes/CourseDescription.class.php

In some cases (like when calling the constructor for the CourseDescription class in a plugin, the code expects the call to include parameters (as in the class defined in coursecopy/classes) whereas we want the constructor without parameters (as defined in main/inc/lib).

Define a namespace for both to avoid conflict. If change can be made to only one of these, I prefer to make it in the coursecopy folder as this is less used. Make sure you modify all corresponding references to use the namespace.

I found this error when using the session_slider_block plugin for the tmi branch (call in index.php, line 33). Not always failing, though.

Associated revisions

Revision c953b098 (diff)
Added by José Loguercio almost 4 years ago

Fix Conflict between 2 CourseDescription classes - Refs #8045

Revision cfcba709
Added by Yannick Warnier almost 4 years ago

Merge pull request #978 from jloguercio/8045

Fix Conflict between 2 CourseDescription classes - Refs #8045

History

#1

Updated by Yannick Warnier almost 4 years ago

  • Assignee changed from José Loguercio to Julio Montoya
#2

Updated by Yannick Warnier almost 4 years ago

  • Assignee changed from Julio Montoya to José Loguercio

Cambio de plan, José me dice que lo tiene y solo le falta mandarlo.

#3

Updated by Yannick Warnier almost 4 years ago

  • Status changed from Assigned to Bug resolved
  • % Done changed from 0 to 100

All good. Thanks.

Also available in: Atom PDF