Project

General

Profile

Bug #7835

Homepage links

Added by AliaMori com over 4 years ago. Updated over 4 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Angel Quiroz
Category:
Dashboard / Control panel
Target version:
1.10.0
Start date:
14/09/2015
Due date:
% Done:

100%

Estimated time:
Spent time:
3.18 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

The home page links

"inbox" and "social network" are not working for me.

I am using unstable.chamilo.org

Image attached.

Files

home page links.png (284 KB) home page links.png home page links AliaMori com, 14/09/2015 13:59
7835_01.png (17.9 KB) 7835_01.png Angel Quiroz, 14/09/2015 22:14
7835_02.png (35.4 KB) 7835_02.png Angel Quiroz, 14/09/2015 22:14
Adblock Chamilo 1.10.pdf (40.4 KB) Adblock Chamilo 1.10.pdf items blocked by AdBlock Plus -- chamilo 1.10 AliaMori com, 17/09/2015 02:19

Associated revisions

Revision 55b4432b (diff)
Added by Angel Fernando Quiroz Campos over 4 years ago

Rename CSS class for social tools - refs #7835

Revision 45165c67 (diff)
Added by Angel Fernando Quiroz Campos over 4 years ago

Fix Tour plugin - refs #7835

Revision acde711b (diff)
Added by Angel Fernando Quiroz Campos over 4 years ago

Rename CSS class for social tools - refs #7835

Revision b91733cc (diff)
Added by Angel Fernando Quiroz Campos over 4 years ago

Avoid blocked icons by ad blockers - refs #7835

Revision 1633c222 (diff)
Added by Angel Fernando Quiroz Campos over 4 years ago

Minor - Format code - refs #7835

History

#1

Updated by Yannick Warnier over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Angel Quiroz
#2

Updated by Angel Quiroz over 4 years ago

It works for me

#3

Updated by Yannick Warnier over 4 years ago

Works for me too. Could you be more specific about the issue and how you reproduce it?
Will close this if no further details provided within 3 days.

#4

Updated by AliaMori com over 4 years ago

Hello Yannick and Angel,

I figured out why certain links are not working for me:

I use AdBlock on my browsers. Here is an article with comprehensive statistics on % of people using adblock extensions and software. http://www.quora.com/What-is-the-percentage-of-Internet-users-that-employ-AdBlock-Plus-or-similar-ad-blocking-plugins

When enabled, the homepage links that do not work for me are: Inbox, Compose, Pending invitations,and social network

cheers,

r

#5

Updated by Angel Quiroz over 4 years ago

  • Status changed from Needs more info to Assigned

I installed the AdBlock Plus plugin on Firefox with the "Remove Social Media Buttons" setting enabled. And effectively some tools from Chamilo stop working. This, because AdBlock Plus hides certain classes in HTML documents.

The `section-social` and 'social-menu' classes are used in Social Network and Inbox tools.

To solve this bug, I renamed this two classes to `section-social-network` and `social-network-menu`. They are probably blocked later

There are icons named like `social-*.png` blocked.

#6

Updated by Angel Quiroz over 4 years ago

  • Status changed from Assigned to Needs testing
#7

Updated by AliaMori com over 4 years ago

I tested on both Chrome and Firefox: Thus far it is working perfectly.
Cien mil gracias.

#8

Updated by AliaMori com over 4 years ago

Angel, You most likely already saw this:
Here attached is a list of the "blockable items" on Chamilo 1.10 as per Adblock Plus (Firefox version) -- this list is generated with the following filters enabled: potential ads, social media buttons, tracking and malware domains.

In the users manual, it might be advisable to add a reminder to administrators and teachers to add Chamilo to their "whitelist" if using AdBlock or similiar plugins.
Thanx for your time.

#9

Updated by AliaMori com over 4 years ago

Only the first 8 items in the attached list are marked as "blockable" --- sorry.

#10

Updated by Yannick Warnier over 4 years ago

  • Status changed from Needs testing to Assigned
  • Assignee set to Angel Quiroz
  • % Done changed from 0 to 40
#11

Updated by Angel Quiroz over 4 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Angel Quiroz)
  • % Done changed from 40 to 80

Fixed. Image files renamed with the `sn-` prefix

b91733c
1633c22

#12

Updated by Yannick Warnier over 4 years ago

Hi Robert, please check on unstable.chamilo.org and let us know if this works for you.

#13

Updated by AliaMori com over 4 years ago

Hello Yannick,

As you know: I don't know squat about programming.
As a practitioner:

There are different plugins and services out there for ad blocking.
I use AdBlock Plus from https://eyeo.com/ , a nice German company that specialises in open source software.
AdBlock Plus seems to be more comprehensive when I use it on Firefox versus Chrome.
To be thorough, I enable all filters (potential ads, social media buttons, tracking and malware domains.)
On Firefox, I simply click "open blockable items". When I do this now, after the fix by Angel, I no longer observe any blockable items.
The 8 previous items are no longer highlighted.
From an amateur's point of view, it seems to be 100% fixed.

cheers and thanx!

r.

#14

Updated by Yannick Warnier over 4 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee set to Angel Quiroz
  • % Done changed from 80 to 100

No need for technical review, don't worry, I just expected you to did exactly what you did: try it online and see if it looks fine.
If all of our team had to install all the plugins and software that our users use that affects their navigation, it would be a nightmare, so we usually kindly ask our reporters to check after we published a patch, just to make sure that the developer doesn't have a false idea of what should have been fixed. This is our quality assurance process. If the reporter is available and acknowledges that the bug is fixed, and given the previous internal validation by one of our senior developers, we're good to go.

Also available in: Atom PDF