Project

General

Profile

Bug #7608

[1.9.10.2] Display previous attempt test button result in blank popup

Added by Hubert Borderiou over 4 years ago. Updated over 4 years ago.

Status:
Assigned
Priority:
Normal
Category:
Exercises
Target version:
-
Start date:
03/04/2015
Due date:
% Done:

0%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

HI,

on campus.chamilo.org 1.9.10.2
I pass a test
I click on "Show" to review my previous attempt and I've got a blick popup


Files

1.jpg (60.5 KB) 1.jpg Michael Jongkamp, 13/07/2015 09:39
2.jpg (65.2 KB) 2.jpg Michael Jongkamp, 13/07/2015 09:39

History

#1

Updated by Yannick Warnier over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Imanol Losada

Imanol, could you give a link to your fix for that? (it's already fixed)

#2

Updated by Yannick Warnier over 4 years ago

As discussed in person, showing the previous attempt should work in 1.10.x, but it should consider the results_disabled column (the option in the exercise creation that says "exam mode" should not be selected).

#3

Updated by Yannick Warnier over 4 years ago

  • Assignee changed from Imanol Losada to Julio Montoya
#4

Updated by Julio Montoya over 4 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

Yannick Warnier wrote:

As discussed in person, showing the previous attempt should work in 1.10.x, but it should consider the results_disabled column (the option in the exercise creation that says "exam mode" should not be selected).

In 1.10, when results_disabled = true, the option doesn't appear.
I can't reproduce the error.

#5

Updated by Yannick Warnier over 4 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Hubert Borderiou
  • Target version deleted (1.10.0)

Hubert, I'm not sure whether you want to put this in 1.9.x or not. I'll remove the "1.10.0" version so it doesn't block the release.

#6

Updated by Michael Jongkamp over 4 years ago

Is it already fixed? how can we get this fix?

In internet explorer (in 1.9.10.2) we have more strange effects when you click on "Show"

First you get a notice that you have insufficient rights to view this page and a link to the course homepage. (fig 1)
But when you click on the link to return to course homepage then you see this page in the learning content frame. (fig 2)

#7

Updated by Yannick Warnier over 4 years ago

Hi Michael,

We haven't fixed this in 1.9.x, only in 1.10.x. I believe the related fix is this https://github.com/chamilo/chamilo-lms/commit/2fdb8e62a8eb8a9f37fb9fe31f1d16f5788665f1 but it uses Bootstrap 3, which is a change in comparison to Boostrap 2 that we used in 1.9.x. Maybe you can check these changes and find you own fix for 1.9.10.2...?

In any case, you can also check the changes made to the main/exercice/overview.php file over the last year or so to try and get which one actually broke the popup. They're not too many, so you might find it quickly: https://github.com/chamilo/chamilo-lms/commits/2fdb8e62a8eb8a9f37fb9fe31f1d16f5788665f1/main/exercice/overview.php

#8

Updated by Miguel van den Branden over 4 years ago

Hello,

I think I found a fix.

Edit the following file: main/exercice/overview.php

On rule 168:

$attempt_url = api_get_path(WEB_CODE_PATH) . 'exercice/result.php?' . api_get_cidreq() . '&id=' . $attempt_result['exe_id'] . '&id_session=' . api_get_session_id() . '&height=500&width=950' . $url_suffix;

needs to be replaced by:

$attempt_url = api_get_path(WEB_CODE_PATH) . 'exercice/result.php?' . api_get_cidreq() . '&id=' . $attempt_result['exe_id'] . '&modal_size=lg' . $url_suffix;

The modal should work.

Also available in: Atom PDF