Project

General

Profile

Feature #7602

Replace deprecated jQuery's .toggle() with code

Added by Yannick Warnier over 4 years ago. Updated over 4 years ago.

Status:
Feature implemented
Priority:
High
Assignee:
Category:
Global / Others / Misc
Target version:
Start date:
30/03/2015
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

.toggle(handler, handler) has been removed from jQuery 1.9
In total, there are about 30 places in Chamilo (out of libraries) where we use ").toggle(".

Find them and replace them by an equivalent code that works for 1.9.

http://api.jquery.com/toggle-event/

Associated revisions

Revision 1399e0c8 (diff)
Added by Julio Montoya over 4 years ago

Use $form->addButtonAdvancedSetting(), remove advanced_parameter js code

See #7602

Revision 4e582642 (diff)
Added by Julio Montoya over 4 years ago

Fix toggle function see #7602

History

#1

Updated by Julio Montoya over 4 years ago

Use toggleClass.

#2

Updated by Julio Montoya over 4 years ago

  • Status changed from Assigned to Needs testing

I sent some fixes.

#3

Updated by Yannick Warnier over 4 years ago

Yeah... I think there are several cases where it's much more complicated than replacing with toggleClass(). Do your fixes cover all (bad) calls to toggle?

#4

Updated by Julio Montoya over 4 years ago

  • Assignee changed from Julio Montoya to Yannick Warnier

Yannick Warnier wrote:

Yeah... I think there are several cases where it's much more complicated than replacing with toggleClass(). Do your fixes cover all (bad) calls to toggle?

Is in fact more easy to do with toggleClass and the "click" events.
I fix all bad toggle that I found.

#5

Updated by Yannick Warnier over 4 years ago

  • Status changed from Needs testing to Feature implemented
  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 0 to 100

Looks good to me (couldn't find bugs, but this wasn't a "bugs" issue)

Also available in: Atom PDF