Project

General

Profile

Bug #7588

Comments for test results don't show up!

Added by Paweł Cisło over 4 years ago. Updated about 4 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
Exercises
Target version:
Start date:
18/03/2015
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

When I validate a test, the comments that I add for each of the students' answers (the "Edit individual feedback" field under each question) don't show up after saving my review. I don't see them after opening the feedback again, and neither does the student. I've lost quite a few comments, adding them in the certainty that they are being saved and students can see them, before I realized they were not there.


Files

exercise_show.php (29.2 KB) exercise_show.php exercise_show.php version 470c12d0 with e4ba3c92 included, and 73e38162 excluded Cf #7588 Torkil Zachariassen, 09/04/2015 17:12

Related issues

Related to Chamilo LMS - Bug #7448: Coaches submit responses to attempts while response is forbidden.Bug resolved15/12/2014

Actions

Associated revisions

Revision 4a50c752 (diff)
Added by Imanol Losada over 4 years ago

Fix bad url - refs #7588

Revision d42cd00a (diff)
Added by Julio Montoya over 4 years ago

Fix exercise result correction see #7588

History

#1

Updated by Torkil Zachariassen over 4 years ago

This might be related to #7448, where educators, in sessions, were able to comment on attempts, but the submit button failed. I had to modidify the code in order to make this work.

first we tried to allow coaches to edit in sessions, but had to turn this off, as this enabled coaches to erase central tests through the excerceses pool.

...torkil... still on 1.9.8 until. next week :-)

#2

Updated by Yannick Warnier over 4 years ago

  • Category set to Exercises
  • Target version set to 1.10.0

Thanks for reporting. We'll try to verify that on 1.10.x. We don't support earlier versions for small bugs, but hopefully the patch we provide for this one in future versions can be applied to your version easily.

#3

Updated by Yannick Warnier over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Imanol Losada
#4

Updated by Imanol Losada over 4 years ago

  • Assignee changed from Imanol Losada to Yannick Warnier
  • % Done changed from 0 to 70

Tested on 1.10. It works fine.

Steps done:
- Create an exercise as admin
- Complete it as student
- Validate it as admin, add feedback and save
- Edit feedback and save again

#5

Updated by Imanol Losada over 4 years ago

Student test validation URL fixed
PR: https://github.com/chamilo/chamilo-lms/pull/607

#6

Updated by Yannick Warnier over 4 years ago

  • Status changed from Assigned to Bug resolved
  • Assignee changed from Yannick Warnier to Imanol Losada
  • % Done changed from 70 to 100

Closing (not reported any issue with the patch)

#7

Updated by Yannick Warnier over 4 years ago

  • Status changed from Bug resolved to Assigned

Simbulu reports on IRC that the issue is still present in 1.9.10.2 and would like to help fix it.

#8

Updated by Torkil Zachariassen over 4 years ago

The comments worked fine in 1.9.8, but broke after an upgrade to 1.9.10 (Note: This is not against 1.10.0, but 1.9.x)

Testing various versions of exercise_show.php from
https://support.chamilo.org/projects/chamilo-18/repository/changes/main/exercice/exercise_show.php?rev=1.9.x

(exercise_show.php, exercise_show.php-1.9.8-works, exercise_show.php_73e38162, exercise_show.php_fc3508ec, exercise_show.php.000, exercise_show.php_470c12d0, exercise_show.php_9e5c73a8) provided some insight:
BROKEN: 9e5c73a8
BROKEN: 73e38162
WORKS: 470c12d0
WORKS: 9e5c73a8
WORKS: fc3508ec

Thus the lastest version that works, is 470c12d0

The culprit was found to be 73e38162 ( BT#9247 https://support.chamilo.org/projects/chamilo-18/repository/revisions/73e381620438970423d371e717ad0bb8d5667a29 ), and I did not manage to fix this part.

Using 470c12d0 I managed to incorporate the changes from the latest version (9e5c73a8) by hand. So basicly we can use the latest version, but have to eliminate whatever happend in 73e38162.

The result is attached, and works for me as a workaround for now.

#9

Updated by Imanol Losada over 4 years ago

  • Assignee changed from Imanol Losada to Yannick Warnier
#10

Updated by Yannick Warnier over 4 years ago

  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 100 to 50

Julio, could you review this? It has to do with your changes to the max number of fckeditors, but note that this is only for 1.9.x (so don't send anything to 1.10.x)

#11

Updated by Julio Montoya over 4 years ago

  • Assignee changed from Julio Montoya to Yannick Warnier
#12

Updated by Yannick Warnier over 4 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Yannick Warnier to Torkil Zachariassen
  • % Done changed from 50 to 80

Torkil, care to comment? You should be able to try that on https://stable.chamilo.org

#13

Updated by Yannick Warnier about 4 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee changed from Torkil Zachariassen to Julio Montoya
  • % Done changed from 80 to 100

Considered fixed.

Also available in: Atom PDF