Chamilo LMS

Torkil Zachariassen wrote:

While the setting "Allow coaches to edit inside course sessions" is set to "No" coaches can still comment and grade the attempts their student made, just to find that the fails with a comment that they were not authorized to use this function - which is correct, but difficult to debug.

When "Allow coaches to edit inside course sessions" is set to "No" course coaches can't access to the exercise results or edit user results.

Check course:

https://stable.chamilo.org/main/exercice/exercice.php?gradebook=&cidReq=TEST1&id_session=13&gidReq=0&origin=

l/p: coach/coach

I'll maintain it open for a while, just in case we have time to reproduce it, but postpone it to a later version (again)

Closing now, as this doesn't seem to have generated further issues.

After upgrading to 1.9.10 we were able to reproduce the original error, and made a little film to illustrate the problem at hand.

In 1.9.8 we managed to resolve the issue by using a $is_ok variable defined like this

$is_ok=api_is_course_session_coach(api_get_user_id(), api_get_course_id(), api_get_session_id());

Currently we are working on a resolution of this in 1.9.10.

To be continued ...

This should be fixed already in 1.10

Problem was in the URL no api_get_cidreq

I applied a fix:

https://github.com/chamilo/chamilo-lms/commit/947883b970fc5556f19c2a4997531adba9ecf0fb

Why the allow_coach_feedback_exercises was created? A request for a client?

A settings that undoes another setting is not a very good idea ...

Because the other option (allow coaches to edit) is very generical. The allow_coach_feedback_exercises option is more specific, so you can remove the permissions in general but let the coach edit the exercises only, if you want.
I know... it's a bit far-fetched and I don't think many people will use it, but it fixes the issue reported, together with adding a reasonnable flexibility.

Julio, is there a need to update unstable.chamilo.org manually or is there an automated doctrine command that goes with the cron update?

Torkil, you're in charge to review this on https://unstable.chamilo.org/
Otherwise it will be considered closed in 5 days.

Yannick Warnier wrote:

Because the other option (allow coaches to edit) is very generical. The allow_coach_feedback_exercises option is more specific, so you can remove the permissions in general but let the coach edit the exercises only, if you want.
I know... it's a bit far-fetched and I don't think many people will use it, but it fixes the issue reported, together with adding a reasonnable flexibility.

Julio, is there a need to update unstable.chamilo.org manually or is there an automated doctrine command that goes with the cron update?

This command will update the DB based in the entities.

php bin/doctrine.php orm:schema-tool:update --force

This command will run pending migrations based in the migration status here.
Be careful, by default the version status is "0" in fresh install.

php bin/doctrine.php migrations:migrate --configuration=app/config/migrations.yml

To see the current status:

php bin/doctrine.php migrations:status --configuration=app/config/migrations.yml

Closed (no feedback and reasonable solution provided for 1.10.0)