Project

General

Profile

Feature #7255

( Forum) Foro > Tema de Foro > no permite subir más de 1 adjunto

Added by Michela Mosquera almost 6 years ago. Updated over 5 years ago.

Status:
Feature implemented
Priority:
Normal
Assignee:
Yannick Warnier
Category:
Forum
Target version:
1.9.10
Start date:
28/08/2014
Due date:
% Done:

100%

Estimated time:
Spent time:
37.45 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Pasos:
1. Crear un curso
2. Ir a la herramienta de Foros
3. Crear un Foro y dentro del foro crear un Nuevo Tema
No permite subir/Eliminar más de 01 archivo adjunto, debería permitir subir/eliminar 1 ó más archivos como adjunto a un "Nuevo Tema"
4. Lo mismo pasa en Responder a ese Tema , Responder a este mensaje Citar este mensaje
en cualquier interacción en el nuevo Tema No permite subir más de 01 archivo adjunto, debería permitir subir/Eliminar 1 ó más archivos como adjunto a un "Nuevo Tema"

Files

1-2.png (14.6 KB) 1-2.png Michela Mosquera, 28/08/2014 18:22
button.png (23.4 KB) button.png Alex Aragon, 24/10/2014 01:25

Related issues

Related to Chamilo LMS - Feature #7348: Estilo para Documento Upload igual que carga de foro.Feature implemented24/10/2014

Actions

Associated revisions

Revision ef242abd (diff)
Added by Daniel Barreto over 5 years ago

Add multiple file upload and show list of attachment files from view threads. It is working but need to improve design - refs #7255

Revision 66631c4f (diff)
Added by Daniel Barreto over 5 years ago

Add recover forum.ajax.php Fix javascript code, request params add security, need lang variables translation and more comment the new code - refs #7255

Revision 09b01b9b (diff)
Added by Daniel Barreto over 5 years ago

Add comments and minor refactor - refs #7255

History

#1

Updated by Angel Quiroz almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Angel Quiroz
#2

Updated by Angel Quiroz almost 6 years ago

  • Assignee deleted (Angel Quiroz)
#3

Updated by Angel Quiroz almost 6 years ago

  • Status changed from Assigned to New
#4

Updated by Daniel Barreto almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Daniel Barreto
#5

Updated by Daniel Barreto almost 6 years ago

  • % Done changed from 0 to 10
For this feature will need:
  • Allow to upload multile files in forum message form (search into forumfunction.inc.php)
  • Process upload of files to temporal folder (into archive folder) by ajax
  • Update form validation to check if is not ajax upload in process and temporal folder into archive
  • Update threads to show many files
#6

Updated by Daniel Barreto almost 6 years ago

  • % Done changed from 10 to 40
Add changes to allow multiple files upload.
Its working but need some improvements:
  1. Recover files uploaded when form is wrong and allow delete them
  2. Recover files when editing post from forum
  3. Improve design when show all files attached
  4. Add a option to configure max attachment files by post.

PR366:
https://github.com/chamilo/chamilo-lms/pull/366
DO NOT MERGE YET

#7

Updated by Daniel Barreto almost 6 years ago

  • % Done changed from 40 to 50

More things to do:

  1. Complete filter to show correct attachment by post (cases: new post, reply, edit post)
  2. Allow to delete a attachment file (from Database and file system)
  3. Improve design how to show attachment list into posts
#8

Updated by Daniel Barreto almost 6 years ago

Complete how to select correct attachment by forum posts and Update to allow delete attachment files, but need to improve security and desing.

PR has ben updated (overwrite pevious commit)
NOT ready yet.

#9

Updated by Daniel Barreto almost 6 years ago

Recuperando archivo forum.ajax.php

#10

Updated by Daniel Barreto almost 6 years ago

  • form.ajax.php fully recovered.
  • Fix javascript code
  • Add more security
  • Fix http request params (urls)

Finally need to improve design

#11

Updated by Daniel Barreto almost 6 years ago

  • % Done changed from 50 to 60
  • Add comments and documentation
  • Minor refactor
#12

Updated by Alex Aragon over 5 years ago

Con Daniel estamos revisando el diseño, de presentación, el boton tiene un comportamiento rato, no muestra el progreso de la carga del archivo, con respecto a la visualización cuando es replay del mensaje hay un iframe que muestra el contenido de mensajes anteriores, cabe mencionar si es necesario o no, en mi caso recomiendo solo mostrar el contenido del mensaje a responder y no todo el hilo.

Falta definir la apariencia del botom de carga

#13

Updated by Alex Aragon over 5 years ago

Se mejoro la presentación del button de subida de archivos, Daniel trabajara en el orden de la estructura de las cosas.

#14

Updated by Daniel Barreto over 5 years ago

  • Assignee changed from Daniel Barreto to Yannick Warnier
  • % Done changed from 60 to 70

Update functions to use new design

Update PR#366
https://github.com/chamilo/chamilo-lms/pull/366

It's ready to review and test

#15

Updated by Yannick Warnier over 5 years ago

  • Assignee changed from Yannick Warnier to Daniel Barreto

Re-assigned to Daniel for a bit of cleaning

#16

Updated by Daniel Barreto over 5 years ago

  • Assignee changed from Daniel Barreto to Yannick Warnier

Things done:
Improve code style (PSR-2)
Add more documentation
Remove unused code (about $path variable in upload file ajax form)

Update PR#366
https://github.com/chamilo/chamilo-lms/pull/366

#17

Updated by Yannick Warnier over 5 years ago

  • Status changed from Assigned to Feature implemented
  • % Done changed from 70 to 100

Reviewed and merged. Closing.

Also available in: Atom PDF