Project

General

Profile

Bug #7077

Learning path - Didn't show the bottom part of large documents

Added by Alberto Torreblanca about 7 years ago. Updated almost 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Daniel Barreto
Category:
Learning paths / Lecciones
Target version:
1.9.8
Start date:
11/04/2014
Due date:
24/04/2014
% Done:

100%

Estimated time:
Spent time:
3.60 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

When you have a large documento, you can't see the last part of it. This is a big problem when exercises are attached to learning path, because the student can't solve the complete test.
Screenshot

Files

image_007.jpeg (35.7 KB) image_007.jpeg Screenshot Alberto Torreblanca, 11/04/2014 02:51
chamilo_issue.png (208 KB) chamilo_issue.png Learning path full view Alberto Torreblanca, 11/04/2014 03:18
7077_1.png (192 KB) 7077_1.png Daniel Barreto, 11/04/2014 23:13
7077_2.png (167 KB) 7077_2.png Daniel Barreto, 11/04/2014 23:13
scroll1.png (81.5 KB) scroll1.png Yannick Warnier, 25/04/2014 01:14
scroll2.png (87.6 KB) scroll2.png Yannick Warnier, 25/04/2014 01:14
01chamilo_lp.png (273 KB) 01chamilo_lp.png Alberto Torreblanca, 25/04/2014 22:28
full_1.png (111 KB) full_1.png Daniel Barreto, 29/04/2014 00:35
mini_1.png (97.3 KB) mini_1.png Daniel Barreto, 29/04/2014 00:35
full_2.png (91.2 KB) full_2.png Daniel Barreto, 29/04/2014 00:35
mini_2.png (75.9 KB) mini_2.png Daniel Barreto, 29/04/2014 00:35

Associated revisions

Revision b1344084 (diff)
Added by Daniel Barreto about 7 years ago

Update lp view to consider control bar view refs #6033 #7077

Revision 512633e6 (diff)
Added by Daniel Barreto about 7 years ago

Update lp view to resize right when return from control view refs #6033 #7077

Revision 3e5d6f80 (diff)
Added by Daniel Barreto almost 7 years ago

Update UpdateContentHeight() to use JQuery and fix div sizes
Minor: update variables names from french to english language to make it more legible -refs #7077 #6033

Revision bb6b3328
Added by Yannick Warnier almost 7 years ago

Merge pull request #284 from danbarretodev/6033

Fix bug -refs #7077 refs #6033

History

#1

Updated by Alberto Torreblanca about 7 years ago

The problem is in the other learning path view too.
Learning path full view

#2

Updated by Yannick Warnier about 7 years ago

  • Category set to Learning paths / Lecciones
  • Assignee set to Daniel Barreto
  • Target version set to 1.9.8

Daniel was working on this. There is a pull request waiting for review. If you know how to pull it locally from Daniel's branch, maybe you can test it and let us know if it works? https://github.com/chamilo/chamilo-lms/pull/257

#3

Updated by Yannick Warnier about 7 years ago

I'm assigning it to Daniel so he can check the other view too. If this is fixed, then we just need confirmation that it is fixed to close the task.

#4

Updated by Daniel Barreto about 7 years ago

Update the PR 257
https://github.com/chamilo/chamilo-lms/pull/257

Here some pictures

Menu view

Control view

#5

Updated by Yannick Warnier almost 7 years ago

The update has been pulled. Alberto, can you confirm the fix on https://stable.chamilo.org, so we can close this task?

#6

Updated by Yannick Warnier almost 7 years ago

  • Due date set to 24/04/2014
#7

Updated by Yannick Warnier almost 7 years ago

  • Status changed from Needs testing to Assigned
  • Assignee set to Daniel Barreto

When opening https://stable.chamilo.org/main/newscorm/lp_controller.php?cidReq=CURSO2&id_session=0&gidReq=0&origin=&action=view&lp_id=1 as user student/student (not as an admin, so the upper bar doesn't show) in normal view mode but with a very low resolution (with CTRL+SHIFT+M in Firefox), and I open my tracking screen, I cannot see (nor scroll to) the last lines.

#8

Updated by Yannick Warnier almost 7 years ago

Attaching proof :-)

#9

Updated by Alberto Torreblanca almost 7 years ago

I send a commit solving this issue. The problem was in the to sides of the lp. But the commit solve partily, at the first view all is OK. Wheb you swith hide and unhide the lp the problem return. At the bottom i there a lot of white space that you can't see (MISTAKE IN IMAGE).CANCEL THE PULL REQUEST IN REPO

#10

Updated by Daniel Barreto almost 7 years ago

Fix wrong size of left,right content, and hide bar
Update funtion to user JQuery
Hide left panel will call resize function too
Minor: rename some variable from french to english language

Done in PR#284
https://github.com/chamilo/chamilo-lms/pull/284

#11

Updated by Yannick Warnier almost 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Daniel Barreto to Alberto Torreblanca

PR merged. Please test on stable.chamilo.org

#12

Updated by Yannick Warnier almost 7 years ago

Alberto!

#13

Updated by Yannick Warnier almost 7 years ago

  • Assignee deleted (Alberto Torreblanca)

Unassigning from Alberto as he doesn't seem to have time to check it.
I'm adding Alex as an observer and closing this task. We have improved the previous situation a lot already, and Alex will have to work on a design task (#6999) to review it anyway, but this can wait after the beta is published as it is only a set of minor CSS/JS changes.

#14

Updated by Yannick Warnier almost 7 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee set to Daniel Barreto
  • % Done changed from 80 to 100

Also available in: Atom PDF