Project

General

Profile

Bug #7005

anonymous access to the open course

Added by marcos andrade over 7 years ago. Updated about 7 years ago.

Status:
Needs more info
Priority:
Normal
Assignee:
-
Category:
Global / Others / Misc
Target version:
Start date:
12/03/2014
Due date:
24/04/2014
% Done:

70%

Estimated time:
1.00 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Ao publicar um curso livre a usuarios não registrados, o botão de acesso não aparece de imediato nos "cursos populares".
É necessário mostrar a categorias de cursos na página inicial e acessar o curso pelo link da categoria, depois, ao voltar a página inicial, o botão fica visivel para o acesso aos cursos livres.

___________________________________
sorry if my english is bad, I'm using google

When you publish a free to registered users do not progress, the access button will not appear immediately in the "popular courses."
It is necessary to show the categories of courses on the home page and access the course by category link, then back to the home page, the button is visible for access to free courses.


Files

chamilo_process.png (583 KB) chamilo_process.png marcos andrade, 12/03/2014 16:47

Associated revisions

Revision 315adbdb (diff)
Added by Yoselyn Castillo over 7 years ago

Fixing comparing date when showing popular courses refs #7005

Revision 31e647d9
Added by Yannick Warnier about 7 years ago

Merge pull request #231 from ycastillo/yoselyn.7005

Fixing comparing date when showing popular courses refs #7005

Revision 21f146fe (diff)
Added by Yoselyn Castillo about 7 years ago

Showing gotocourse button -refs #7005

Revision 38f2be7c
Added by Yannick Warnier about 7 years ago

Merge pull request #270 from ycastillo/7005

Showing gotocourse button -refs #7005

History

#1

Updated by Yannick Warnier over 7 years ago

  • Category set to Global / Others / Misc
  • Status changed from New to Assigned
  • Assignee set to Yoselyn Castillo
  • Target version set to 1.9.8
  • Estimated time set to 1.00 h

Hi Marcos!

I hope you understand written English as well (my Portuguese is not so good).

If I understand well, you are saying that when opening a "public" course (open to all), it appears in the popular courses but the button that says "Go to course" does not appear, so you have to do other things first (like show categories etc) in order to have this button appear?

If that is the case, it is a bug. I am assigning Yoselyn to check this and find a solution, as she has previously worked on that part of the code.

Thank you for reporting.

#2

Updated by marcos andrade over 7 years ago

!
Yannick Warnier wrote:

Hi Marcos!

I hope you understand written English as well (my Portuguese is not so good).

If I understand well, you are saying that when opening a "public" course (open to all), it appears in the popular courses but the button that says "Go to course" does not appear, so you have to do other things first (like show categories etc) in order to have this button appear?

If that is the case, it is a bug. I am assigning Yoselyn to check this and find a solution, as she has previously worked on that part of the code.

Thank you for reporting.

#3

Updated by marcos andrade over 7 years ago

this is exactly what is happening, I'm posting a picture to try to show the best case.

Thanks for answering

marcos andrade wrote:

Ao publicar um curso livre a usuarios não registrados, o botão de acesso não aparece de imediato nos "cursos populares".
É necessário mostrar a categorias de cursos na página inicial e acessar o curso pelo link da categoria, depois, ao voltar a página inicial, o botão fica visivel para o acesso aos cursos livres.

___________________________________
sorry if my english is bad, I'm using google

When you publish a free to registered users do not progress, the access button will not appear immediately in the "popular courses."
It is necessary to show the categories of courses on the home page and access the course by category link, then back to the home page, the button is visible for access to free courses.

#4

Updated by Yoselyn Castillo over 7 years ago

  • % Done changed from 0 to 60

I have created a new course.
I have logged the course many times in order to show it in most popular courses.
"Go to the course" button appears successfully
But i have sent a fix for date comparison when showing courses.
https://github.com/chamilo/chamilo-lms/pull/231

#5

Updated by marcos andrade about 7 years ago

Yoselyn Castillo wrote:

I have created a new course.
I have logged the course many times in order to show it in most popular courses.
"Go to the course" button appears successfully
But i have sent a fix for date comparison when showing courses.
https://github.com/chamilo/chamilo-lms/pull/231

Good morning, did not quite understand the answer.
In its test button appears ok despite not having accessed any course?
On my website you need to access at least some progress, after this the button will appear on the main page in the list of popular courses.

#6

Updated by Yoselyn Castillo about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Yoselyn Castillo to marcos andrade

It works now ok for me, you can create a new course and access many times to it in order it will appear in most popular. When it becomes popular it successfully appears in home page

#7

Updated by Yannick Warnier about 7 years ago

  • Status changed from Needs testing to Bug resolved
  • % Done changed from 60 to 100

Assuming bug is resolved for lack of feedback. Please don't hesitate to re-open if you feel the contrary.

#8

Updated by marcos andrade about 7 years ago

Yoselyn Castillo wrote:

It works now ok for me, you can create a new course and access many times to it in order it will appear in most popular. When it becomes popular it successfully appears in home page

Sorry if I expressed myself badly, the course appears, which is not appear the button to access the course even though it is public.
Please go to:
http://switweb.com/cursos/

And check out what I'm talking about, the course "php for beginners" is released, but the access button will not appear in the list of popular courses.

The course is listed but does not have access to.

Only after that accesses a course from the list "category" the access button appears on the main page.

#9

Updated by Yannick Warnier about 7 years ago

  • Status changed from Bug resolved to Assigned
  • Assignee changed from marcos andrade to Yoselyn Castillo
  • % Done changed from 100 to 70

Indeed, and clearing cookies removes the button again. Thank you for this example.
Por lo general, Marcos, puedes hablar en español para dar detalles (lo importante es el título).

Yoselyn, el problema está en que, por alguna razón, si el usuario no ha entrado al curso en su sesión de uso (aunque esté como anónimo), no le aparece el botón azul "Ir al curso".
No se a que se debe precisamente, pero el ejemplo de Marcos funciona bien para revisarlo.

#10

Updated by Yoselyn Castillo about 7 years ago

testing this..

#11

Updated by Yannick Warnier about 7 years ago

  • Due date set to 24/04/2014
#12

Updated by Yoselyn Castillo about 7 years ago

Comprobado, es que solo habia hecho las verificaciones en user_portal.php
En main/inc/lib/course.lib.php es necesario agregar una verificacion en la linea 4227
if ($access_link && in_array('enter', $access_link) || $course_info['visibility'] == COURSE_VISIBILITY_OPEN_WORLD)
Ahora envio el pull request
Saludos

#13

Updated by Yoselyn Castillo about 7 years ago

#14

Updated by Yoselyn Castillo about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Yoselyn Castillo)
#15

Updated by marcos andrade about 7 years ago

Yoselyn Castillo wrote:

Comprobado, es que solo habia hecho las verificaciones en user_portal.php
En main/inc/lib/course.lib.php es necesario agregar una verificacion en la linea 4227
if ($access_link && in_array('enter', $access_link) || $course_info['visibility'] == COURSE_VISIBILITY_OPEN_WORLD)
Ahora envio el pull request
Saludos

He cambiado la porción de código indicado, pero no estaba en la línea 4227.
Y sin embargo, no aparece en el botón para el acceso al curso.
Gracias por la ayuda hasta la fecha

#16

Updated by Yannick Warnier about 7 years ago

  • Status changed from Needs testing to Assigned
  • Assignee set to Julio Montoya
#17

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

No puedo reproducir el error.

En el portal:

https://stable.chamilo.org/index.php

Aparece el curso "agenda" (curso público/abierto para todos) y aparece el botón "Ir al curso" y puedo ingresar sin problemas.

Tal vez el problema está en los archivos temporales. Entrar como admin y limpiarlos con:

main/admin/archive_cleanup.php
#18

Updated by Yannick Warnier about 7 years ago

  • Target version changed from 1.9.8 to 2.0

Bueno, por ahora lo pongo en v10 entonces. A ver si encontramos algo antes de la publicación de la 1.9.8

#19

Updated by marcos andrade about 7 years ago

Julio Montoya wrote:

No puedo reproducir el error.

En el portal:

[...]

Aparece el curso "agenda" (curso público/abierto para todos) y aparece el botón "Ir al curso" y puedo ingresar sin problemas.

Tal vez el problema está en los archivos temporales. Entrar como admin y limpiarlos con:

[...]

se muestra el error en mi sitio:
http://switweb.com/cursos/index.php

Chamilo ya reinstalado de nuevo, pero todavía no puede mostrar la lista de acceso mediante un botón de golf popular para el curso.
Tienes efetuei borrar la memoria caché.

#20

Updated by marcos andrade about 7 years ago

La situación ha cambiado aquí.
He descargado la versión 1.9.8 de este enlace:
https://code.google.com/p/chamilo/downloads/list

Y copiar el main / inc / lib / course.lib.php en mi instalación 1.9.6
Con la línea cambió de 3871:

if ($access_link && in_array('enter', $access_link)){

para

if ($access_link && in_array('enter', $access_link) || $course_info['visibility'] == COURSE_VISIBILITY_OPEN_WORLD) {

Y el botón para ir al curso comenzó a aparecer.
Vio la diferencia de los archivos, pero parece tener alguna otra cosa diferente.
Probablemente el cambio de Yoselyn Castillo trabajará en la versión 1.9.8

Also available in: Atom PDF