Project

General

Profile

Bug #6981

jquery.lp_minipanel.js code error.

Added by Adolfo Igualada Martínez over 5 years ago. Updated over 5 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
Learning paths / Lecciones
Target version:
Start date:
11/02/2014
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,
In jquery.lp_minipanel.js there is an error in line 46 :

var left_width = $('learning_path_left_zone').width();

The left_width var never gets the value because the learning_path_left_zone is an id and must have the #.
The line must be :
var left_width = $('#learning_path_left_zone').width();
.

Other bug I confirmed in Chrome is when you close the minipanel and reopens the learning path right zone is white. It appears a problem with chrome and the value assigned in this line (80)

$('#learning_path_right_zone').css('marginLeft', left_width + 10 + 'px');

$('#learning_path_right_zone').css('marginLeft', left_width + 25 + 'px');

Instead of plus 10 to left_width var plus 25 solves the problem, perhaps needs more testing.

Associated revisions

History

#2

Updated by Yoselyn Castillo over 5 years ago

  • Status changed from New to Needs more info
  • % Done changed from 0 to 50

This change makes sense but i could not reproduce the original bug in Learning path. Could you tell me which is the specific bug in order to confirm it is completely solved?
Also,I don't think it's a good idea to include other changes in this pull request like here
https://github.com/chamilo/chamilo-lms/pull/199
Each change should be in separated pulls

#3

Updated by Adolfo Igualada Martínez over 5 years ago

In Chrome when you close the minipanel and reopens the learning path right zone is white.

#4

Updated by Yannick Warnier over 5 years ago

  • Status changed from Needs more info to Bug resolved
  • % Done changed from 50 to 100

Pulled.
Thanks!

Also available in: Atom PDF