Project

General

Profile

Bug #6902

When all attendances are hidden, it creates a new attendance

Added by Daniel Barreto about 6 years ago. Updated almost 6 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Category:
Attendances/Asistencias
Target version:
Start date:
30/12/2013
Due date:
% Done:

80%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

When there is no more attandance active, the system automatically creates a new attendance, this could be annoying cause the attandance can be deleted by interface just be hidden.
Other problem is in student view, still show the list of attendances, but the student can't see them. This could confuse to the teacher.

Associated revisions

Revision 8e7903ff (diff)
Added by Daniel Barreto about 6 years ago

Delete "AND active=1", this was in a function called to verify if at least an attendance exists, but was verifying if exists an active then an attendance was created by default in attendance_list.php -refs #6902

Revision ec28672c (diff)
Added by Daniel Barreto about 6 years ago

Add a parameter to count all, active or inactive attendance, and in get_attendance_data() add an if() to only show active attendance to students and view of students -refs #6902

Revision 8a66f323
Added by Yannick Warnier about 6 years ago

Merge pull request #192 from danbarretodev/6902

Fix bug - refs #6902

History

#1

Updated by Daniel Barreto about 6 years ago

  • Status changed from Assigned to Needs testing
  • % Done changed from 0 to 80

Add a parameter to get_number_of_attendance() to choose all, active o inactive attendance.
Change in get_attendance_data() to show all attendance if the user can edit it and isn't in student view mode. Otherwise only show active attendance.

Done in
https://github.com/chamilo/chamilo-lms/pull/192

#2

Updated by Yannick Warnier almost 6 years ago

  • Assignee changed from Daniel Barreto to Yoselyn Castillo

Yoselyn, I need you to check the effect on the interface for this one.

#3

Updated by Yoselyn Castillo almost 6 years ago

This is the result of my tests:
In teacher view:
I have entered the attendances tool
It shows attendances list
I have deleted all attendances
They are in the list but It has became invisible (status grey)
In student view:
It doesn´t show any attendance.
This behaviour makes sense for me: Students can not see deleted attendances
Teacher can see and edit them

#4

Updated by Yoselyn Castillo almost 6 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee deleted (Yoselyn Castillo)

Also available in: Atom PDF