Project

General

Profile

Bug #6837

Inconsistency in tests and questions beetwen master and session courses - some help needed

Added by Hubert Borderiou over 7 years ago. Updated about 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Sessions
Target version:
Start date:
26/11/2013
Due date:
% Done:

10%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi, I did some tests in session tests (quiz) and I 've found some strange behaviour.
Can you report me, if it is the desired behavior

Here is a summury of my tests.
I can modify test items in Session course, and it modify test items in Master course.

MASTER COURSE                                             SESSION COURSE                        RIGHT     WRONG 
--------------------------------------------+----+----------------------------------------+----------+--------
I create a test MasterQuiz1                 | -> | Test MasterQuiz1 visible               |    X     |
--------------------------------------------+----+----------------------------------------+----------+--------
I create a question MasterQuestion1         | -> | Question MasterQuestion1 visible       |    X     |
--------------------------------------------+----+----------------------------------------+----------+--------
I create a test catagory MasterTestCategory1| -> | Test category MasterTestCategory1      |    X     |
                                            |    | visible                                |          |
--------------------------------------------+----+----------------------------------------+----------+--------
.
.
.
.
SESSION COURSE                                         MASTER COURSE                        RIGHT     WRONG 
--------------------------------------------+----+----------------------------------------+----------+--------
I create a test SessionTest1                | -> | Test not visible in Master course      |    X     |
--------------------------------------------+----+----------------------------------------+----------+--------
I create a question SessionQuestion1        | -> | Question not visible in Master course  |    X     |
--------------------------------------------+----+----------------------------------------+----------+--------
I create a test category                    | -> |   Test category SessionTestCatagory1   |          |   X
SessionTestCatagory1                        |    |   visible in Master course             |          |
--------------------------------------------+----+----------------------------------------+----------+--------
I go to Recycle Existing Question           | -> | Modification of MasterQuestion1        |          |   X
I reuse question MasterQuestion1            |    | are visible in Master Course           |          |
I modify question MasterQuestion1           |    | (as a result in every session courses  |          |    
                                            |    | of Master course)                      |          |
--------------------------------------------+----+----------------------------------------+----------+--------
I modify MasterQuiz1                        | -> | Modification visible in Master course  |          |   X
(I can do it, see Fig. 1)                   |    |                                        |          |    
--------------------------------------------+----+----------------------------------------+----------+--------

As a result, as for me, these are inconsistencies in Session and Quiz.
Are you agree ?

Fig. 1

Associated revisions

Revision 56d5a28f (diff)
Added by Julio Montoya about 7 years ago

Fixing category list filtered by session_id see #6837

Revision e6e97e02 (diff)
Added by Julio Montoya about 7 years ago

Blocking master exercise edition in a session see #6837

Revision c1536b73 (diff)
Added by Julio Montoya about 7 years ago

Adding session_id in exercise see #6837

History

#1

Updated by Yannick Warnier about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Hubert Borderiou
  • % Done changed from 0 to 10

Hubert Borderiou wrote:

Hi, I did some tests in session tests (quiz) and I 've found some strange behaviour.
Can you report me, if it is the desired behavior

Here is a summury of my tests.
I can modify test items in Session course, and it modify test items in Master course.

This should never be possible, so I agree that this is a bug (although I haven't checked it). Edition of base-course-tests through sessions should be forbidden, or at minimum should be made on a copy of the base course test inside the session, or a test completely created inside the session.

The questions are a special case that we didn't check enough, and I can understand that in some case the proper interface changes might be missing, so that it would seem to be normal to be able to edit it: it's not!
Through sessions, you should not have access to the edition of questions that are in the base course (only to those of the session-only).
You should be able to copy a question from inside the questions bank. If you copy a base-course question from a session, this becomes a session-specific question.

#2

Updated by Hubert Borderiou about 7 years ago

To remove the pen :
main/exercice/overview.php
line 77
replace
if ($is_allowed_to_edit) {
with something like
if ($is_allowed_to_edit && api_get_session_id() == 0) {

May be we could add the same test for test in LearningPath to disabled modification in overview page, but I don't find it.

#3

Updated by Hubert Borderiou about 7 years ago

  • Status changed from Assigned to New
  • Assignee deleted (Hubert Borderiou)
#4

Updated by Yannick Warnier about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
#5

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

I sent some fixes to resolve the 3 "WRONG" in the table.

But I have a question:

Right now a teacher from a course session can edit a question in the master course, because a question it self is not related to a session_id. The exercise is related to a session, so there are some orphan master questions that can be edited in a course session.

#6

Updated by Yannick Warnier about 7 years ago

True... true...

I think we need to move this to 1.10 and add an (optional) session_id to the c_quiz_question table and, if it doesn't contain a session_id, prevent the tutor to update it from the session. I see no other solution...
Any better idea?

Will move to 1.10 if no better idea before Wednesday 23/04

#7

Updated by Julio Montoya about 7 years ago

  • Status changed from Needs more info to New
  • Target version changed from 1.9.8 to 2.0

Also available in: Atom PDF