Feature #6715
Integrate embedded support tickets management as a plugin
Description
El objetivo de esta tarea es de integrar un sistema de tickets de soporte a Chamilo 1.9.8, por lo que se tendrá que hacer como un plugin en esta versión (ya que requiere de cambios de base de datos). Quizás será integrato luego en Chamilo 1.10 como una funcionalidad nativa.
Para realizar esta integración, Kenny ya tiene código existente que convertirá a un plugin, usando como base el plugin "bbb" que tiene todas las correctas maneras de implementar la clase "Plugin" disponible en chamilo/main/inc/lib/plugin.class.php
Para ello, Kenny contará con el apoyo de Yannick y Julio, ya que el código que tiena ahora:- no está en forma de plugin
- declara nuevas tablas que posiblemente no respetan los estándares de denominación de Chamilo
- usa variables y código que posiblemente no respetan nuestras Coding conventions
- no usa variables de idiomas
Por lo tanto, se trata de una tarea relativamente grupal. Me gustaría tener el plugin listo para mostrar en el Chamilo Users Day de Madrid. Para ello, tendría que estar listo dentro de aproximadamente 2 semanas de aquí.
Kenny estará desarrollando la primera versión en su repositorio: https://github.com/kennyrodas/chamilo-lms
Files
| Selection_001.png (29.2 KB) Selection_001.png | |||
| Selection_002.png (38.2 KB) Selection_002.png | |||
| Selection_003.png (32.9 KB) Selection_003.png | |||
| Selection_004.png (57.4 KB) Selection_004.png | |||
| Selection_005.png (38 KB) Selection_005.png | |||
| Selection_006.png (61.9 KB) Selection_006.png | |||
| first (100 KB) first | |||
| detail.png (62.7 KB) detail.png |
Associated revisions
Updated table names, table indexes and uninstall procedure for tickets management plugin - refs #6715
Removed useless settings and updated English terms for tickets management plugin - refs #6715
Update filenames for tickets management plugin - refs #6715
Partial cleanup of the ticket plugin - refs #6715
Rename directory "s" to "src" - refs #6715
Code cleanup for ticket plugin - refs #6715
Code cleanup for ticket plugin (2) - refs #6715
Code cleanup for ticket plugin (3) - refs #6715
code Format - refs #6715
code Format - refs #6715
Code Format and change variable name- refs #6715
Clean and format the code - refs #6715
Changelog about removals with custom tabs - refs #6715
Format code - refs #6715
Rename folders - refs #6715
CRUD to tabs and add some default values - refs #6715
add new function api_get to get the entire setting row - refs #6715
Somes changes to show the custom tab - refs #6715
Move ticket plugin class - refs #6715
Responses - refs #6715
Javascript changes to add a ticket correctly and pass the email - refs #6715
Some performance improvements and change the priority abbreviation - refs #6715
Add crud to Extra attributes and Modify some comments - refs #6715
Some database changes and set some default values - refs #6715
Ticket Plugin - refs #6715
Translation - refs #6715
Disable satisfaction buttons when the session is admin - refs #6715
Correctly method documentation - refs #6715
change the parameter name to allow students to add tickets - refs #6715
Change icon import to export and avoid inline css - refs #6715
Avoid lang validation - refs #6715
Performance improvements - refs #6715
Delete Extra Setting functions, use the default one and set the translation - refs #6715
Rename database iid to id - refs #6715
Merged branch from FraGoTe - refs #6715
Modify wrong count row function - refs #6715
Update ticket plugin language vars - refs #6715
Minor - format code removing unused variables see #6715
Security fixes adding Database::escape_string see #6715
Minor - format code see #6715
Adding remove_XSS function see #6715
Minor format code see #6715
UX improvements - refs #6715
From html form to FormValidator and some JS improvements - refs #6715
from html form to FormValidator - refs #6715
Correct comments and spaces - refs #6715
Rename some variables - refs #6715
History
Updated by Yannick Warnier about 6 years ago
Updated by - % Done changed from 0 to 30
Kenny ya ha avanzado bastante (ya es casi funcional). Reflejo este avance con este cambio de porcentaje.
Updated by Yannick Warnier over 5 years ago
- Status changed from Assigned to New
- Assignee deleted (
Kenny Rodas)
Updated by Yannick Warnier over 5 years ago
- Status changed from New to Assigned
- Assignee set to Francis Gonzales
Updated by Yannick Warnier over 5 years ago
- Priority changed from High to Urgent
This one is becoming urgent. We need it closed, or at least with the database structure cleaned up, before we can release an alpha version.
Updated by Yannick Warnier over 5 years ago
Never forget to send a pull request or to indicate in the task where to pull your changes, just in case.
Updated by Yannick Warnier over 5 years ago
Also, you should create yourself a branch for that. It will be much cleaner when sending the pull request.
Updated by Francis Gonzales over 5 years ago
Updated by - % Done changed from 30 to 70
It is still not finished but I have sent my changes.
[[https://github.com/FraGoTe/chamilo-lms/commit/22d990a86ea0ae957421c4e120eb11b52cae6de4]]
Updated by Francis Gonzales over 5 years ago
- % Done changed from 70 to 80
https://github.com/FraGoTe/chamilo-lms/commits/6715
The code format was done, the tab CRUD too but I'm still testing how the plugin works.
Updated by Francis Gonzales over 5 years ago
- Status changed from Assigned to Needs testing
- Assignee changed from Francis Gonzales to Yannick Warnier
- % Done changed from 80 to 90
The plugin now is working.
I've added some new features:
1. Allow add tabs from plugins.
2. Allow add configurations to plugins.
To Do:
1. There is still some incomplete translations.
2. Improve the styles.
Updated by Francis Gonzales over 5 years ago
Change the parameter name to allow users add their owns tickets.
Add some translatios and improve some processes.
Updated by Francis Gonzales over 5 years ago
Change icon import to export and avoid inline css
Avoid lang validation
Performance improvements
Delete Extra Setting functions, use the default one and set the translation
Rename database iid to id
Updated by Yannick Warnier over 5 years ago
- Assignee changed from Yannick Warnier to Francis Gonzales
Francis, when connected as admin, it says "Debe seleccionar a un usuario" when I try to register a new ticket.
-> I forgot tu pull the PR first
Updated by Yannick Warnier over 5 years ago
- Assignee changed from Francis Gonzales to Julio Montoya
Julio, could you review the tickets integration one last time for me, please?
At this point, I just want you to click through and look for any weird thing and fix them if you find any. It doesn't have to be perfect. It just needs to work OK.
Updated by Julio Montoya over 5 years ago
Updated by 
The menu link does not work I have this URL:
http://192.168.1.54/plugin/ticket/src/myticket.php
instead of
http://192.168.1.54/chamilo19/plugin/ticket/src/myticket.php
(chamilo19 subfolder missing)
Updated by Julio Montoya over 5 years ago
- File Selection_001.png Selection_001.png added
No se está usando FormValidator lo cual es una pesadilla para manejar los estilos de los formularios incluyendo el manejo de fckeditor
Por supuesto que esto no pasará a Chamilo 10. (no existe fckeditor, formulario con estilos y divs hechos a mano).
Updated by Julio Montoya over 5 years ago
- File Selection_002.png Selection_002.png added
- File Selection_003.png Selection_003.png added
- File Selection_004.png Selection_004.png added
- File Selection_005.png Selection_005.png added
jajaja llené todo mi formulario y al querer enviar mi formulario me apareció un mensaje:
"Please select a user" ... entonces no encontré donde poner el usuario :s
Entonces hago click en "search user", y se me borra todo los campos!!
Lleno todos los campos y vuelvo a enviar y me dice otra vez "Please select a user"
Entonces le doy click a "+" y finalemente tengo la opción de hacerlo pero el boton sigue en "verde".
Updated by Julio Montoya over 5 years ago
El comentario de arriba son en realidad mejoras de UX, que no tocaré.
Updated by Julio Montoya over 5 years ago
- File Selection_006.png Selection_006.png added
Estilo no compatibles y fckeditor otra vez:
Updated by Julio Montoya over 5 years ago
- Assignee deleted (
Julio Montoya)
Acabo de enviar unos cambios para corregir el problema del menu, fckeditor y unas fallas de seguridad.
Updated by Francis Gonzales over 5 years ago
- File first first added
- File detail.png detail.png added
- Assignee changed from Francis Gonzales to Julio Montoya
Acabo de hacer una prueba poniendo chamilo19x como subcarpeta y con el commit de Julio ya se corrigió.
Y he hecho algunas modificaciones para mejorar la experiencia del usuario.
Julio puedes darle una segunda revisada?
Updated by Julio Montoya over 5 years ago
- Assignee deleted (
Julio Montoya)
Francis Gonzales wrote:
Acabo de hacer una prueba poniendo chamilo19x como subcarpeta y con el commit de Julio ya se corrigió.
Y he hecho algunas modificaciones para mejorar la experiencia del usuario.
Julio puedes darle una segunda revisada?
Supongo que te refieres a este PR? https://github.com/chamilo/chamilo-lms/pull/298/files
Updated by Francis Gonzales over 5 years ago
- Assignee set to Francis Gonzales
Julio Montoya wrote:
Francis Gonzales wrote:
Acabo de hacer una prueba poniendo chamilo19x como subcarpeta y con el commit de Julio ya se corrigió.
Y he hecho algunas modificaciones para mejorar la experiencia del usuario.
Julio puedes darle una segunda revisada?
Supongo que te refieres a este PR? https://github.com/chamilo/chamilo-lms/pull/298/files
Afirmative, voy a hacer cambios para usar FormValidator ...
Updated by Yannick Warnier over 5 years ago
- Status changed from Needs testing to Assigned
OK, esto debe ser la última mejora que le ponemos al plugin de tickets. No me parece que hayan contado todo su tiempo, ya que de lo visto ya vamos por lo menos 80h en esto (Francis!?), pero vayan haciéndolo cuando lo vean.
Los demás bugs que encontremos iran para la v10 (nuevas tareas) a menos que sean fallas de seguridad.
Acabo de publicar la beta 1. Espero poder cerrar todo y publicar la RC1 el próximo martes.
Updated by Francis Gonzales over 5 years ago
Ok, no hay problema. Ahora estoy cambiando algunos JS (que estan muy enredados) a Jquery y los forms a los FormValidators.
Updated by Francis Gonzales over 5 years ago
Acabo de enviar algunos cambios a Form Validator y de JS.
Updated by Yannick Warnier over 5 years ago
- Assignee set to Francis Gonzales
Francis, I reviewed your latest PR quickly. Could you go through and fix what I commented on please?
There are minor naming stuff.
Updated by Yannick Warnier over 5 years ago
- Status changed from Assigned to Feature implemented
- Assignee set to Francis Gonzales
- % Done changed from 90 to 100
First implementation considered complete now.
Minor - code styling for tickets management plugin - refs #6715