Project

General

Profile

Feature #6715

Integrate embedded support tickets management as a plugin

Added by Yannick Warnier about 6 years ago. Updated over 5 years ago.

Status:
Feature implemented
Priority:
Urgent
Category:
Administration
Target version:
Start date:
22/09/2013
Due date:
24/04/2014
% Done:

100%

Estimated time:
40.00 h
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

El objetivo de esta tarea es de integrar un sistema de tickets de soporte a Chamilo 1.9.8, por lo que se tendrá que hacer como un plugin en esta versión (ya que requiere de cambios de base de datos). Quizás será integrato luego en Chamilo 1.10 como una funcionalidad nativa.

Para realizar esta integración, Kenny ya tiene código existente que convertirá a un plugin, usando como base el plugin "bbb" que tiene todas las correctas maneras de implementar la clase "Plugin" disponible en chamilo/main/inc/lib/plugin.class.php

Para ello, Kenny contará con el apoyo de Yannick y Julio, ya que el código que tiena ahora:
  • no está en forma de plugin
  • declara nuevas tablas que posiblemente no respetan los estándares de denominación de Chamilo
  • usa variables y código que posiblemente no respetan nuestras Coding conventions
  • no usa variables de idiomas

Por lo tanto, se trata de una tarea relativamente grupal. Me gustaría tener el plugin listo para mostrar en el Chamilo Users Day de Madrid. Para ello, tendría que estar listo dentro de aproximadamente 2 semanas de aquí.

Kenny estará desarrollando la primera versión en su repositorio: https://github.com/kennyrodas/chamilo-lms


Files

Selection_001.png (29.2 KB) Selection_001.png Julio Montoya, 05/05/2014 13:59
Selection_002.png (38.2 KB) Selection_002.png Julio Montoya, 05/05/2014 14:14
Selection_003.png (32.9 KB) Selection_003.png Julio Montoya, 05/05/2014 14:14
Selection_004.png (57.4 KB) Selection_004.png Julio Montoya, 05/05/2014 14:14
Selection_005.png (38 KB) Selection_005.png Julio Montoya, 05/05/2014 14:14
Selection_006.png (61.9 KB) Selection_006.png Julio Montoya, 05/05/2014 14:16
first (100 KB) first Francis Gonzales, 08/05/2014 20:15
detail.png (62.7 KB) detail.png Francis Gonzales, 08/05/2014 20:15

Associated revisions

Revision 17681a74 (diff)
Added by Yannick Warnier almost 6 years ago

Minor - code styling for tickets management plugin - refs #6715

Revision 43fec048 (diff)
Added by Yannick Warnier almost 6 years ago

Updated table names, table indexes and uninstall procedure for tickets management plugin - refs #6715

Revision e49d860d (diff)
Added by Yannick Warnier almost 6 years ago

Removed useless settings and updated English terms for tickets management plugin - refs #6715

Revision 453b5c67 (diff)
Added by Yannick Warnier almost 6 years ago

Update filenames for tickets management plugin - refs #6715

Revision 33d8b2d0 (diff)
Added by Yannick Warnier over 5 years ago

Partial cleanup of the ticket plugin - refs #6715

Revision e6ac6258 (diff)
Added by Yannick Warnier over 5 years ago

Rename directory "s" to "src" - refs #6715

Revision d948cd80 (diff)
Added by Yannick Warnier over 5 years ago

Code cleanup for ticket plugin - refs #6715

Revision b75aabdd (diff)
Added by Yannick Warnier over 5 years ago

Code cleanup for ticket plugin (2) - refs #6715

Revision 42ea64d3 (diff)
Added by Yannick Warnier over 5 years ago

Code cleanup for ticket plugin (3) - refs #6715

Revision c5b408e5 (diff)
Added by Francis Gonzales over 5 years ago

code Format - refs #6715

Revision 6fdb5639 (diff)
Added by Francis Gonzales over 5 years ago

code Format - refs #6715

Revision 3f48c748 (diff)
Added by Francis Gonzales over 5 years ago

Code Format and change variable name- refs #6715

Revision 22d990a8 (diff)
Added by Francis Gonzales over 5 years ago

Clean and format the code - refs #6715

Revision 2c23cf4b (diff)
Added by Francis Gonzales over 5 years ago

Changelog about removals with custom tabs - refs #6715

Revision c0ba6cd5 (diff)
Added by Francis Gonzales over 5 years ago

Format code - refs #6715

Revision 3ac9766b (diff)
Added by Francis Gonzales over 5 years ago

Rename folders - refs #6715

Revision 8bb5b940 (diff)
Added by Francis Gonzales over 5 years ago

CRUD to tabs and add some default values - refs #6715

Revision ca2e92e7 (diff)
Added by Francis Gonzales over 5 years ago

add new function api_get to get the entire setting row - refs #6715

Revision edffe587 (diff)
Added by Francis Gonzales over 5 years ago

Somes changes to show the custom tab - refs #6715

Revision 753cc4f3 (diff)
Added by Francis Gonzales over 5 years ago

Move ticket plugin class - refs #6715

Revision cd4cf880 (diff)
Added by Francis Gonzales over 5 years ago

Responses - refs #6715

Revision 7f43ab6a (diff)
Added by Francis Gonzales over 5 years ago

Javascript changes to add a ticket correctly and pass the email - refs #6715

Revision b48f9bc0 (diff)
Added by Francis Gonzales over 5 years ago

Some performance improvements and change the priority abbreviation - refs #6715

Revision b335c1e6 (diff)
Added by Francis Gonzales over 5 years ago

Add crud to Extra attributes and Modify some comments - refs #6715

Revision 27fcdfb2 (diff)
Added by Francis Gonzales over 5 years ago

Some database changes and set some default values - refs #6715

Revision 6419d8b9 (diff)
Added by Francis Gonzales over 5 years ago

Ticket Plugin - refs #6715

Revision cdab0f4a (diff)
Added by Francis Gonzales over 5 years ago

Translation - refs #6715

Revision 0ba31d00 (diff)
Added by Francis Gonzales over 5 years ago

Disable satisfaction buttons when the session is admin - refs #6715

Revision b541a1df (diff)
Added by Francis Gonzales over 5 years ago

Correctly method documentation - refs #6715

Revision f228bbb9 (diff)
Added by Francis Gonzales over 5 years ago

change the parameter name to allow students to add tickets - refs #6715

Revision 61c5f2ef (diff)
Added by Francis Gonzales over 5 years ago

Change icon import to export and avoid inline css - refs #6715

Revision 2e5efc48 (diff)
Added by Francis Gonzales over 5 years ago

Avoid lang validation - refs #6715

Revision 58eccffd (diff)
Added by Francis Gonzales over 5 years ago

Performance improvements - refs #6715

Revision f06e82ca (diff)
Added by Francis Gonzales over 5 years ago

Delete Extra Setting functions, use the default one and set the translation - refs #6715

Revision 3f1da5d0 (diff)
Added by Francis Gonzales over 5 years ago

Rename database iid to id - refs #6715

Revision c216bd69
Added by Yannick Warnier over 5 years ago

Merged branch from FraGoTe - refs #6715

Revision 62750f00 (diff)
Added by Francis Gonzales over 5 years ago

Modify wrong count row function - refs #6715

Revision db22087d (diff)
Added by Yannick Warnier over 5 years ago

Update ticket plugin language vars - refs #6715

Revision e838cb05 (diff)
Added by Julio Montoya over 5 years ago

Minor - format code removing unused variables see #6715

Revision 314cb1dd (diff)
Added by Julio Montoya over 5 years ago

Security fixes adding Database::escape_string see #6715

Revision e151f6b7 (diff)
Added by Julio Montoya over 5 years ago

Minor - format code see #6715

Revision 0a263121 (diff)
Added by Julio Montoya over 5 years ago

Adding remove_XSS function see #6715

Revision ac73eea5 (diff)
Added by Julio Montoya over 5 years ago

Minor format code see #6715

Revision 7bb3d41a (diff)
Added by Francis Gonzales over 5 years ago

UX improvements - refs #6715

Revision f85aed20 (diff)
Added by Francis Gonzales over 5 years ago

From html form to FormValidator and some JS improvements - refs #6715

Revision 3e1c53d3 (diff)
Added by Francis Gonzales over 5 years ago

from html form to FormValidator - refs #6715

Revision 3f6495d0 (diff)
Added by Francis Gonzales over 5 years ago

Correct comments and spaces - refs #6715

Revision 46e1f02e (diff)
Added by Francis Gonzales over 5 years ago

Rename some variables - refs #6715

History

#1

Updated by Yannick Warnier about 6 years ago

  • % Done changed from 0 to 30

Kenny ya ha avanzado bastante (ya es casi funcional). Reflejo este avance con este cambio de porcentaje.

#2

Updated by Yannick Warnier over 5 years ago

  • Status changed from Assigned to New
  • Assignee deleted (Kenny Rodas)
#3

Updated by Yannick Warnier over 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Francis Gonzales
#4

Updated by Yannick Warnier over 5 years ago

  • Priority changed from High to Urgent

This one is becoming urgent. We need it closed, or at least with the database structure cleaned up, before we can release an alpha version.

#5

Updated by Yannick Warnier over 5 years ago

Never forget to send a pull request or to indicate in the task where to pull your changes, just in case.

#6

Updated by Yannick Warnier over 5 years ago

Also, you should create yourself a branch for that. It will be much cleaner when sending the pull request.

#7

Updated by Francis Gonzales over 5 years ago

  • % Done changed from 30 to 70
#8

Updated by Francis Gonzales over 5 years ago

  • % Done changed from 70 to 80

https://github.com/FraGoTe/chamilo-lms/commits/6715

The code format was done, the tab CRUD too but I'm still testing how the plugin works.

#9

Updated by Francis Gonzales over 5 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Francis Gonzales to Yannick Warnier
  • % Done changed from 80 to 90

The plugin now is working.

I've added some new features:

1. Allow add tabs from plugins.
2. Allow add configurations to plugins.

To Do:

1. There is still some incomplete translations.
2. Improve the styles.

#10

Updated by Yannick Warnier over 5 years ago

  • Due date changed from 06/10/2013 to 24/04/2014
#11

Updated by Francis Gonzales over 5 years ago

Change the parameter name to allow users add their owns tickets.

Add some translatios and improve some processes.

#12

Updated by Francis Gonzales over 5 years ago

Change icon import to export and avoid inline css
Avoid lang validation
Performance improvements
Delete Extra Setting functions, use the default one and set the translation
Rename database iid to id

#13

Updated by Yannick Warnier over 5 years ago

  • Assignee changed from Yannick Warnier to Francis Gonzales

Francis, when connected as admin, it says "Debe seleccionar a un usuario" when I try to register a new ticket.
-> I forgot tu pull the PR first

#14

Updated by Yannick Warnier over 5 years ago

  • Assignee changed from Francis Gonzales to Julio Montoya

Julio, could you review the tickets integration one last time for me, please?
At this point, I just want you to click through and look for any weird thing and fix them if you find any. It doesn't have to be perfect. It just needs to work OK.

#15

Updated by Julio Montoya over 5 years ago

The menu link does not work I have this URL:

http://192.168.1.54/plugin/ticket/src/myticket.php

instead of

http://192.168.1.54/chamilo19/plugin/ticket/src/myticket.php

(chamilo19 subfolder missing)

#16

Updated by Julio Montoya over 5 years ago

No se está usando FormValidator lo cual es una pesadilla para manejar los estilos de los formularios incluyendo el manejo de fckeditor

Por supuesto que esto no pasará a Chamilo 10. (no existe fckeditor, formulario con estilos y divs hechos a mano).

#17

Updated by Julio Montoya over 5 years ago

jajaja llené todo mi formulario y al querer enviar mi formulario me apareció un mensaje:

"Please select a user" ... entonces no encontré donde poner el usuario :s

Entonces hago click en "search user", y se me borra todo los campos!!

Lleno todos los campos y vuelvo a enviar y me dice otra vez "Please select a user"

Entonces le doy click a "+" y finalemente tengo la opción de hacerlo pero el boton sigue en "verde".

#18

Updated by Julio Montoya over 5 years ago

El comentario de arriba son en realidad mejoras de UX, que no tocaré.

#19

Updated by Julio Montoya over 5 years ago

Estilo no compatibles y fckeditor otra vez:

#20

Updated by Julio Montoya over 5 years ago

Hay varios queries que no estan filtrados.

#21

Updated by Julio Montoya over 5 years ago

  • Assignee deleted (Julio Montoya)

Acabo de enviar unos cambios para corregir el problema del menu, fckeditor y unas fallas de seguridad.

#22

Updated by Francis Gonzales over 5 years ago

  • Assignee set to Francis Gonzales
#23

Updated by Francis Gonzales over 5 years ago

Acabo de hacer una prueba poniendo chamilo19x como subcarpeta y con el commit de Julio ya se corrigió.

Y he hecho algunas modificaciones para mejorar la experiencia del usuario.

Julio puedes darle una segunda revisada?

#24

Updated by Julio Montoya over 5 years ago

  • Assignee deleted (Julio Montoya)

Francis Gonzales wrote:

Acabo de hacer una prueba poniendo chamilo19x como subcarpeta y con el commit de Julio ya se corrigió.

Y he hecho algunas modificaciones para mejorar la experiencia del usuario.

Julio puedes darle una segunda revisada?

Supongo que te refieres a este PR? https://github.com/chamilo/chamilo-lms/pull/298/files

#25

Updated by Francis Gonzales over 5 years ago

  • Assignee set to Francis Gonzales

Julio Montoya wrote:

Francis Gonzales wrote:

Acabo de hacer una prueba poniendo chamilo19x como subcarpeta y con el commit de Julio ya se corrigió.

Y he hecho algunas modificaciones para mejorar la experiencia del usuario.

Julio puedes darle una segunda revisada?

Supongo que te refieres a este PR? https://github.com/chamilo/chamilo-lms/pull/298/files

Afirmative, voy a hacer cambios para usar FormValidator ...

#26

Updated by Yannick Warnier over 5 years ago

  • Status changed from Needs testing to Assigned

OK, esto debe ser la última mejora que le ponemos al plugin de tickets. No me parece que hayan contado todo su tiempo, ya que de lo visto ya vamos por lo menos 80h en esto (Francis!?), pero vayan haciéndolo cuando lo vean.
Los demás bugs que encontremos iran para la v10 (nuevas tareas) a menos que sean fallas de seguridad.

Acabo de publicar la beta 1. Espero poder cerrar todo y publicar la RC1 el próximo martes.

#27

Updated by Francis Gonzales over 5 years ago

Ok, no hay problema. Ahora estoy cambiando algunos JS (que estan muy enredados) a Jquery y los forms a los FormValidators.

#28

Updated by Francis Gonzales over 5 years ago

Acabo de enviar algunos cambios a Form Validator y de JS.

#29

Updated by Francis Gonzales over 5 years ago

  • Assignee deleted (Francis Gonzales)
#30

Updated by Yannick Warnier over 5 years ago

  • Assignee set to Francis Gonzales

Francis, I reviewed your latest PR quickly. Could you go through and fix what I commented on please?
There are minor naming stuff.

#31

Updated by Francis Gonzales over 5 years ago

Sure, I just sent some changes.

#32

Updated by Francis Gonzales over 5 years ago

  • Assignee deleted (Francis Gonzales)
#33

Updated by Yannick Warnier over 5 years ago

  • Status changed from Assigned to Feature implemented
  • Assignee set to Francis Gonzales
  • % Done changed from 90 to 100

First implementation considered complete now.

Also available in: Atom PDF