Project

General

Profile

Bug #6623

Video view doesn't work as teacher in documents

Added by Yannick Warnier about 7 years ago. Updated over 6 years ago.

Status:
Bug resolved
Priority:
High
Assignee:
Daniel Barreto
Category:
Documents
Target version:
Start date:
24/08/2013
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

For some obscure reason, when embedding a YouTube video (this might be true for other video providers, I'm not sure) in a document, the teacher can view the video inside the FCKEditor, but when saving the document, the video does not appear (although the area seems to be in Flash).
The student can see the video perfectly, but the teacher just sees a blank page.

This is very annoying in terms of page review, and I think it should really be a priority to fix it in 1.9.8, because most teachers just think it doesn't work and end up removing their videos from their courses.

It's probably very tricky to debug, though...

Associated revisions

Revision 4b754c21 (diff)
Added by Daniel Barreto almost 7 years ago

Fixing bug adding a <p></br><p> to html body of empty template -refs #6623

Revision c817df1e
Added by Julio Montoya almost 7 years ago

Merge pull request #177 from danbarretodev/6623

Fixing bug -refs #6623

History

#1

Updated by Hubert Borderiou about 7 years ago

I cannot reproduce the bug
Test on stable, see screencast
(teacher don't see the vidéo while inside the fckeditor iframe, they see the skelleton of the video area)

see http://screencast.com/t/unXTF8wRkHN

#2

Updated by Hubert Borderiou about 7 years ago

I've got a bug if I just add a youtube vidéo in the doc, and nothing else.
In this case, nor teacher, nor student see the video.

If there is some text before or after the vidéo, it works fine.

(other issue, I cannot view the video with Chrome Version 29.0.1547.57 m, even teacher or student)

#3

Updated by Yannick Warnier about 7 years ago

In Firefox 23 + Linux + Chamilo 1.9.6, with or without text, I can't see the video as a teacher.
This is going to be fun to debug... :)

#4

Updated by Hubert Borderiou about 7 years ago

I've got Firefox 17 on Windows 7
I'm going to test on a linux and give you my report.
Don't you have any workaround ?

#5

Updated by Hubert Borderiou about 7 years ago

  • Status changed from Assigned to Needs testing

Test on Ubuntu with Firefox 23, with Chamilo 1.9.4 and Chamilo 1.9.8, I cannot reproduce the bug
Did I do the right test (see screencast) ?
???

#6

Updated by Kevin LEVRON almost 7 years ago

Hello

I have a bug which may be related with this one :
Actually, on a https install, it is not possible to display youtube videos since most browsers disable insecure content loading. Modifying document and replacing http with https does not work, update is not done (no error messages).

Tested on 1.9.6 and on stable.chamilo.org

#7

Updated by Kevin LEVRON almost 7 years ago

Well, it is possible to replace http with https (in fckeditor source mode) but don't forget to exit source mode before submitting form.

Whatever, the youtube fck button should generate "//" links instead of "http://".

#8

Updated by Yannick Warnier almost 7 years ago

  • Status changed from Needs testing to Assigned
  • Assignee changed from Hubert Borderiou to Daniel Barreto
  • % Done changed from 0 to 20

Agreed on changing the YouTube link from http to //. Assigning to Daniel (newcomer developer).

#9

Updated by Daniel Barreto almost 7 years ago

Got the bug when added a youtube video before anything else in FCKEditor, checked the html from documents created and the video element is located inside head, not body, also this happens when a document is created, when edited it whit a new youtube video was ok.

The code generated for the video is a flash and no an iframe, then the user must have installed the flash plugin to view it

Tested in Firefox 26 + Ubuntu 13.10

#10

Updated by Daniel Barreto almost 7 years ago

More info about the bug:
Same bug for other items like images when the document doesn't have anything inside body as a <p> for example and the user click on this empty document before add the image, youtube video.
When creating a document and you click inside a empty document, then the bug will occurs, but when editing a document (empty document) it have a <p> and all works fine
I'll check it more, cause the template "Empty" also generate this bug

#11

Updated by Daniel Barreto almost 7 years ago

  • Status changed from Assigned to Needs testing
  • % Done changed from 20 to 60

Done adding <p> and <br> to html body of empty template, PR in
https://github.com/chamilo/chamilo-lms/pull/177

#12

Updated by Daniel Barreto almost 7 years ago

  • Assignee deleted (Daniel Barreto)
#13

Updated by Yannick Warnier over 6 years ago

  • Subject changed from Video view doesn't work as teacher to Video view doesn't work as teacher in documents
  • Status changed from Needs testing to Bug resolved
  • Assignee set to Daniel Barreto
  • % Done changed from 60 to 100

Checked and approved.

Also available in: Atom PDF