Project

General

Profile

Feature #6579

Load favicon from CSS dir

Added by Yannick Warnier about 6 years ago. Updated almost 4 years ago.

Status:
Feature implemented
Priority:
Low
Category:
Styles, Layout & Accessibility
Target version:
Start date:
18/08/2013
Due date:
% Done:

100%

Estimated time:
1.00 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

The favicon.ico should be CSS-dependent to ease the change.
Technically, this just means changing the favicon.ico tag at the beginning of the HTML page:

<link rel="shortcut icon" href="https://my.chamilo.net/favicon.ico" type="image/x-icon" />

to something like

<link rel="shortcut icon" href="https://my.chamilo.net/main/css/chamilo/images/favicon.ico" type="image/x-icon" />

(after checking that this file exists, of course, otherwise we should stick to the base style).

The only possible discussion about this is whether it should rather depend of the multi-url directory instead of the CSS, but given you can change the CSS by multi-URL, there's no real need to consider it.

Associated revisions

Revision 431576b2 (diff)
Added by José Loguercio about 4 years ago

Load favicon from CSS dir - Refs #6579

Revision c603b310
Added by Yannick Warnier about 4 years ago

Merge pull request #833 from jloguercio/6579

Load favicon from CSS dir - Refs #6579

History

#1

Updated by Yannick Warnier about 6 years ago

  • Description updated (diff)
#2

Updated by Yannick Warnier about 6 years ago

  • Description updated (diff)
#3

Updated by Yannick Warnier about 4 years ago

  • Status changed from New to Assigned
  • Assignee set to José Loguercio
#4

Updated by José Loguercio about 4 years ago

  • % Done changed from 0 to 80

favicon dir changed
pull request sent

#5

Updated by José Loguercio about 4 years ago

Updated ! , added the verify to the default icon and themed icon

#6

Updated by José Loguercio almost 4 years ago

  • Status changed from Assigned to Feature implemented
  • Assignee changed from José Loguercio to Yannick Warnier
  • % Done changed from 80 to 90
#7

Updated by Yannick Warnier almost 4 years ago

  • Assignee changed from Yannick Warnier to José Loguercio
  • Target version changed from 2.0 to 1.10.0
  • % Done changed from 90 to 100

Changing from 2.0 to 1.10.0 as it was implemented there

Also available in: Atom PDF