Project

General

Profile

Bug #653

Modify a grade with decimal on the gradebook saves the integer part.

Added by Carlos Brolo over 9 years ago. Updated almost 9 years ago.

Status:
Feature implemented
Priority:
Normal
Category:
-
Target version:
Start date:
03/03/2010
Due date:
% Done:

100%

Estimated time:
0.20 h
Spent time:
Complexity:
Piece of cake
SCRUM pts - complexity:
1

Description

Sorry my english...
If you give a grade with decimal on "*gradebook_add_result.php*" the grade is saved with the decimal part. (double).

If you attempt to change the "allready in database" grades with the "modify button" -> gradebook_view_result.php file
you get to save only the integer part...

Sollution:
You have to change code line 149 of the file: gradebook_view_result.php
and modify the (int) to (double)

After the change you may modify grades and save the decimal part too.

History

#1

Updated by Carlos Brolo over 9 years ago

Sorry my english...
If you give a grade with decimal on "*gradebook_add_result.php*" the grade is saved with the decimal part. (double).

If you attempt to change the "allready in database" grades with the "modify button" -> gradebook_view_result.php file
you get to save only the integer part...

Sollution:
You have to change code line 149 of the file: gradebook_view_result.php
and modify the (int) to (double)

After the change you may modify grades and save the decimal part too.

#2

Updated by Yannick Warnier over 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Christian Alberto Fasanando Flores
  • Target version set to 1.8.7 beta
  • SCRUM pts - complexity changed from ? to 1
#3

Updated by Anonymous over 9 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Christian Alberto Fasanando Flores to Anonymous
#4

Updated by Anonymous over 9 years ago

  • Assignee changed from Anonymous to Carlos Vargas

Reassigning to you, Carlos, for test and feedback...

#5

Updated by Carlos Brolo over 9 years ago

  • % Done changed from 50 to 90

Works!!!

#6

Updated by Anonymous over 9 years ago

Given that another one of our clients wanted to have the possibility to select the number of decimals of the score, I had to do some more changes, which are available in this commit: http://code.google.com/p/chamilo/source/detail?r=f97f8aa284d0b5c390447a9b046d599ebd33291b&repo=classic

Now you can select the number of decimals you want in the administration panel.

Yannick > The name of the language variable that needs to be set is GradebookScoringSystemRedirect, in the gradebook package. I added it in translate.chamilo.org, but you told me to let you translate it...

Carlos V > If you can test the new features and close the task if it's ok...

#7

Updated by Yannick Warnier over 9 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Carlos Vargas to Anonymous

Given an English translation.

In the page where the text is shown, please use the Display::display_normal_message() method instead of hard-coding the normal-message <div>. Give a "false" second attribute to ensure there is no HTML filtering.

When finished, you can pass the task to Carlos again and if he confirms, the task can be "Resolved"

Good job!

#8

Updated by Anonymous over 9 years ago

  • Assignee changed from Anonymous to Carlos Vargas
#9

Updated by Carlos Brolo over 9 years ago

Testing...

#10

Updated by Yannick Warnier over 9 years ago

Ah well, I didn't mean this Carlos :-D

#11

Updated by Carlos Vargas over 9 years ago

  • File Pantallazo-Parámetros_de_configuración_de_Chamilo_-_My_campus_-_Mozilla_Firefox.png added
  • File Pantallazo-Parámetros_de_configuración_de_Chamilo_-_My_campus_-_Mozilla_Firefox-1.png added
#12

Updated by Carlos Vargas over 9 years ago

  • File deleted (Pantallazo-Parámetros_de_configuración_de_Chamilo_-_My_campus_-_Mozilla_Firefox.png)
#13

Updated by Carlos Vargas over 9 years ago

  • File deleted (Pantallazo-Parámetros_de_configuración_de_Chamilo_-_My_campus_-_Mozilla_Firefox-1.png)
#14

Updated by Yannick Warnier over 9 years ago

  • Target version changed from 1.8.7 beta to 1.8.7 RC1
#15

Updated by Julio Montoya over 9 years ago

  • Assignee changed from Carlos Vargas to Julio Montoya
  • Target version changed from 1.8.7 RC1 to 1.8.7.1
#16

Updated by Yannick Warnier over 9 years ago

  • Target version changed from 1.8.7.1 to 1.8.8 stable
#17

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)
  • Target version changed from 1.8.8 stable to 1.8.8 alpha
  • Estimated time changed from 0.00 h to 0.20 h
  • Complexity changed from Normal to Piece of cake

To be tested and approved by someone...

#18

Updated by Christian Alberto Fasanando Flores almost 9 years ago

  • Assignee set to Christian Alberto Fasanando Flores
#19

Updated by Christian Alberto Fasanando Flores almost 9 years ago

tested and approved

#20

Updated by Christian Alberto Fasanando Flores almost 9 years ago

  • Status changed from Needs more info to Feature implemented
  • % Done changed from 90 to 100

Also available in: Atom PDF