Project

General

Profile

Bug #6526

double translation in course group form class

Added by Anonymous about 7 years ago. Updated about 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Start date:
08/08/2013
Due date:
% Done:

0%

Estimated time:
Complexity:
Normal

Description

in application/weblcms/tool/course_group/php/lib/form/course_group_form.class.php

double (nested) translations:
method `build_header ($header_title)` translates the $header_title, using the common/libraries resource file. However, other methods calling this build_header method already translated the title (using the local resource file). First (and correct) translations:
in add_top_fields() on line 89
in build_creation_form() on lines 994 and 998

This seems to be intentional and for the time being harmless, but might lead to issues later on: if ever the translated string is itself a key in a common/libraries resource i18n file (especially the english version), the value will get retranslated into a possibly different string.

Doubly translated strings are marked with [CDA] tags in the screenshot.


Files

History

#1

Updated by Jens Vanderheyden about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Anonymous
#2

Updated by Anonymous about 7 years ago

resolved in file application/weblcms/tool/course_group/php/lib/form/course_group_form.class.php
removed translation from line 106, in build_header, as every not every $header in the call to the build_header method needs translation: e.g. build_basic_editing_form on line 630 builds a header with the group name (untranslated) and then with some other fields like title, description, etc. (translated). Moreover, the build_header method looks for translations in the common\libraries context, whereas the calling methods look in the default conext application\weblcms\tool\course_group, which seems to me to be more correct.

#3

Updated by Anonymous about 7 years ago

  • Status changed from Assigned to Bug resolved
#4

Updated by Anonymous about 7 years ago

  • Target version set to LCMS 4 Beta

Also available in: Atom PDF