Project

General

Profile

Bug #6222

Teachers without admin right can't register trainees in a session

Added by Eric Petitdemange over 6 years ago. Updated about 4 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
Administration
Target version:
Start date:
14/06/2013
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,

try to give a mx of info... here is the situation.
If I don't want trainer having admin rigts (which should be :)), they can create courses, LPs... BUT as they don't have admin tab they can't create or register trainees into sessions.

To register trainees, they have to go through "My Courses" tab, but there is nothing mentioning sessions over here


Files

users.png (47.2 KB) users.png Yoselyn Castillo, 10/04/2014 18:47
session_list.png (53.3 KB) session_list.png Yoselyn Castillo, 10/04/2014 18:47

Associated revisions

Revision 8135a405 (diff)
Added by Yoselyn Castillo almost 6 years ago

Inscribing users in sessions -refs #6222

Revision 5a7a1671 (diff)
Added by Yoselyn Castillo over 5 years ago

Adding access to resume_session file for teachers without admin rights -refs #6222

Revision b749fdc0 (diff)
Added by Yoselyn Castillo over 5 years ago

Fixing coding conventions -refs #6222

Revision 4b3fcdd4 (diff)
Added by Yoselyn Castillo over 5 years ago

Fixing coding conventions -refs #6222

Revision fd2155bf (diff)
Added by Yoselyn Castillo over 5 years ago

Fixing coding conventions -refs #6222

Revision 7c3455c0 (diff)
Added by Yoselyn Castillo over 5 years ago

adding configuration setting for inscribing users to session -refs #6222

Revision 092e4f63 (diff)
Added by Yoselyn Castillo over 5 years ago

Adding configuration setting verification -refs #6222

History

#1

Updated by Yannick Warnier about 6 years ago

  • Category set to Administration
  • Target version set to 1.9.8

To be checked for 1.9.8

#2

Updated by Yannick Warnier about 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Yoselyn Castillo
#3

Updated by Yoselyn Castillo about 6 years ago

checking...

#4

Updated by Yoselyn Castillo almost 6 years ago

  • % Done changed from 0 to 70

This requires to be carefully tested when uploaded
The commit was sent to:
https://github.com/chamilo/chamilo-lms/pull/130

#5

Updated by Yannick Warnier almost 6 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Yoselyn Castillo to Julio Montoya
#6

Updated by Eric Petitdemange almost 6 years ago

Hi guys, I'm not sure reading well : nothing mentioning session out of here ? This is the subject of the issue:
1.9.6 featured - trainer (teacher) without admin right can't register trainees in a sessions

This is the point, assign a teacher as coah of a session and He should be able to register trainees inside it, the whole point is that it seems not working.

Hope having this feature working..
See you soon :)

#7

Updated by Yannick Warnier almost 6 years ago

Hi Eric,

The patch submitted by Yoselyn includes fixes to sessions. It does not say so in our conversation here, but developers read in commits ;-)

I'm assigning to Julio for testing because I want him to check Yoselyn's code quality before merging it into Chamilo, and while he's at it, he will check if it works now, and then leave it to you (probably, unless it's very clearly fixed) for final review on stable.chamilo.org.

As always, these are all patches contributed by BeezNest and we do that when we can, so it might take some time to get fixed, and might even get moved to 1.10 if it is too long to fix, so no use getting impatient, it's rather counter-productive

#8

Updated by Eric Petitdemange almost 6 years ago

Hello Yanick,
Thanks for your answer...
However I didn't intend to sound impatient or anything eelse like that...
I just wanted to ensure we are all going the same direction.

I know it's not really easy to figure out what people are experiencing, as most of the time you are not in front the same system.

The major issues I report are based on sessions as it is the way I use mostly the platform here. I occured that some feature are experiencing different behaior depending on the way you use them (with or without sessions).

I just wanted to get clear that I tested only under session and this was where the bug is only visible.

Please accept my apologies if I left a bad feeling to you guys.

#9

Updated by Yannick Warnier almost 6 years ago

Hi Eric,

We, developers, are a very sensible kind, so using smilies from time to time and reformulating a bit really helps.
Apart from that we're cool! :-)

#10

Updated by Yannick Warnier over 5 years ago

  • Subject changed from 1.9.6 featured - trainer (teacher) without admin right can't register trainees in a sessions to Teacher without admin right can't register trainees in a sessions
  • Assignee deleted (Julio Montoya)
#11

Updated by Yannick Warnier over 5 years ago

  • Subject changed from Teacher without admin right can't register trainees in a sessions to Teachers without admin right can't register trainees in a session
  • Assignee set to Julio Montoya
#12

Updated by Yannick Warnier over 5 years ago

  • Assignee changed from Julio Montoya to Yoselyn Castillo
  • % Done changed from 70 to 60

I tested and put several comments on github. Assigning to Yoselyn for review.

#13

Updated by Yannick Warnier over 5 years ago

This task will be moved to 1.10 if we don't get further progress very soon.

#14

Updated by Yoselyn Castillo over 5 years ago

checking this..

#15

Updated by Yoselyn Castillo over 5 years ago

Fixed comments, in https://github.com/chamilo/chamilo-lms/pull/130
Way of try it:
Replace those files uploaded in pull request
Create a session with a teacher(without admin right) as coach.
Enter as that teacher
Enter the course session
Go to users tool
Click on the new "course sessions" button
Register users in session as desired.

#16

Updated by Yannick Warnier over 5 years ago

  • Status changed from Needs testing to Assigned

When I follow this procedure, I get an empty table when I click on the new "Course sessions" table. What should I see there?

#17

Updated by Yoselyn Castillo over 5 years ago

Which table are you getting?
Enter a course into a session if you are the session coach
Enter users tool into that course this is the result.

click "course sessions" button in top bar.
This is the result

Later you can continue inscribing users to your sessions.

#18

Updated by Eric Petitdemange over 5 years ago

Hi Yoselyn,

It is nearly it :)
I have an account login : e and password : e
This account is teacher without admin rights..

You can register a student if He already exist.. A teacher in a course (not in session) can create a student, I think the platforme should behave the same in sessions.

The issue is 80% resolved for me, and this is really good :)
Now just a way to add (create/ register) a new student in the platform and the issue will be gone.

Again, thanks for the job....

#19

Updated by Yannick Warnier over 5 years ago

  • Target version changed from 1.9.8 to 2.0

Yoselyn, you should try to connect as a session coach that is not an administrator. You will see that the sessions table remain empty.

Seeing it at work, in general, I'm against this feature "as is". It should only work if enabled through a configuration option or something like that.
The only alternative is to allow them to register students only in their course inside the session, but that implies a lot of additional checks to ensure a user is not registered twice in the same session if added to 2 different courses by two different teachers inside the same session.

I'm moving this task to 1.10, because it seems to me like it's not going to get to any conclusion soon (I'm not so sure about the 80% :-p)

#20

Updated by Eric Petitdemange over 5 years ago

Hi Yannick,

I agree with you, moving this feature...
It should be great if somewhere an entry says that teacher can't create but just assign stuident to session, therefore it would become a feature request rather than a "bug"....

creating the student is the "missing 20%" he he he...
Thanks very much for the time spent.
see you soon guys :)

#21

Updated by Yoselyn Castillo over 5 years ago

Yannick Warnier wrote:

Yoselyn, you should try to connect as a session coach that is not an administrator. You will see that the sessions table remain empty.

Seeing it at work, in general, I'm against this feature "as is". It should only work if enabled through a configuration option or something like that.
The only alternative is to allow them to register students only in their course inside the session, but that implies a lot of additional checks to ensure a user is not registered twice in the same session if added to 2 different courses by two different teachers inside the same session.

I'm moving this task to 1.10, because it seems to me like it's not going to get to any conclusion soon (I'm not so sure about the 80% :-p

I have tested with a session coach which has not administration rights and it shows his sessions correctly, That was the caught picture. Anyway, if this feature will not be applied now, coding conventions fixed were sent to
https://github.com/chamilo/chamilo-lms/pull/130

#22

Updated by Yannick Warnier over 5 years ago

Yoselyn, to avoid abandonning this feature completely for 1.9.8, I would need you to do the following:
  • add a setting in main/install/configuration.conf.dist.php:
    // Allow course tutors in sessions to add existing students to their session
    // $_configuration['allow_tutors_to_assign_students_to_session'] = 'false'; 
    
    (this way it will be created as part of any new Chamilo installation - but you can add it manually in your configuration.conf.php if needed)
  • in your current pull request, add the new buttons and features only "if (api_get_setting('allow_tutors_to_assign_students_to_session') == 'true')) " (I believe api_get_setting() checks the $_configuration array as well, but if that is not the case, use global $_configuration and use the $_configuration['allow_tutors_to_assign_students_to_session'] directly).

I think the last bit Eric asks for (creating the student) should be another task, if you don't mind, Eric (please register a new feature request for 1.10), so then we could close this task here (and have it completed for 1.9.8).

#23

Updated by Yoselyn Castillo over 5 years ago

Completely agree with you Yannick. I will include this requirements now

#24

Updated by Yoselyn Castillo over 5 years ago

Done! configuration setting was added

#25

Updated by Eric Petitdemange over 5 years ago

OK I do agree to close this case and I open a new one fo 1.10 to create student :)
Thanks guys!!!!

#26

Updated by Yannick Warnier about 4 years ago

  • Status changed from Assigned to Bug resolved
  • Target version changed from 2.0 to 1.10.0
  • % Done changed from 60 to 100

Closing as suggested

Also available in: Atom PDF