Project

General

Profile

Bug #6049

Missing glyphicons in bootstrap.css

Added by Yannick Warnier over 6 years ago. Updated over 6 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
Styles, Layout & Accessibility
Target version:
Start date:
20/03/2013
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

This is generating a lot of errors in our logs.

See https://github.com/twitter/bootstrap/issues/6287 for a source.

These should be put (I think) at the base of main/css/

Julio (M), do you know anything about why these files wouldn't be there?

Associated revisions

Revision 96a158c2 (diff)
Added by Yannick Warnier over 6 years ago

Removed all references to Glyphicons from Bootstrap CSS for obtrusive licensing terms - refs #6049

History

#1

Updated by Julio Montoya over 6 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

I remove it because you need to add a glyphicons attribution. Something like:

"Glyphicons Free licensed under CC BY 3.0." in the footer.

But I checked again and as announced here:

http://glyphicons.com/glyphicons-licenses/

we can just added it in the documentation page, not sure about that...

#2

Updated by Hubert Borderiou over 6 years ago

We should put it in the documentation page, and somewhere reachable from the web site.
May be just a link somewhere opening a popup with the link.
(http://www.vistaico.com/ fot AntiPlagiat icon ?)

#3

Updated by Yannick Warnier over 6 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

The right place to put this is documentation/credits.html. At the very end. It's not like most of the value of our software comes from their icons... It doesn't have to be first (but it's always publicly available on any chamilo site).

#4

Updated by Yannick Warnier over 6 years ago

If possible, indicate the exact source and author for every image source.

#5

Updated by Julio Montoya over 6 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

We have to put the link in the footer is mandatory apparently:

http://glyphicons.com/glyphicons-licenses/

GLYPHICONS FREE
are released under the Creative Commons Attribution 3.0 Unported (CC BY 3.0). The GLYPHICONS FREE can be used both commercially and for personal use, but you must always add a link to glyphicons.com in a prominent place (e.g. the footer of a website), include the CC-BY license and the reference to glyphicons.com on every page using GLYPHICONS.

This is the license:

http://creativecommons.org/licenses/by/3.0/deed.en

#6

Updated by Roberto Gonzalez over 6 years ago

Indeed the glyphicons images have been removed and bootstrap.css doesn't reference any of them any longer, so the task can be closed, I believe.

#7

Updated by Yannick Warnier over 6 years ago

  • Status changed from Needs more info to Bug resolved
  • % Done changed from 0 to 100

OK, thanks for the investigation. I have completely removed all references to glyph in all bootstrap.css.

Also available in: Atom PDF