Project

General

Profile

Bug #6033

Flash animations truncated

Added by Eric Petitdemange almost 7 years ago. Updated almost 6 years ago.

Status:
Bug resolved
Priority:
High
Category:
Learning paths / Lecciones
Target version:
Start date:
14/03/2013
Due date:
24/04/2014
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,

Flash animation are truncated.
A forum user first gave a solution, but it doesn't work with all web browsers. Topic:http://www.chamilo.org/phpBB3/viewtopic.php?f=14&t=4197

I put his working solution first and the one that doesn't work 100% next...

Working solution:
la partie cachée en bas de page vient de l'ajout du bandeau supérieur (fil d'Ariane) ajouté dans la version 1.9.4.
On peut aussi cacher ce bandeau en modifiant le fichier "base.css" vers la ligne 3980 :

Remplacer :

Code: Select all
#learning_path_breadcrumb_zone {
}

Par :

Code: Select all
#learning_path_breadcrumb_zone {
display: none;
}

Voici une solution temporaire avant suppression du problème car la modification que j'ai proposé précédemment ne fonctionne pas correctement dans tous les navigateurs.

The initial solution was :

Modification de la ligne 427 du fichier main/newscorm/lp_view.php : Remplacer

Code: Select all
echo '<iframe id="content_id" name="content_name" src="'.$src.'" border="0" frameborder="0" style="display: block; width:100%;height:'.$height.'"></iframe>';

par

Code: Select all
echo '<table border="0" width="100%" height="100%"><tbody><tr><td><iframe id="content_id2" name="content_name" src="'.$src.'" border="0" frameborder="0" style="display: block; width:100%;height:'.$height.'"></iframe></td></tr></tbody></table>';

Modifier le fichier main/css/base.css en ajoutant les lignes suivantes (par exemple à la fin) :

Code: Select all
#content_id2 {
padding-bottom: 34px;
}

Maintenant l'animation flash est complètement visible et exploitable (sur Mac OS X mais pas sous Windows ?!). Reste encore le problème lorsque je fais rentrer le volet de gauche, la partie inférieure (sous les trois boutons) devient inaccessible. La solution serait de rendre ce bandeau de commande déplaçable (comme sur la version 1.8.8 de mémoire !). A voir pour la suite. Voilà, si ça peut aide quelqu'un !


Files

truncated1.jpg (17.2 KB) truncated1.jpg Eric Petitdemange, 05/12/2013 14:54
truncated2.jpg (11.1 KB) truncated2.jpg Eric Petitdemange, 05/12/2013 14:54

Associated revisions

Revision a582cd9c (diff)
Added by Daniel Barreto almost 6 years ago

Fix bug LP height of content_id -refs #6033

Revision b1344084 (diff)
Added by Daniel Barreto almost 6 years ago

Update lp view to consider control bar view refs #6033 #7077

Revision 512633e6 (diff)
Added by Daniel Barreto almost 6 years ago

Update lp view to resize right when return from control view refs #6033 #7077

Revision 81c2ec26
Added by Yannick Warnier almost 6 years ago

Merge pull request #257 from danbarretodev/6033

Fix bug -refs #6033

Revision 3e5d6f80 (diff)
Added by Daniel Barreto almost 6 years ago

Update UpdateContentHeight() to use JQuery and fix div sizes
Minor: update variables names from french to english language to make it more legible -refs #7077 #6033

Revision bb6b3328
Added by Yannick Warnier over 5 years ago

Merge pull request #284 from danbarretodev/6033

Fix bug -refs #7077 refs #6033

History

#1

Updated by Yannick Warnier almost 7 years ago

  • Category set to Learning paths / Lecciones
  • Status changed from New to Assigned
  • Assignee set to Yoselyn Castillo
  • Target version set to 1.9.6
#2

Updated by Yoselyn Castillo almost 7 years ago

I am trying it. Later i'll give you my feedback

#3

Updated by Yoselyn Castillo almost 7 years ago

  • Status changed from Assigned to New
  • Assignee deleted (Yoselyn Castillo)

Sorry, I have problem with my flash plugin, so i can't well reproduce this issue for the moment

#4

Updated by Yannick Warnier almost 7 years ago

  • Status changed from New to Needs testing
  • Assignee set to Cesar Perales
#5

Updated by Yannick Warnier almost 7 years ago

  • Assignee deleted (Cesar Perales)
  • Target version changed from 1.9.6 to 1.9.8
#6

Updated by Yannick Warnier almost 7 years ago

  • Status changed from Needs testing to New
#7

Updated by Yannick Warnier about 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
  • Priority changed from Normal to High

Julio, please apply patch suggested by user.

#8

Updated by Julio Montoya about 6 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

I don't agree with that change. Changing the id of the frame to "content_id2" and putting a table is not a good fix.
I'm asking for an example in order to reproduce the error.

#9

Updated by Yannick Warnier about 6 years ago

ok

#10

Updated by Eric Petitdemange about 6 years ago

OK it's a bit more complicated than just only flash.
When I cerate a LP, if the page needs the scroll bar the end of the page (for exampel the last sentance) is truncated.
I have to add a <Return> to have a space between the end of the text and the end of the page, otherwise the scrolling bar doesn't go up to the very bottom of the page.
Obviously if your page contains a full screen video, the video is truncated.

I didn't downloaded the latest 1.9.8, but a week or so the bug was still there.

#11

Updated by Eric Petitdemange about 6 years ago

Hi, I'm not sure it is related, but just in case I can show you a screenshot with a composed page and the result.
truncated1 is the very bottom of the page into the internal Chamilo authoring tool
truncated2 is the very bottom of the displayed page if a trainee goes on this page.

To overcome this, the simpliest way I found was to add a <Return> or two at the end of the pages, so I'm sure to display all the text (and images, videos...)

#12

Updated by Yannick Warnier almost 6 years ago

  • Assignee set to Daniel Barreto
#13

Updated by Daniel Barreto almost 6 years ago

  • Status changed from Needs more info to Needs testing
  • Assignee deleted (Daniel Barreto)
  • % Done changed from 0 to 60

Update how resize LP iframe to consider breadcrumb too then LP isn't truncated bottom
Remove margin-top of breadcrumb

Done in PR 257

https://github.com/chamilo/chamilo-lms/pull/257

#14

Updated by Yannick Warnier almost 6 years ago

Will be assumed fixed in 5 days if no negative feedback before then.

#15

Updated by Yannick Warnier almost 6 years ago

  • Due date set to 24/04/2014
#16

Updated by Laura Guirao almost 6 years ago

I just have tested it in stable.chamilo.org
I have add a .swf document in a learning path. It works fine for me, Flash document is shown correctly

#17

Updated by Yannick Warnier almost 6 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee set to Daniel Barreto
  • % Done changed from 60 to 100

Thanks Laura.

#18

Updated by Yannick Warnier almost 6 years ago

  • Subject changed from solved by a forum user: Affichage d'animation flash tronqué to Flash animations truncated

Also available in: Atom PDF