Project

General

Profile

Bug #5989

CSS too big

Added by Valérie Gérard almost 7 years ago. Updated over 6 years ago.

Status:
Bug resolved
Priority:
Urgent
Category:
Styles, Layout & Accessibility
Target version:
Start date:
26/02/2013
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

contexte : "Sur la page d'accueil du portail, une icône sera affichée à côté du cours pour s'y inscrire rapidement."

Elle s'affiche à la taille 210px

correctif :

media="screen" 
input, textarea {
width: 22px;
}

Files

preview_1.png (159 KB) preview_1.png preview_1 Alberto Montes, 18/04/2013 14:05
preview_2.png (150 KB) preview_2.png preview_2 Alberto Montes, 18/04/2013 14:05
courses-tree.png (35.4 KB) courses-tree.png Yannick Warnier, 24/05/2013 16:53

Associated revisions

Revision efb64be3 (diff)
Added by Yoselyn Castillo over 6 years ago

Re-submitting patch that closes #5989

History

#1

Updated by Valérie Gérard almost 7 years ago

le correctif du correctif ;)

input[name=unsub] {
width:22px;
margin:.2em;
}

Pour l'ergonomie il serait préférable que le texte "S'inscrire" soit cliquable également.

Bien à vous,

#2

Updated by Yannick Warnier almost 7 years ago

  • Target version set to 1.9.6
#3

Updated by Cesar Perales over 6 years ago

Could you provide a screenshot of where is the css too big?

#4

Updated by Yannick Warnier over 6 years ago

  • Category set to Styles, Layout & Accessibility
  • Status changed from New to Needs more info

Valérie, est-ce que tu peux nous faire une capture d'écran de l'icône pour s'inscrire, parce que là on n'est pas trop sûrs de ce dont tu parles...

#5

Updated by Yannick Warnier over 6 years ago

  • Assignee set to Valérie Gérard
#6

Updated by Noa Orizales Iglesias over 6 years ago

I asked Alberto Montes to take a look at this to see if he can find the icon. He will do this on monday 15th of april.

#7

Updated by Alberto Montes over 6 years ago

Hello everybody!!

The following line refers to "/main/css/bootstrap.css" line(800) from. So it seems weird.

input,
textarea {
width: 210px;
}

I really do not know to main page icon refers. Some screenshots would be nice.

#8

Updated by Noa Orizales Iglesias over 6 years ago

Valerie... Can you provide us more information regarding this task please?

#9

Updated by Valérie Gérard over 6 years ago

hope this helps :

issue :
http://note.io/10ijPpQ

situation / context :
http://note.io/113WsLV
http://note.io/10iiQG8

solution :
http://note.io/10ik6cg

cheers !

#10

Updated by Alberto Montes over 6 years ago

Yes Valerie, you're right, when you log in as a student that icon looks very big.
Indeed one option would be to insert css but this could affect other form elements in other sections.

But I think if that icon is a link to sign would be more appropriate to put a <button> instead of <input>. This is just a proposal, perhaps the initial idea of the icon is another.

Attachment 2 previews, preview_1.png is how it is now and the
prewiew_2.png if it were a <button>.

#11

Updated by Yannick Warnier over 6 years ago

No problem for us to add a special CSS identifier for the whole category block to allow to reduce its size.
No problem either to replace it with a <button>. Just let us know what you feel is best.

#12

Updated by Valérie Gérard over 6 years ago

a button
+
a css identifier for both the <form> and the <button>

found this recommandation about bootstrap :

----
Forms

To properly style and position a form within the navbar, add the appropriate classes as shown below. For a default form, include .navbar-form and either .pull-left or .pull-right to properly align it.

<form class="navbar-form pull-left">
<input type="text" class="span2">
<button type="submit" class="btn">Submit</button>
</form>

----- Forms, Bootstrap, online : http://twitter.github.io/bootstrap/components.html#navbar

Thank you ;)

#13

Updated by Noa Orizales Iglesias over 6 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Valérie Gérard to Yoselyn Castillo
#14

Updated by Alberto Montes over 6 years ago

Hello all!
Yes, adding a <button> is more semantic and the best way.

Regards.

#15

Updated by Yoselyn Castillo over 6 years ago

Verifying, later i will send the pull request

#17

Updated by Julio Montoya over 6 years ago

  • Status changed from Assigned to Needs testing
  • % Done changed from 0 to 50
#18

Updated by Yoselyn Castillo over 6 years ago

  • Assignee changed from Yoselyn Castillo to Valérie Gérard

Please, test if you think it looks well now

#19

Updated by Yannick Warnier over 6 years ago

  • Priority changed from Normal to Urgent

Valérie, we need your feedback here (urgently, to close 1.9.6).

#20

Updated by Valérie Gérard over 6 years ago

Sorry yesterday was a day off so as usual I went chasing unicorns...

3 things :

1+2 here : http://note.io/117pwpJ

3. Then should i see the "subscribe" button if i'm already subscribed. If i click i got the error message. http://note.io/117qGBx

have a nice one.

#21

Updated by Yannick Warnier over 6 years ago

  • Status changed from Needs testing to Assigned
  • Assignee changed from Valérie Gérard to Yoselyn Castillo
#22

Updated by Yannick Warnier over 6 years ago

Yoselyn, are you ok with this task?

#23

Updated by Yoselyn Castillo over 6 years ago

Yes, i will send a commit

#25

Updated by Yannick Warnier over 6 years ago

Now it looks like this:

All fixed.

#26

Updated by Yannick Warnier over 6 years ago

OK, apparently there was still a problem with the patch but I just sent a fix by Yoselyn: https://github.com/chamilo/chamilo-lms/commit/efb64be39f638fe01ca536308c5e65bc14130ec3

Checked and approved.

Also available in: Atom PDF