Project

General

Profile

Bug #5727

Moving files in document: path indicator not correct

Added by Stijn Michels about 9 years ago. Updated almost 9 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Category:
Documents
Target version:
Start date:
14/11/2012
Due date:
% Done:

50%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

After moving a file to an other folder, the system jumps to the destination folder.
The indicator of the 'current folder' stays the same as the source folder.
In this state it should be updated and showing the destination folder.

example; Moving a document or entire folder form 'documents' to 'webproductie 1'.
The system moves the content from 'documents' to 'webproductie 1'.
It jums to the folder 'webproductie 1' and then indicates you are in the folder 'documents'.
This is not correct.
You should not jump to webproductie 1 (destination folder) or indicate the right folder (webproductie 1 in stead of 'document')


Files

01.jpg (36.2 KB) 01.jpg Stijn Michels, 14/11/2012 23:28
02.jpg (54.6 KB) 02.jpg Stijn Michels, 14/11/2012 23:28
03.jpg (60.2 KB) 03.jpg Stijn Michels, 14/11/2012 23:28
04.jpg (12.8 KB) 04.jpg Stijn Michels, 14/11/2012 23:28
document.inc.php (47.9 KB) document.inc.php Yoselyn Castillo, 26/11/2012 14:38
Schermafbeelding 2012-11-26 om 22.38.54.jpg (36.3 KB) Schermafbeelding 2012-11-26 om 22.38.54.jpg Stijn Michels, 26/11/2012 22:41
Schermafbeelding 2012-11-26 om 22.39.05.jpg (98.1 KB) Schermafbeelding 2012-11-26 om 22.39.05.jpg Stijn Michels, 26/11/2012 22:41
document.php (54.6 KB) document.php Yoselyn Castillo, 27/11/2012 21:25
ui.jpg (153 KB) ui.jpg Stijn Michels, 29/11/2012 00:16

Associated revisions

Revision 9f5b32f2 (diff)
Added by Yoselyn Castillo about 9 years ago

Fixes bug when moving a document see #5727

History

#1

Updated by Yoselyn Castillo about 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Yoselyn Castillo

checking...

#2

Updated by Yoselyn Castillo about 9 years ago

Fixed. Upload this change.

#3

Updated by Stijn Michels about 9 years ago

I have uploaded the changed file, but it still doesn't work.

Moving a file from documents to "01 PHP en Mysql 1" moves the file, goes to the target folder "01 PHP en Mysql 1", but the current folder indicator, stays on 'documents'. The jumplist should show "01 PHP en Mysql 1"

#4

Updated by Julio Montoya about 9 years ago

  • Assignee changed from Julio Montoya to Yoselyn Castillo

Yoselyn Castillo wrote:

Fixed. Upload this change.

That file has any difference with the current file in the repository here's the diff:


# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- BASE
+++ LOCAL
@@ -50,7 +50,6 @@
     // Group documents cannot be uploaded in the root
     if (empty($group_dir)) {
         $parent_select->addOption(get_lang('Documents'), '/');
-
         if (is_array($folders)) {
             foreach ($folders as $folder_id => & $folder) {
                 $selected = ($document_id == $folder_id) ? ' selected="selected"' : '';

#5

Updated by Yoselyn Castillo about 9 years ago

Problem is with the $document_id
this is the fix
if (isset($_POST['move_to'])) {
$document_id = DocumentManager::get_document_id($course_info, $_POST['move_to']);
}

#6

Updated by Stijn Michels about 9 years ago

Hey Yoselyn
This works fine now! Thank you.

In fact I have a little request. I find it very confusing having the replace document and the current document after each other.
Maybe the 'move' dialog should appear underneath the move-icon or maybe it should have a green background-color (like the notifications on changing items).

I don't know if I can send this here or I should ask this in a new issue.

#7

Updated by Yoselyn Castillo about 9 years ago

Julio, I agree with Stijn, We can change the position of selector move_to if you think it is convenient too..

#8

Updated by Julio Montoya about 9 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)
  • % Done changed from 0 to 50

File was sent.

About the form I think it should be better if we show it in a popup, you could add this feature in a new task.

#9

Updated by Yoselyn Castillo almost 9 years ago

  • Status changed from Needs testing to Bug resolved

Well, the fix is tested. It works fine now. If the change will be reported in other task, we can close this task.

Also available in: Atom PDF