Project

General

Profile

Bug #5625

not able to modify groups

Added by Stijn Michels about 7 years ago. Updated over 6 years ago.

Status:
Bug resolved
Priority:
Urgent
Assignee:
Category:
Users/Groups
Target version:
Start date:
10/10/2012
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

I needed to install a nightly built because of a former bug (groups visible sitewise, not coursewise)
http://www.chamilo.org/forum/viewtopic.php?f=6&t=2591

After installing the current nightly built (10 oct) we are not able te make changes in groups.
After adding a user to a group and clicking to save the changes... it continues, but the changes have not been saved.

In some courses the groups are listed twice (see attached file).


Files

Schermafbeelding 2012-10-10 om 12.51.16.jpg (97.9 KB) Schermafbeelding 2012-10-10 om 12.51.16.jpg Stijn Michels, 10/10/2012 13:15
Schermafbeelding 2012-10-10 om 17.03.05.jpg (23.4 KB) Schermafbeelding 2012-10-10 om 17.03.05.jpg Stijn Michels, 10/10/2012 17:04
group-modification-successfully.gif (26.8 KB) group-modification-successfully.gif Yoselyn Castillo, 13/11/2012 05:52
groupmanager.lib.php (75.6 KB) groupmanager.lib.php Yoselyn Castillo, 13/11/2012 21:27
Schermafbeelding 2012-12-04 om 00.55.24.jpg (16.5 KB) Schermafbeelding 2012-12-04 om 00.55.24.jpg Stijn Michels, 04/12/2012 00:59
group_category.php (10.1 KB) group_category.php Yoselyn Castillo, 07/03/2013 20:06

Related issues

Related to Chamilo LMS - Bug #5608: Groups visible sitewiseBug resolved05/10/2012

Actions

Associated revisions

Revision b8e40248 (diff)
Added by Julio Montoya about 7 years ago

Fixing SQL error when editing groups see #5625

Revision 16bb5450 (diff)
Added by Julio Montoya about 7 years ago

Changing group edition behaviour see #5625

Revision c21ede61 (diff)
Added by Julio Montoya about 7 years ago

Fixing group settings redirection see #5625

Revision 75d0ec65 (diff)
Added by Yoselyn Castillo almost 7 years ago

Not able to modify groups see #5625

Revision 6815c811 (diff)
Added by Julio Montoya almost 7 years ago

Minor adding JS to set radiobutton see #5625

History

#1

Updated by Stijn Michels about 7 years ago

ps Changing groups worked fine in 1.9.2 stable. In the nightly built i'm getting the issue as described above.

#2

Updated by Julio Montoya about 7 years ago

checking

#3

Updated by Julio Montoya about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
#4

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)

there was an sql error now is fixed

#5

Updated by Stijn Michels about 7 years ago

Will it be solved in the next nightly built? Would like to test it, if I can help.

#6

Updated by Julio Montoya about 7 years ago

you can test the latest chamilo 1.9.x code here:

http://stable.chamilo.org/

#7

Updated by Stijn Michels about 7 years ago

Hey Julio
Now it saves the settings and the users, but it stays on the same page.
It used to go back to the group list.

How can I be able to implement this bug fix? Will it be in the next nightly built?

Kind regards
Stijn

#8

Updated by Julio Montoya about 7 years ago

Stijn Michels wrote:

Hey Julio
Now it saves the settings and the users, but it stays on the same page.
It used to go back to the group list.

How can I be able to implement this bug fix? Will it be in the next nightly built?

Kind regards
Stijn

yes I changed that behaviour because the other way was implemented not so well

I changed different files, and yes it will be in the next nightly, did you use mercurial?
You can get the latest bug fixes with mercurial (this is not recommended if your server is in prod mod)

#9

Updated by Stijn Michels about 7 years ago

Hey Julio
It would be user-friendly if there appears a notification after saving the settings, so the user knows it has been saved.
I know some users who would click the save button more than once, otherwise. ;-)

Kind regards
Stijn

#10

Updated by Julio Montoya about 7 years ago

  • % Done changed from 0 to 80

When saving the message now it redirect to the group list and shows a message

#11

Updated by Yoselyn Castillo almost 7 years ago

  • Status changed from Needs testing to Assigned
  • Assignee set to Yoselyn Castillo
#12

Updated by Yoselyn Castillo almost 7 years ago

Now, group modifications works fine and when they are saved it is redirected to group list page and it shows the message. See the attachment.
But when you change the Maximum number of members in groups administration, it doesn't affect the number of seats you are allowed to set when you create a group.
checking...

#13

Updated by Yoselyn Castillo almost 7 years ago

I added some conditions in order to verify limit of users doesn't exceed the settings limitation.
function create_group
lines 191-195
function set_group_properties
lines 486-488

#14

Updated by Julio Montoya almost 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Julio Montoya to Yoselyn Castillo

Fix was sent

#15

Updated by Yoselyn Castillo almost 7 years ago

  • Status changed from Needs testing to Needs more info

It works fine for me, the number of users in group doesn't exceed the limitation specified in general configurations for groups. If you put a number which is higher than the limitation specified, the number of users in the group is set to the limit.

But i have a question, is it correct to have the option "No limitation" in a group, if the general configuration for groups has a number specified?

#16

Updated by Yoselyn Castillo almost 7 years ago

  • Assignee changed from Yoselyn Castillo to Julio Montoya
#17

Updated by Julio Montoya almost 7 years ago

  • Status changed from Needs more info to Needs testing
  • Assignee changed from Julio Montoya to Stijn Michels
#18

Updated by Stijn Michels almost 7 years ago

It works fine in the nightly built of 31 nov. I don't know if there were changes meanwhile.
So I assume it's correct.
There is still one issue... when changing the group where there is no limitation and adding a digit for a limitation. The radio button should automaticaly jump to the limitations-option. 'Onchange' text input limitations, change Radio Button. I believe most users forget to change the bullet, type in a digit but then it stays on no limitations.

#19

Updated by Julio Montoya almost 7 years ago

Stijn Michels wrote:

It works fine in the nightly built of 31 nov. I don't know if there were changes meanwhile.
So I assume it's correct.
There is still one issue... when changing the group where there is no limitation and adding a digit for a limitation. The radio button should automaticaly jump to the limitations-option. 'Onchange' text input limitations, change Radio Button. I believe most users forget to change the bullet, type in a digit but then it stays on no limitations.

I just applied that change

#20

Updated by Yannick Warnier over 6 years ago

  • Target version set to 1.9.6
#21

Updated by Julio Montoya over 6 years ago

  • Assignee changed from Stijn Michels to Yoselyn Castillo

Hi Yoselyn, Can you test this one?

#22

Updated by Yoselyn Castillo over 6 years ago

Upload this file in order to fixing the issue in group/group_category.php too.

#23

Updated by Yannick Warnier over 6 years ago

  • Assignee changed from Julio Montoya to Yoselyn Castillo
#24

Updated by Yoselyn Castillo over 6 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Yoselyn Castillo)

the commit was sent. Needs testing...

#25

Updated by Yannick Warnier over 6 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee set to Julio Montoya
  • % Done changed from 80 to 100

No sure I understand what the problem was with groups categories, but the bug object of this report is fixed (and more). Just checked it.

Also available in: Atom PDF