Project

General

Profile

Bug #5430

Announcements to group: wrong number of recipients

Added by Jan Derriks about 7 years ago. Updated about 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Category:
Announcements
Target version:
Start date:
07/09/2012
Due date:
% Done:

50%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

When an announcement is sent to one or more groups, other users not in those groups get the announcement too.
Also, the number of users per group displayed in the show_to_form is totally wrong.

Cause: error in SQL statement in course.lib.php, function function get_group_list_of_course($course_code, $session_id = 0)
needs an extra select on the course-id in the group_rel_user table or otherwise groups from other courses are added to the count!

BUT IF THIS SOLVES the mail-to-users-outside-group issue needs to be tested further.

diff:
diff r 8f911637b84c main/inc/lib/course.lib.php
--
a/main/inc/lib/course.lib.php Tue Aug 28 17:26:29 2012 0200
++ b/main/inc/lib/course.lib.php Fri Sep 07 20:37:35 2012 0200
@ -1533,10 +1533,13 @
ON g.id = gu.group_id
$session_condition AND
g.c_id = $course_id
AND gu.c_id = $course_id
GROUP BY g.id
ORDER BY g.name";
$result = Database::query($sql);


Files

Knipsel.PNG (12.5 KB) Knipsel.PNG screenshot selected user list Jan Derriks, 07/09/2012 20:41

Related issues

Related to Chamilo LMS - Bug #5394: Error enviando anuncios a un grupo en chamilo 1.9.0 (Announcement bug)Bug resolved31/08/2012

Actions

Associated revisions

Revision 83033700 (diff)
Added by Julio Montoya about 7 years ago

Fixing query in function "get_group_list_of_course" see #5430

History

#1

Updated by Jan Derriks about 7 years ago

announcement problem was:
If you send an announcement to groups BUT NO SINGLE USER, then the announcement will be sent to ALL users.

This is already fixed in 5394: http://support.chamilo.org/issues/5394

It would help if all issues are in English and use english Chamilo-terms like "announcement" so they can be searched better.

#2

Updated by Julio Montoya about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya

Testing

#3

Updated by Julio Montoya about 7 years ago

  • Category set to Announcements
  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)
  • Target version set to 1.9.2
  • % Done changed from 0 to 50

I fixed the query I also added the "Announcement" label in the task

#4

Updated by Julio Montoya about 7 years ago

  • Assignee set to Yoselyn Castillo
#5

Updated by Yannick Warnier about 7 years ago

  • Subject changed from Announcements to group: wrong number of recipiants to Announcements to group: wrong number of recipients
#6

Updated by Yoselyn Castillo about 7 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee deleted (Yoselyn Castillo)

Retested! it works fine. Announcements are only sent to users selected. It was tested in 5394 too.

Also available in: Atom PDF