Bug #5363
HotPotatoes frame too high if Admin bar is on
Complexity:
Normal
SCRUM pts - complexity:
?
Description
HotPotatoes frame to hight if Admin bar is on
We can't see menu, nor breadcrumb
See attached.
So you know if we have a function to check if admin bar is on for current user ?
(depends if it is student, teacher, admin ...)
If bar is on, add 45px in $header_height line 126 in file exercice/showinframe.php
Files
Associated revisions
History
Updated by
Updated by Yannick Warnier about 7 years ago
- Subject changed from HotPotatoes frame to hight if Admin bar is on to HotPotatoes frame too high if Admin bar is on
Updated by Julio Montoya about 7 years ago
Updated by - Status changed from New to Needs more info
I checked the code of exercice/showinframes.php and there are some frames, and a custom header (exercice/testheaderpage.php) ...
Why we don't use just an iframe and the call the Display::display_header(); function?
Any reasons?
Updated by 
Updated by Julio Montoya about 7 years ago
- Status changed from Needs more info to Assigned
- Assignee changed from Hubert Borderiou to Julio Montoya
I'm going to check it out
Updated by Julio Montoya about 7 years ago
I sent some changes I don't know if you're going to like this new way of showing hot potatoes ...
Updated by Julio Montoya about 7 years ago
- Status changed from Assigned to Needs testing
- Assignee deleted (
Julio Montoya) - % Done changed from 0 to 50
Updated by Hubert Borderiou almost 7 years ago
- Status changed from Needs testing to Bug resolved
ok for me
Tested and approuved
Should fix error when showing hotpotatoes see #5363