Project

General

Profile

Bug #5363

HotPotatoes frame too high if Admin bar is on

Added by Hubert Borderiou about 7 years ago. Updated almost 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
27/08/2012
Due date:
% Done:

50%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

HotPotatoes frame to hight if Admin bar is on
We can't see menu, nor breadcrumb
See attached.

So you know if we have a function to check if admin bar is on for current user ?
(depends if it is student, teacher, admin ...)
If bar is on, add 45px in $header_height line 126 in file exercice/showinframe.php


Files

2012-08-27_1647.png (58.9 KB) 2012-08-27_1647.png Hubert Borderiou, 27/08/2012 16:48

Associated revisions

Revision 9d400724 (diff)
Added by Julio Montoya about 7 years ago

Should fix error when showing hotpotatoes see #5363

History

#1

Updated by Yannick Warnier about 7 years ago

  • Target version changed from 1.9.2 to 1.9.4
#2

Updated by Yannick Warnier about 7 years ago

  • Subject changed from HotPotatoes frame to hight if Admin bar is on to HotPotatoes frame too high if Admin bar is on
#3

Updated by Julio Montoya about 7 years ago

  • Status changed from New to Needs more info

I checked the code of exercice/showinframes.php and there are some frames, and a custom header (exercice/testheaderpage.php) ...

Why we don't use just an iframe and the call the Display::display_header(); function?

Any reasons?

#4

Updated by Hubert Borderiou about 7 years ago

Don't know :-(

#5

Updated by Julio Montoya about 7 years ago

intredasting ...

#6

Updated by Julio Montoya about 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Hubert Borderiou to Julio Montoya

I'm going to check it out

#7

Updated by Julio Montoya about 7 years ago

I sent some changes I don't know if you're going to like this new way of showing hot potatoes ...

#8

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)
  • % Done changed from 0 to 50
#9

Updated by Hubert Borderiou almost 7 years ago

  • Status changed from Needs testing to Bug resolved

ok for me
Tested and approuved

Also available in: Atom PDF