Chamilo LMS

should be fixed now

Bug confirmed. It continues not working for me. I defined a session to start in 2 days.
I assigned a known user as general coach for this session. I putted "5" in "Days before" and in the list the session does't appear for tha user. tested in my local pc. I will try in chamilodev.

Upload this file. Fixed. Sessions shown if start_date-$today<= nb_days_access_before_beginning

file sent

It works perfectly in my local pc, but in chamilodev it shows always the session (Although if start_date-$today> nb_days_access_before_beginning) just changing the icon active or inactive. Is chamilodev updated? What do you think is hapenning?

Hello Yoselyn,

I think I sent you an e-mail, didn't I? From now on, we are testing on http://stable.chamilo.org for 1.9.2 and on http://unstable.chamilo.org for 1.10.
I think chamilodev is still updated automatically, but it shouldn't be used anymore, anyway.

I'm assigning it to you again so you can verify on http://stable.chamilo.org (just do the same check as you did here). If it works for you, you can close it.

Upload the file again.

It is fixed now. Sessions are shown Active or inactive it depends on the start date and days before beginnig,but there is a little problem, when i click the session_list.php for first time it shows all sessions, though status combo box is in ACTIVE. if i change the status it shows the correct sessions.

I would highly prefer the DATEDIFF calculation to be done in PHP. The problem with this syntax is, although it will work well faster for a few registers, it makes it impossible for MySQL to use an index on the nb_days_access_before_beginning, because the comparison value is calculated dynamically.
nb_days_access_before_beginning
It would be much better to have the date calculation happen in PHP, then pass a fixed value to MySQL to compare with nb_days_accss_before_beginning. Nice catch, Julio.

Also, take extra caution about the timezones management and the... apparently unnecessary [ "."]

From the way in which is implemented the query, it is very difficult to change the comparison to php. I have developed a function in php, for obtaining the difference between 1 date(passed as parameter) and $today, but i can't invoke the function from mysql passing the parameter(in this case date_start) to be compared the result with nb_days_access_before_beginning.
So i decided to make the comparison in foreach after recovering all data from the query, but the problem is that there are sessions which doesn't appear in any status.
Julio and me have thought it would be useful to have a field "active" in table session in database. Please if you have another alternative...

I will check that

now it should work

Ok, it shows in course list, sessions active and sessions in which date_start-$today <= nb_days_access_before_beginning.
But i have a question: sessions that have already ended should be shown too? If it is like this, you can close the task.

Only when "date_start-$today <= nb_days_access_before_beginnin"g and the other condition with "nb_days_access_after_end" for coaches

ok verifying... because i think in the course list, sessions that have finished their date_end are shown too.

Yes, it shows sessions even if they are finished. So i have done a fix, please upload these files.

I sent the usermanager.lib.php file, I think the code you added in userportal.lib.php exists already in api_get_session_visibility() in main_api.lib.php

I have tested with function api_get_session_visibility, but it doesn't work. It continues showing ended sessions. The code in userportal.lib.php works fine.

The only difference I can see is in the usermanager.lib.php file. Is that all? Where is the user_portal.php change we're talking about here?

Aplicé tu parche. Cambié un poco la ubicación del *24*3600, para que el nombre de la variable sea más lógico
Con esto, asumo que estamos bien. Lo que no esté bien será para la próxima versión (dentro de un mes?)