Chamilo LMS

I can't reproduce that bug. Where is that pagination? IN ASSIGMENT TOOL?

yes in the ASSIGMENT TOOL when you click in a folder, I can't reproduce the error

upload this file, it was a bad query to determine count of works.

I don't agree with that fix, I think the bug is in the visibility field in the item property table something like "AND prop.visibility <> 2". This change need to be tested for students and teachers ...

before your change

 $extra_conditions .= " AND parent_id  = ".$work_id."  ";

    $sql = "SELECT  count(*) as count
            FROM ".$iprop_table." prop INNER JOIN ".$work_table." work ON (prop.ref=work.id AND prop.c_id = $course_id AND work.c_id = $course_id ) 
                    INNER JOIN $user_table u  ON (work.user_id = u.user_id)                         
            WHERE $extra_conditions $where_condition $condition_session ";

after your change:

$extra_conditions .= " AND c_id = ".$course_id." AND parent_id  = ".$work_id."  ";

    $sql = "SELECT  count(*) as count
            FROM ".$work_table." work 
                    INNER JOIN $user_table u  ON (work.user_id = u.user_id)                         
            WHERE $extra_conditions $where_condition $condition_session ";

I have tested The change "AND prop.visibility <> 2" and it doesn't solve the problem.
I think in this query we only need to make a simple count of all works published in TABLE_STUDENT_PUBLICATION from a specific assignment and it was what i did with my change. Did you test it? It works fine for teachers and students.

you need to check with the item property table otherwise you can show deleted/invisible files

I think this would be the query finally

$sql = "SELECT count(*) as count
FROM ".$iprop_table." prop INNER JOIN ".$work_table." work ON (prop.ref=work.id AND prop.c_id = $course_id AND prop.tool='work' AND work.active = 1 AND prop.visibility <> 2 AND work.c_id = $course_id )INNER JOIN $user_table u ON work.user_id = u.user_id)
WHERE $extra_conditions $where_condition $condition_session ";
Tested!
What do you think?

yeah is much better :)

Well, upload this file.

Hello Yoselyn, I just sent the file.

One question: Did you know if you can push commits to github?

It works fine now. See the number in pagination in the attachment