Project

General

Profile

Bug #5311

Exercises: display bug in result modal window

Added by Yannick Warnier about 7 years ago. Updated about 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
1.9.2
Start date:
15/08/2012
Due date:
% Done:

80%

Estimated time:
Spent time:
0.55 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

When not reaching the required score, the warning-message div is included inside the h3 tag, which is technically an HTML validation error (nothing more than text is allowed in <hx> tags), and it also gives an almost unreadable message. See screenshot.

Files

chamilo-bug-display.png (68.9 KB) chamilo-bug-display.png Yannick Warnier, 15/08/2012 21:41
print_score.gif (38.4 KB) print_score.gif Yoselyn Castillo, 16/08/2012 22:13
screen-bug.gif (21.9 KB) screen-bug.gif Yoselyn Castillo, 21/08/2012 16:33
good-screen.gif (29.8 KB) good-screen.gif Yoselyn Castillo, 22/08/2012 23:56

Associated revisions

Revision d1fb16d3 (diff)
Added by Julio Montoya about 7 years ago

Fixing exercise result message see #5311

Revision fdd798b4 (diff)
Added by Julio Montoya about 7 years ago

Fixing category div see #5311

Revision 74468146 (diff)
Added by Julio Montoya about 7 years ago

Result message is green or red if success or not see #5311

Revision 7603767e (diff)
Added by Julio Montoya about 7 years ago

Fixing exercise result header see #5311

History

#1

Updated by Yannick Warnier about 7 years ago

hint: line 1200 of exercise.lib.php

#2

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Julio Montoya to Yoselyn Castillo
  • % Done changed from 0 to 50

I updated the divs

#3

Updated by Yoselyn Castillo about 7 years ago

  • File print_score.gif print_score.gif added
  • Status changed from Needs testing to Needs more info
  • Assignee changed from Yoselyn Castillo to Julio Montoya

It doesn't break now, but the style of warning has been changed. Is this warning style correct now?
other thing, width of of the category row is shorter than the other ones.

See screenshot

#4

Updated by Julio Montoya about 7 years ago

yeah, I changed the "style of warning". I added a "success" or "fail" icon at the right
I will fix the category style

#5

Updated by Julio Montoya about 7 years ago

  • Status changed from Needs more info to Needs testing
  • Assignee changed from Julio Montoya to Yoselyn Castillo
  • % Done changed from 50 to 80
#6

Updated by Yoselyn Castillo about 7 years ago

  • File screen-bug.gif screen-bug.gif added
  • Status changed from Needs testing to Assigned
  • Assignee changed from Yoselyn Castillo to Julio Montoya

There is a problem with the width of message. See the pink rectangle in screen-bug.gif

#7

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)

I just sent a fix

#8

Updated by Yoselyn Castillo about 7 years ago

  • Assignee set to Yoselyn Castillo
#9

Updated by Yoselyn Castillo about 7 years ago

Fixed. See the attachment

#10

Updated by Yoselyn Castillo about 7 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee deleted (Yoselyn Castillo)

Also available in: Atom PDF