Project

General

Profile

Bug #5243

Installation - strange button for previous step

Added by Marko Kastelic about 7 years ago. Updated about 7 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
-
Target version:
Start date:
24/07/2012
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

applies to every step with back button


Files

inst_step2.png (7.08 KB) inst_step2.png Marko Kastelic, 24/07/2012 11:46
2012-07-27_1700.png (16.8 KB) 2012-07-27_1700.png Hubert Borderiou, 27/07/2012 17:00

Associated revisions

Revision 69154f42 (diff)
Added by Laurent Opprecht about 7 years ago

see #5243 strange button for previous step

History

#2

Updated by Julio Montoya about 7 years ago

  • Target version set to 1.9 RC1
#3

Updated by Yannick Warnier about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Laurent Opprecht

Yes, this is related to a commit by Laurent. I already told him.

#4

Updated by Laurent Opprecht about 7 years ago

on its way

#5

Updated by Yannick Warnier about 7 years ago

  • Subject changed from Installation - strange button to prevois step to Installation - strange button for previous step
#6

Updated by Yannick Warnier about 7 years ago

  • Target version changed from 1.9 RC1 to 1.9 Stable
#7

Updated by Yannick Warnier about 7 years ago

Yes you can! :-) (we're all expecting your fix)

#8

Updated by Laurent Opprecht about 7 years ago

  • Status changed from Assigned to Needs testing
  • % Done changed from 0 to 90

So I removed the btn.back style and moved to bootstrap logic the of using <i> tags for icons.
I applied the changes to the new link/course description/notebook tools.

This clashes with the action bar style so I renamed the "actions" style to "actions-bar". This is very much open to discussion as it is departures from current visual layout. I left that inactive so we have time to discuss what we really want to do. Other options are certainly possibles.

I must admit that I am not too happy with pushing code to the default branch so close to a release but I spent time to verify that this code is inactive.

#9

Updated by Yannick Warnier about 7 years ago

  • Status changed from Needs testing to Assigned

I am worried this change will affect the release too much (you mentionned you only modified it in 3 tools).

Could we not, in this case, simply modify the style in the installer and fix the rest later (in 1.9.2 for example)?

It's really just because you modified this style in the first place that I'm asking you to review it, but as far as I know it was only broken in the installer.

I am really not comfortable with the CSS change you sent. There are too many possible side-effects.

#10

Updated by Yannick Warnier about 7 years ago

Just to be 100% clear: please just hack the main/install/ directory and define a new style for this "previous" button. I don't think it affects anything else.

#11

Updated by Laurent Opprecht about 7 years ago

I renamed my change (as well as a few others) to a different selector

i.size-32.back

or something similar which do not conflict with existing rules. And the code impacted is not in use, I am waiting for the new version as this is too close to release. So this should really be fine.

Now this may be the opportunity to work out a solution for future changes - possibly introducing a few branches: default, dev, qa, 1.9 stable, etc?

#12

Updated by Laurent Opprecht about 7 years ago

And I certainly aggree with avoiding impacts to the release.

#13

Updated by Yannick Warnier about 7 years ago

I said that because in your commit I saw there were changes to .btn.* (many styles deleted). Am I looking at something that wasn't used?

#14

Updated by Laurent Opprecht about 7 years ago

Right those were introduced following the same pattern of .btn.something but they won't have an impact.

#15

Updated by Hubert Borderiou about 7 years ago

I have checked it, and it's ok for me.
see attached for the pretty previous button.

#16

Updated by Marko Kastelic about 7 years ago

it's ok for me too.

#17

Updated by Yannick Warnier about 7 years ago

  • Status changed from Assigned to Bug resolved
  • % Done changed from 90 to 100

Thanks!

Also available in: Atom PDF