Project

General

Profile

Bug #4901

Move auth/ config files to main/inc/conf/

Added by Yannick Warnier about 8 years ago. Updated almost 8 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
14/06/2012
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

All configuration files should always be located in main/inc/conf/
This is a non-written standard to avoid making it more difficult to integrate into Linux packaging systems. Having all the config files in the same directory will allow us to easily more that directory some place else.

This is a structural change, so it has to be done before releasing the beta (otherwise we will have ghost files in main/auth/external_login/

Copying Hubert, Noel, Juan Carlos and Laurent so they learn about the conf directory rule.


Subtasks

Bug #4914: shibboleth: Move auth/ config files to main/inc/conf/AssignedLaurent Opprecht

Actions

Related issues

Related to Chamilo LMS - Bug #5042: Error message on install confirmation screenBug resolved25/06/2012

Actions

Associated revisions

Revision 3449bb94 (diff)
Added by Julio Montoya about 8 years ago

Moving auth configurations to the new conf file: auth.conf.dist.php see #4901

History

#1

Updated by Julio Montoya about 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)
  • % Done changed from 0 to 10

These are the files I found with the conf/dist extension:

external_login/facebook.conf.php (2)
external_login/ldap.conf.php (1)
openid/openid.conf.php (3)
shibboleth/config.dist.php (2)
shibboleth/config.php (2)
shibboleth/config/aai.class.php (not sure if this is a conf file or just a class with some attributes or both)

In some of the files there are some functions (1), or object creation (2), or just a declaration of strings (3)

I suggest just to rename the files to avoid the "conf" tag, except for the ldap.conf, that class need to be moved to the conf/ directory, and move the functions somewhere else. Maybe Laurent or Hubert could make the job?

#2

Updated by Laurent Opprecht about 8 years ago

You can certainly create a subtask for Shibb and assign it to me (some will stay some with move)

#3

Updated by Laurent Opprecht about 8 years ago

I mean some files will stay some files will move to the conf folder

#4

Updated by Julio Montoya about 8 years ago

Laurent Opprecht wrote:

You can certainly create a subtask for Shibb and assign it to me (some will stay some with move)

task created: #4914

#5

Updated by Yannick Warnier about 8 years ago

Please create one single main/inc/conf/auth.conf.dist.php with all the sections of the auth/ conf files in comment.

During the installation process, copy this .conf.dist.php file as a .conf.php file.

Re-point all the README.txt files (in English inside the plugins) to this one and only file main/inc/conf/auth.conf.php.

This way we centralize everything that has to do with authentication in one single place, uncommenting authentication sections as we need them. A clear section should identify each authentication method:

<?php
/* For licensing ... */
/**
 * Configuration file for all authentication methods. Uncomment and configure only the section(s) you need.
 * @package chamilo.conf.auth
 */
/**
 * Facebook
 */
// $facebook_login = array(...);
/**
 * Shibboleth
 */
// $shibb_login = ...;
/**
 * LDAP
 */
// $ldap_details = ...;
/**
 * OpenID
 */
// $openid = ...;
/**
 * CAS
 */
//$cas = ...;

I think that's the clearest and most ordered way of doing it. Otherwise we'll end up with 100 different configuration files within a year or so...

Then make sure you always include the auth.conf.php file from the global.inc.php script (so you doon't have to call these from the authentication script itself, which would make this one even shorter).

#6

Updated by Julio Montoya about 8 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Julio Montoya

I will move the configuration as Yannick said

#7

Updated by Julio Montoya about 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

I moved the openid, ldap and facebook waiting task #4914 for shibo

#8

Updated by Jan Derriks about 8 years ago

Where can I find ldap.conf.php? Please fix the ldap auth.

#9

Updated by Yannick Warnier about 8 years ago

Jan Derriks wrote:

Where can I find ldap.conf.php? Please fix the ldap auth.

Hi Jans, they've been moved to main/inc/conf/auth.conf.php as an effort to keep configuration files in the same folder, which is to facilitate the move to the HFS (Hierarchical File System) standard very soon (after 1.9 though).

The contents of th previous ldap.conf.php file are now in the main/inc/conf/auth.conf.php file. We will update the documentation accordingly very soon.

#10

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.9 Beta to 1.9 RC1
#11

Updated by Jan Derriks about 8 years ago

Yannick Warnier wrote:

Jan Derriks wrote:

Where can I find ldap.conf.php? Please fix the ldap auth.

Hi Jans, they've been moved to main/inc/conf/auth.conf.php as an effort to keep configuration files in the same folder, which is to facilitate the move to the HFS (Hierarchical File System) standard very soon (after 1.9 though).

The contents of th previous ldap.conf.php file are now in the main/inc/conf/auth.conf.php file. We will update the documentation accordingly very soon.

today's http://code.google.com/p/chamilo/source/browse?repo=classic#hg%2Fmain%2Finc%2Fconf
Still shows no sign of a ldap.conf.php:
add_course.conf.dist.php
course_info.conf.dist.php
events.conf.dist.php
index.html
mail.conf.dist.php
portfolio.conf.dist.php
profile.conf.dist.php

#12

Updated by Julio Montoya about 8 years ago

in Chamilo 1.9 check the main/inc/conf/auth.conf.dist.php file, when installing chamilo 1.9 a new file called : main/inc/conf/auth.conf.php should be created

#13

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs more info to Bug resolved
  • Assignee set to Julio Montoya

Verified by Yannick!

#14

Updated by Jan Derriks almost 8 years ago

Julio A. Montoya wrote:

in Chamilo 1.9 check the main/inc/conf/auth.conf.dist.php file, when installing chamilo 1.9 a new file called : main/inc/conf/auth.conf.php should be created

That may be the case in a new install, but not if you upgrade from 1.8.

The authentication mechanism and the configuration (via conf files and/or admin panel) and the on-line documentation is very confusing.

I agree with http://www.chamilo.org/forum/viewtopic.php?f=6&t=2424

AND login.php in auth/ldap causes an undefined $_uid reference:
Session::write('_uid',$_uid);

What does it do?

Also available in: Atom PDF