Project

General

Profile

Bug #4883

Add fields to gradebook tables

Added by Yannick Warnier over 7 years ago. Updated over 7 years ago.

Status:
Bug resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
12/06/2012
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

This is related to internal BeezNest Task 4080.

We need to add the possibility for evaluations (each sub-evaluation in the new system) to:
  • register a number of external evaluation sheets to be created (selecting 5 will generate 5 external evaluations directly in the process of course creation, marked over /20)
  • register a number of minimum-score evaluations which will not be included in the score evaluation
  • register an optional prefix for the name of the external evaluations (so when new evaluations are created, they are automatically named "[Prefix] 1", "[Prefix] 2", etc

For now, the only important thing is to add the 3 fields into the database and make sure they are not used (yet). This will be implemented in parallel to 1.9 stable.

I suppose this should go into the gradebook_evaluation table... (although you know this better, I'm not sure as this has to be part of the evaluation model as well).

Fields should be something like:
  • default_external_eval TINYINT default null,
  • default_lowest_eval_exclude TINYINT default null,
  • default_external_eval_prefix VARCHAR

Associated revisions

Revision 609042a7 (diff)
Added by Julio Montoya over 7 years ago

Adding new fields in the grade_model see #4883

Revision c82e6726 (diff)
Added by Julio Montoya over 7 years ago

Adding field in the gradebook_category see #4883

History

#1

Updated by Julio Montoya over 7 years ago

In fact the table is gradebook_category (the container of gradebook_evaluations)

#2

Updated by Julio Montoya over 7 years ago

I will asumme that you're obliged to use the grade model in order to use these features,
if so the changes will be added in the grade_model

#3

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier
  • % Done changed from 0 to 50

Fields added in the grade_model

#4

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

Julio Montoya wrote:

I will asumme that you're obliged to use the grade model in order to use these features,
if so the changes will be added in the grade_model

Yes, but if somebody changes the grade model afterwards, it shouldn't impact the previous gradebooks created. That's why gradebook_category table should at least have the lowest_eval_exclude field as well

#5

Updated by Julio Montoya over 7 years ago

Yannick Warnier wrote:

Julio Montoya wrote:

I will asumme that you're obliged to use the grade model in order to use these features,
if so the changes will be added in the grade_model

Yes, but if somebody changes the grade model afterwards, it shouldn't impact the previous gradebooks created. That's why gradebook_category table should at least have the lowest_eval_exclude field as well

I don't like that, but if that's the requirement I will add the same field in the gradebook_category, so the grade model will be fill by default the "lowest_eval_exclude"

#6

Updated by Yannick Warnier over 7 years ago

How else do you think it could be done? We need a global setting and a way to remember, for each gradebook, how many lowest evaluations we want to exclude.

#7

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier
  • % Done changed from 50 to 80

I already added the field see r18381, yes you're right, we're force to add the field in the gradebook_category in order to use in both ways (with grademodels and with out grade models)

#8

Updated by Yannick Warnier over 7 years ago

Julio, in r18381, you obviously remove a (minor) patch I had made previously (in learnpathItem.class.php). Did Mercurial not give you a warning of some kind? (this is worrying, I hop it didn't occur with other stuff).

There are also removed sections in other files (which seem more related to Juan Carlos' work). Could you plase review what is really part of your commit and ensure you didn't delete somebody else's work? Thanks.
Let me know here afterwards. I'll check and close the task (the task itself is closed now).

#9

Updated by Julio Montoya over 7 years ago

in r18381 there are only db changes ...

#10

Updated by Yannick Warnier over 7 years ago

There must be a bug somewhere in Redmine. Look at this: http://support.chamilo.org/projects/chamilo-18/repository/revisions/18381/diff (just following the links to see the "diff" of this commit)

#11

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Bug resolved
  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 80 to 100

OK, checked in google code. Thanks.

Also available in: Atom PDF