Project

General

Profile

Bug #4711

update_version variable not used

Added by Laurent Opprecht over 7 years ago. Updated over 7 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
-
Target version:
Start date:
07/05/2012
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

In install/index.php

    $instalation_type_label = '';
    if ($installType == 'new'){ 
        $instalation_type_label  = get_lang('NewInstallation'); 
    }elseif ($installType == 'update') {
        $instalation_type_label = get_lang('UpdateFromDokeosVersion').(is_array(*$update_from_version*) ? implode('|', $update_from_version) : '');
    }

Raises a warning

PHP Notice: Undefined variable: update_from_version. And beside raising a warning it is not initialized/used - that is as far as I can tell.

This is not a big issue but it creates noise and makes difficult to find real error.

History

#1

Updated by Laurent Opprecht over 7 years ago

I am going to suppress the warning but it may be worth removing the code or making it works.

#2

Updated by Laurent Opprecht over 7 years ago

  • Assignee set to Laurent Opprecht
  • % Done changed from 0 to 90

In https://code.google.com/r/laurentopprecht-gva/ until I am done moving things in and out between test and dev.

#3

Updated by Yannick Warnier over 7 years ago

As far as I know this variable was actually defined in much older versions od D0keos. That's why it's still there: it is defined by a PHP script (which I don't remember the name of) in D0keos 1.6.5 or older. I would leave it there but maybe put an if (!isset($update_version)) to avoid the warning.

#4

Updated by Laurent Opprecht over 7 years ago

  • Status changed from New to Bug resolved
  • % Done changed from 90 to 100
#5

Updated by Yannick Warnier over 7 years ago

  • Target version set to 1.9 Beta

Also available in: Atom PDF