Project

General

Profile

Bug #4689

improper use of echo statement in access_datails.php

Added by Marko Kastelic over 7 years ago. Updated over 7 years ago.

Status:
Feature implemented
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
02/05/2012
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

main/myspace/access_details.php line 228
echo is used as function. everything works ok but translations (i got spanish langvars: mas, cerrar or something?). Just free the string from parentheses ...

Associated revisions

Revision 3cdb6801 (diff)
Added by Julio Montoya over 7 years ago

Fixing get_lang variable bug see #4689

Revision 9e3061fb (diff)
Added by Julio Montoya over 7 years ago

Updating icons see #4689

History

#1

Updated by Marko Kastelic over 7 years ago

i'm taking back previous statement.
After refresh, i got corrent langvar valuee, but playing with more/less returns to spanish again ...

#2

Updated by Julio Montoya over 7 years ago

  • Status changed from New to Needs more info
  • Target version set to 1.9 Beta
  • % Done changed from 0 to 80

should be fixed now

#3

Updated by Marko Kastelic over 7 years ago

grrrrr....
check out myspace/slider.js :

function sliderAction()
{
    if (slider_state == "close")
    {
        sliderOpen();
        slider_state = "open" 
        $(".slider_menu").html('<a href="#" onclick="return sliderAction();">Cerrar</a>');
    }
    else if (slider_state == "open")
    {
        sliderClose();
        slider_state = "close";
        $(".slider_menu").html('<a href="#" onclick="return sliderAction();">M&aacute;s...</a>');
    }

    return false;
}

initial language set is ok now.

#4

Updated by Julio Montoya over 7 years ago

now it should be fixed i added new icons in order to avoid those problems ...

http://code.google.com/p/chamilo/source/detail?r=acbf3528088e2c6b292d924c21f83bf3f7d91294&repo=classic

#5

Updated by Marko Kastelic over 7 years ago

it is working now. I (personally) prefer to see the text in such a case, but icon should be ok too. Maybe just to remove useless second condition ( if(slider_state=="open") since thre is no 3rd state ? To spare a nano second or two ...

#6

Updated by Yannick Warnier over 7 years ago

Julio Montoya wrote:

now it should be fixed i added new icons in order to avoid those problems ...

http://code.google.com/p/chamilo/source/detail?r=acbf3528088e2c6b292d924c21f83bf3f7d91294&repo=classic

Please indicate the origin of the icons in documentation/credits.html so we keep track of where they come from (in case of licensing issues). Thanks.

#8

Updated by Alberto Torreblanca over 7 years ago

  • Status changed from Needs more info to Feature implemented
  • Assignee set to Julio Montoya
  • % Done changed from 80 to 100

Also available in: Atom PDF