Project

General

Profile

Feature #4658

Nice to have: E-mails template

Added by Noa Orizales Iglesias over 7 years ago. Updated over 7 years ago.

Status:
Feature implemented
Priority:
Normal
Category:
-
Target version:
Start date:
25/04/2012
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

One more suggestion from Eric Petitdemange: "Emails template: having a simple way to generate emails from templates (it's not always the specialist that deals with this part...), especially when using the platform in different languages, again we have to ensure e have all the emails translated."
"


Related issues

Related to Chamilo LMS - Bug #4525: E-mail template for registrationFeature implemented23/03/2012

Actions
Is duplicate of Chamilo LMS - Feature #984: Events messages templatesFeature implemented15/04/2010

Actions

Associated revisions

Revision 4b62b031 (diff)
Added by Julio Montoya over 7 years ago

Removing int(11), + other mysql fixes see #4658

Revision 08335baa (diff)
Added by Julio Montoya over 7 years ago

Changing DB constants email templates see #4658

Revision ba2197b8 (diff)
Added by Julio Montoya over 7 years ago

Adding database::escape_string, intvals etc see #4658

Revision 0bc2807f (diff)
Added by Julio Montoya over 7 years ago

PRinting the event mail template, fixing some jquery, adding security, still need more work see #4658

Revision b688b13c (diff)
Added by Julio Montoya over 7 years ago

More fixes in the event system kind of work right now see #4658

Revision e2c7c6ad (diff)
Added by Julio Montoya over 7 years ago

Minor fixes in the event.conf.dist.php see #4658

Revision 93a38cde (diff)
Added by Julio Montoya over 7 years ago

Adding include events.conf.local.php see #4658

History

#1

Updated by Yannick Warnier over 7 years ago

Adding Noël to this task. I know he's been doing something related to this that is supposed to be sent to Chamilo 1.9 shortly...

#2

Updated by Yannick Warnier over 7 years ago

  • Target version set to 1.9 Beta
#3

Updated by Yannick Warnier over 7 years ago

  • Assignee set to Julio Montoya
  • % Done changed from 0 to 80

Julio, could you give the e-mail templates a check-up and see if it's OK as it is (these were Anne-Lise commits) in terms of feature (whether it works or not)? I'm leaving it as part of the beta as a few things have changed in the database as far as I know (if we make a mistake, we'll have to launch another beta for the database changes).

#4

Updated by Julio Montoya over 7 years ago

  • Status changed from New to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

As I commented in another task, I believe there's no interface in order to create event templates you have access only to that page:

main/admin/event_type.php

and you're blocked there.

I could finish that work if we're sure that there are no pending changes ... I don't want doubles ...

#5

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

There are no pending changes. Noël told me Anne-Lise was going to upload the latest version, so what is there now is the broken merge between CBlue's work and ours. Go ahead.

#6

Updated by Julio Montoya over 7 years ago

here we go

#7

Updated by Julio Montoya over 7 years ago

Adding some security fixes

#8

Updated by Julio Montoya over 7 years ago

  • % Done changed from 80 to 60

I fixed some jquery problems, need to rethink in a better way to use this tool, is not a good idea to create a event.conf.php and add functions there ...

#9

Updated by Julio Montoya over 7 years ago

Maybe moving that configuration in the DB, or moving that configuration in another place (event.conf.php), or using the platform settings, or maybe even the new plugin system??

I just fixed the current code ... I'm not "engaging" (commiting) in big changes right now ...

#10

Updated by Yannick Warnier over 7 years ago

events.conf.php is my favourite option

#11

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

Yannick Warnier wrote:

events.conf.php is my favourite option

ok, but why creation 2 files, events.conf.php and events.conf.php.dist?

#12

Updated by Julio Montoya over 7 years ago

hehe I found something "funny", in the script (admin/event_type.php) they're printing all platform users data, including passwords etc (when you only need user_id, first name, last name )

...

    var usersList = [{"0":"1","user_id":"1","1":"Doe","lastname":"Doe","2":"John","firstname":"John","3":"admin","username":"admin","4":"d033e22ae348aeb5660fc2140aec35850c4da997","password":"d033e22ae348aeb5660fc2140aec35850c4da997","5":"platform","auth_source":"platform","6":"[no address given]","email":"[no address given]","7":"1","status":"1","8":"ADMIN","official_code":"ADMIN","9":"(000) 001 02 03","phone":"(000) 001 02

#13

Updated by Julio Montoya over 7 years ago

I sent more fixes kind of work right now, I add a new example (template) that is fired when admin edits the portal homepage

#14

Updated by Julio Montoya over 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

Add an @include to events.conf.local.php

#15

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

include added

#16

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

We have to find another place for the functions defined in the events.conf.php file. This is not a place for functions. What do you think about putting them in main/inc/lib/events.lib.php file?

#17

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier
  • % Done changed from 60 to 80

Functions moved to events.lib.php

#19

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Feature implemented
  • Assignee changed from Yannick Warnier to Noël Dieschburg
  • % Done changed from 80 to 100

Also available in: Atom PDF