Project

General

Profile

Bug #4619

Course legal notice isn't visible when not registered in a course

Added by Hubert Borderiou about 8 years ago. Updated almost 8 years ago.

Status:
Bug resolved
Priority:
Low
Assignee:
Julio Montoya
Category:
-
Target version:
1.9 Stable
Start date:
17/04/2012
Due date:
% Done:

80%

Estimated time:
Spent time:
0.75 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,
if I go to view an open course (open to the planet, or open to the platform) I don't see the Course legal notice.
May be, we could have to check the Accept Legal Term checkbox before entering the course even if we are not registered.
In this case, I think we will have to check the Accept-Legal-Term-checkbox each time we want to view the course.

regards,

Files

2012-07-19_0945.swf (2.28 MB) 2012-07-19_0945.swf Hubert Borderiou, 19/07/2012 09:50

Associated revisions

Revision 80344357 (diff)
Added by Julio Montoya almost 8 years ago

Allowing legal notice in courses with visibility OPEN_WORLD, OPEN_PLATFORM see #4619

Revision 0a255edf (diff)
Added by Julio Montoya almost 8 years ago

Should fix bug in the condition class. Swapping the return values of the function, returns true means that the user can pass, false otherwise see #4619

Revision 4dd876d9 (diff)
Added by Julio Montoya almost 8 years ago

Should fix bug when using course legal when loggin as anonymous see #4619

Revision 4752bcfc (diff)
Added by Julio Montoya almost 8 years ago

Fixing user id wrong variable see #4619

History

#1

Updated by Yannick Warnier about 8 years ago

  • Target version set to 1.9 RC1
#2

Updated by Julio Montoya almost 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
#3

Updated by Julio Montoya almost 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yoselyn Castillo
  • % Done changed from 0 to 80

should be fixed now

#4

Updated by Yoselyn Castillo almost 8 years ago

  • Assignee changed from Yoselyn Castillo to Julio Montoya

What is the course legal notice? Where should it appear?

#5

Updated by Hubert Borderiou almost 8 years ago

Hi see attched for some explanation.
If you enter the course without being logged, you should see the Legal Agreement (as shown of my screencast)
But if you go in the course as an anonymous user, you should see the Legal Agreement each time you enter the course.
With the patch now, you just see the legal agreement once if you go to the course as Joe Anonymous.
You shouldn't save the fact that Joe Anonymous checked the Legal term agreement, just give him access once.

#6

Updated by Julio Montoya almost 8 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Julio Montoya to Yannick Warnier
#7

Updated by Yannick Warnier almost 8 years ago

  • Assignee changed from Yannick Warnier to Julio Montoya

Julio, my commit http://code.google.com/p/chamilo/source/detail?r=dad09a8c0e7607f37324e218fd0f9fd234986776&repo=classic fixed a problem by which you couldn't login to the platform anymore (locally or on chamilodev) because it would always send you to th registration form, even when logging in as (valid account) admin / admin.

I'm not against the fact of adding the conditional login for courses, but it has to work to login to th platform :-)

I'm sure you'll be able to figure that much faster than I do as you put it in place yourself.

#8

Updated by Julio Montoya almost 8 years ago

ok the problem here was that this condition works in the other way as I thought:

function check_platform_legal_conditions() have to return true if there's an error and false if user can login normally, I thought it was the other more "logical" way:

true if user can pass, false if user can't pass ...

what do you prefer?

#9

Updated by Julio Montoya almost 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier
#10

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya

Yeah, swap the function results while we can still do it without harming any plugin using it :-)
Is that all that was broken?

#11

Updated by Julio Montoya almost 8 years ago

yes

#12

Updated by Julio Montoya almost 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

I sent a fix for that

#13

Updated by Yoselyn Castillo almost 8 years ago

  • Assignee set to Yoselyn Castillo
#14

Updated by Yoselyn Castillo almost 8 years ago

  • Assignee changed from Yoselyn Castillo to Julio Montoya

Describo el comportamiento actual como anonimo
entre como anonimo y no salio el legal notice
luego entro como admin
me deslogueo
entro como anonimo otra vez
nada tampoco
le doy click a homepage como anonimo igual
y entonces entro otra vez al curso y si me lo pide

#15

Updated by Julio Montoya almost 8 years ago

  • Status changed from Needs more info to Needs testing
  • Assignee changed from Julio Montoya to Yoselyn Castillo

Ahora debería de funcionar

#16

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs testing to Assigned
  • Assignee changed from Yoselyn Castillo to Julio Montoya

Very good (and coherent) now.
I connected and disconnected several times as anonymous. Every time my (php) session was deleted, I had to confirm the legal agreements (OK)

I also connected as a user:
  • If the user was subscribed to the course by the teacher before the legal terms were set, the user isn't asked to accept them (OK).
  • If the user is subscribed to the course after the legal terms are set, he is asked to accept the terms (OK)
I found one case where it doesn't work though (call it luck):
  • A course called "ABC" is public (open to the world) and has legal terms
  • User X is registered on the platform but not subscribed to course ABC
  • User X logs in and clicks on the link to enter the cours (from the most popular courses' list)
  • He accepts the legal terms and click the button
  • Error: The page isn't redirecting properly (the URL says /main/course_info/legal.php?course_code=ABC&session_id=0)

That's only one situation remaining that fails.

#17

Updated by Julio Montoya almost 8 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)

should be fixed now

#18

Updated by Yannick Warnier almost 8 years ago

  • Target version changed from 1.9 RC1 to 1.9 Stable
#19

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee set to Julio Montoya

Good! Now we're talking!

Also available in: Atom PDF