Project

General

Profile

Bug #4503

Error when adding mp3 to learning path item if lots of items, +adding drag&drop audio

Added by Hubert Borderiou over 7 years ago. Updated over 7 years ago.

Status:
Bug resolved
Priority:
Low
Assignee:
Category:
-
Target version:
Start date:
21/03/2012
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,
I've got a learning path with more than 200 item (official french C2i certification).
I want to add a sound file on some items for this LP.
I've got a form with an input box allowing me to upload a mp3 file for each LP item.
I'v got a page with 200 input-file objects in the page (see attached)

I've got the followinf error if I want to add a sound file to the 21st item of my LP :
[PHP Warning: Maximum number of allowable file uploads has been exceeded in Unknown on line 0, referer: (...)main/newscorm/lp_controller.php?cidReq=COURS00001&id_session=0&gidReq=0&action=admin_view&lp_id=1&updateaudio=true]

When I submit the form, it posts a FILE value for each input-file object, event if we didn't browse a file in it.
As a result, the page attempts to post an array of 200 files (there is an entry even if the filename is empty)

In the php.ini, the default value of max_file_uploads is 20. (and for suhosin it is 25).
If you don't modify this value, you can just add a mp3 file to the 20th first items of your learning path.

A way to correct this is to modify your max_file_uploads (and suhosin suhosin.upload.max_uploads value) to 300, for instance. But you can have over problem doing this.

It should be possible to modify the "add sound" process for learning path item.
Instead of generating all input-file html objet, we could add a button "Add sound file" that generate the corresponding input-file html object.

It is not urgent, but this could occur to someone else.

Regards,


Files

2012-03-21_1644.png (70.2 KB) 2012-03-21_1644.png Hubert Borderiou, 21/03/2012 16:45
audio.png (33.9 KB) audio.png Julio Montoya, 11/06/2012 23:13
2012-06-12_1604.png (125 KB) 2012-06-12_1604.png Hubert Borderiou, 12/06/2012 16:03

Associated revisions

Revision e29ab334 (diff)
Added by Julio Montoya over 7 years ago

Should fix bug when uploading a lot of files see #4503

Revision ef9f0a82 (diff)
Added by Julio Montoya over 7 years ago

Fast audio insert when creating a LP see #4503

Revision 436e88c6 (diff)
Added by Yannick Warnier over 7 years ago

Fixed warning in audio addition when user ID not defined, use current user ID - refs #4503

Revision e130495b (diff)
Added by Yannick Warnier over 7 years ago

Fixed warning in audio addition when user ID not defined, use current user ID - refs #4503

History

#1

Updated by Julio Montoya over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
  • Target version set to 1.9 Stable

You're right, I remember that Yannick told me to fix that behaviour in Bruxelles one more task to do ...

#2

Updated by Yannick Warnier over 7 years ago

Got the problem with one customer today, and I remember someone had that problem before (I think it was in France as well). Important to fix. (was BT 4180)

#3

Updated by Yannick Warnier over 7 years ago

  • Target version changed from 1.9 Stable to 1.9 Beta
#4

Updated by Julio Montoya over 7 years ago

  • File audio.png audio.png added
  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)
  • % Done changed from 0 to 60

Now you can add an mp3 one by one, so you are not obliged to go to the full list we need to integrate somehow with fckeditor ...

but I guess we can close this task and create another one?

#5

Updated by Yannick Warnier over 7 years ago

Great. Yes, move to another one. In particular, it would be interesting to also be able to upload mp3's from the documents list (I don't know if you can quick-hack this?), because now you can record them and generate them in documents, so it's very useless to have to download it and upload it again...

#6

Updated by Hubert Borderiou over 7 years ago

May be you should remove the Add Audio icon on the top list that link to the old audio upload page.
see attached

#7

Updated by Yannick Warnier over 7 years ago

Hubert Borderiou wrote:

May be you should remove the Add Audio icon on the top list that link to the old audio upload page.
see attached

Agreed. The previous "organize" section now is completely useless (both for mp3 or for simple reorganization)

#8

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Julio Montoya

Assigned to add the files selector

#9

Updated by Julio Montoya over 7 years ago

File selector added

#10

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier
  • % Done changed from 60 to 80
#11

Updated by Yannick Warnier over 7 years ago

  • Subject changed from Error when adding mp3 to learning path item, if lots of items in the learning path to Error when adding mp3 to learning path item if lots of items, +adding drag&drop audio
  • Status changed from Needs more info to Bug resolved
  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 80 to 100

Ther's still a bit of non-intuitiveness with the visible/invisible audio directory (I think hidden directories should appear there, just not hidden files) but it's much nicer this way.

Good job on the whole thing!

(I sent a commit to avoid a warning)

Also available in: Atom PDF