Project

General

Profile

Bug #4268

Portal announcements - lost features

Added by Yannick Warnier over 7 years ago. Updated over 7 years ago.

Status:
Feature implemented
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
30/01/2012
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

There was both a "Read more" and a slider in the previous dev or stable releases. What happened to them? Should come back before 1.9


Files

guest_visibility.patch (961 Bytes) guest_visibility.patch Marko Kastelic, 18/05/2012 08:39

Associated revisions

Revision fb6bb16c (diff)
Added by Julio Montoya over 7 years ago

Adding link "more" in system announcements if content is bigger than 500 see #4268

Revision 023ee482 (diff)
Added by Julio Montoya over 7 years ago

Should fix bug when showing "guest" portal news see #4268

History

#1

Updated by Julio Montoya over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
#2

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)
  • % Done changed from 0 to 70
#3

Updated by Yannick Warnier over 7 years ago

  • Target version changed from 1.9 Stable to 1.9 Beta
#4

Updated by Marko Kastelic over 7 years ago

link is back but the target page does not contain full text as expected
edit: for the guests only. When user is logged to the portal, show more works as expected.
could the sliding be disabled when there is only one announcement ?

#5

Updated by Marko Kastelic over 7 years ago

anonymous user can see full portal news

#6

Updated by Michela Mosquera over 7 years ago

  • Status changed from Needs more info to Bug resolved
  • Assignee set to Julio Montoya
  • % Done changed from 70 to 100

Tried both anonymous and connected user. Worked in both cases (3 pages of text for the full piece of news).

Marko, please register the request for removing the slider as another task (it will be implemented after 1.9 because right now we have to much to include new requests, but it is a good suggestion!)

#7

Updated by Marko Kastelic over 7 years ago

Michela Mosquera wrote:

Tried both anonymous and connected user. Worked in both cases (3 pages of text for the full piece of news).

do not agree.
Will somebody do simple test again : 1 new portal news (3 pages as said Michela). assign visibility to the guests only or to the guest+teacher only and not for students (code from news_list.php https://support.chamilo.org/public/chamilo-classic/file/cb2e112f2d40/news_list.php#l17 does not separate visibility for student/guest, but code from SystemAnnouncementManager class::display_announcements_slider https://support.chamilo.org/public/chamilo-classic/file/cb2e112f2d40/main/inc/lib/system_announcements.lib.php#l578 does) so we actualy use visibility guest=student !!!! When we set visibility for guest AND student everything is fine otherwise ...
patch was attached earlier.

edit: just added Lorem Ipsum news to chamilodev portal. Look for yourself.

#8

Updated by Yannick Warnier over 7 years ago

  • Status changed from Bug resolved to Assigned
  • % Done changed from 100 to 50

OK, this later case is a bit more detailed. Thanks (I hadn't seen anything that precise about visibility change in earlier posts). Will check it out.

#9

Updated by Marko Kastelic over 7 years ago

Yannick Warnier wrote:

OK, this later case is a bit more detailed.

Sorry for that, will try to improve myself for the next time.
will never be checking the option for myself if i had not try to distinguish informational/advertising part from the productional/educational for one of the ours internal presentations. There's guest visibility crucial; especialy for the organisations where education is not the primary activity. I will try to note down some additional suggestions for the portal home when i found some time (not before 1.9 final at least).

#10

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Marko Kastelic
  • % Done changed from 50 to 90

I sent the fix

#11

Updated by Marko Kastelic over 7 years ago

ok, it's working now. You changed a little more: add(change) delimited section headers and removed the toolbar.

I'm returning task to you for closing

and adding some opinions: portal news details page doubles infomations that we are on portal news page : breadcrumb and section header. Removed toolbar prevents from having in-page back link (and possible next, previous link) that resignates from (current?) UI philosophy.

#12

Updated by Marko Kastelic over 7 years ago

  • Assignee changed from Marko Kastelic to Julio Montoya
#13

Updated by Julio Montoya over 7 years ago

  • Status changed from Needs more info to Feature implemented
  • Assignee deleted (Julio Montoya)
  • % Done changed from 90 to 100

Marko Kastelic wrote:

ok, it's working now. You changed a little more: add(change) delimited section headers and removed the toolbar.

I'm returning task to you for closing

and adding some opinions: portal news details page doubles infomations that we are on portal news page : breadcrumb and section header. Removed toolbar prevents from having in-page back link (and possible next, previous link) that resignates from (current?) UI philosophy.

Closing the task, is true that we need to discused those UI issues. That problem is everywhere not just the portal news, a new task and a proposal will be welcome :)

Also available in: Atom PDF