Project

General

Profile

Bug #4142

Wrong error message when uploading a too big SCORM package

Added by Hubert Borderiou about 8 years ago. Updated over 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
14/12/2011
Due date:
% Done:

80%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,
I wanted to upload a scorm package of 50Mo.
In the php.ini file, I'm allowed to upload a file of 10Mo or less.

The error message I've got when I upload my SCORM package is :
"The package you are trying to upload has an unknown format. Please check it uses one of the supported formats."


Files

lp_upload.php (7.2 KB) lp_upload.php Yoselyn Castillo, 16/08/2012 16:28
learnpath.class.php (434 KB) learnpath.class.php Yoselyn Castillo, 22/08/2012 18:19
lp_upload.php (6.99 KB) lp_upload.php Yoselyn Castillo, 22/08/2012 18:19
upload-scorm-big.gif (18.9 KB) upload-scorm-big.gif Yoselyn Castillo, 11/09/2012 19:24

Associated revisions

Revision 5e98bde2 (diff)
Added by Yoselyn Castillo over 7 years ago

Checking file size when importing scorm files see #4142

History

#1

Updated by Yannick Warnier over 7 years ago

  • Target version set to 1.9 Beta
#2

Updated by Yannick Warnier over 7 years ago

  • Target version changed from 1.9 Beta to 1.9 RC1
#3

Updated by Laurent Opprecht over 7 years ago

  • Status changed from New to Needs testing
  • Assignee set to Hubert Borderiou
  • % Done changed from 0 to 100

Message updated

#4

Updated by Hubert Borderiou over 7 years ago

Hi,

the scorm file quota doesn't seem to be the same than the document quota.
Scorm files are unzipped in folder courses/COURSPOURLP/scorm
If you add a too big scorm file for the scorm quota, you've got the message "There is not enough space left in this course to uncompress the current package." That's fine. But where can we change the scorm file quota ?

If your php.ini (post_max_size and upload_max_filesize) prevent you from downloading the scorm file (because it is too big) you still have the message "The package you are trying to upload has an unknown format. Please check it uses one of the supported formats."

#5

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs testing to New
  • Assignee deleted (Hubert Borderiou)
  • Target version changed from 1.9 RC1 to 1.9.2

The SCORM quota is the same as the course documents quota.
Still missing the message change but not urgent, so moving to 1.9.2 (let's focus on the really important stuff for now)

#6

Updated by Yoselyn Castillo over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Yoselyn Castillo
#7

Updated by Yoselyn Castillo over 7 years ago

upload this file. It fixes messages when you are trying to upload a file bigger than filesize allowed in php.ini configuration

#8

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yoselyn Castillo
  • % Done changed from 100 to 80

I think that you should validate inside the import_package() function (in scorm.class.php and aicc.class.php), you should also check the space available in the course. you can check the file before uploading with the function in document.lib.php

process_uploaded_file($files['file'], $show_output);
#9

Updated by Yoselyn Castillo over 7 years ago

  • Assignee changed from Yoselyn Castillo to Julio Montoya

the validation in lp_upload.php occurs before calling import_package, i mean, if the post_max_size and upload_max_filesize are shorter than size of the package import package doesn't occur. Do you think it is necessary validate inside those functions?

#10

Updated by Julio Montoya over 7 years ago

  • Assignee deleted (Julio Montoya)

Check the space available in the course too, you could add that functionality in the learnpath class because both classes scorm, aicc are using the learnpath class.

#11

Updated by Yoselyn Castillo over 7 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Yoselyn Castillo

ok, i am going to check

#12

Updated by Yoselyn Castillo over 7 years ago

upload these file. I have tested in my local pc

#13

Updated by Julio Montoya over 7 years ago

  • Assignee changed from Julio Montoya to Yoselyn Castillo

I just sent those fixes, that's a lot much better!

#14

Updated by Yoselyn Castillo over 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Yoselyn Castillo)
#15

Updated by Yoselyn Castillo over 7 years ago

When the scorm package is bigger than the size allowed in php.ini configuration, the message has been sent to "The file is too big to upload." See the attachment upload-scorm-big.gif

Also available in: Atom PDF