Project

General

Profile

Bug #4047

Assessment (gradebook) modification

Added by Hubert Borderiou over 9 years ago. Updated almost 9 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
14/11/2011
Due date:
% Done:

80%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Hi,
some change to do to assessment page.

change the vocabulary for integer field entries

For folder, (you may change the Edit pen icon to the left of the icon bar) you have Total weight and Minimum certification score
For categories (stil folder ?) you have Total weight
For classroom activities you have Weight and Maximum score
For links you have Weight

Some are %age and the other not. It is very confusing.
Add explanation or ajax helper for users to fill the weight of exercices.

Review the List view page.


Files

2011-11-15_0949.png (45.3 KB) 2011-11-15_0949.png gradebook/index.php Hubert Borderiou, 15/11/2011 10:01
2011-11-15_0952.png (40.3 KB) 2011-11-15_0952.png linear view Hubert Borderiou, 15/11/2011 10:01
gradebook-bug.png (35.5 KB) gradebook-bug.png Yannick Warnier, 25/07/2012 06:49

Associated revisions

Revision 5a75c4ff (diff)
Added by Julio Montoya over 9 years ago

Should fix some bugs when using multiple gradebooks in a course see #4047 (partial needs some cleaning for the scores)

Revision d42b0566 (diff)
Added by Julio Montoya over 9 years ago

Sending more information in gradebook result table see #4047

Revision 1e6cb79e (diff)
Added by Julio Montoya almost 9 years ago

Fixing gradebook "flat view" when there are no categories see #4047

Revision 179f556e (diff)
Added by Julio Montoya almost 9 years ago

Should fix some gradebook bugs see #4047

Revision 6699dc60 (diff)
Added by Julio Montoya almost 9 years ago

Should fix fatal error see #4047

Revision 58612851 (diff)
Added by Yannick Warnier almost 9 years ago

Interface improvements(?) for gradebook - refs #4047

Revision 5304b423 (diff)
Added by Yannick Warnier almost 9 years ago

Fix visible icon when corresponding option not enabled - refs #4047

History

#1

Updated by Julio Montoya over 9 years ago

  • Status changed from New to Assigned
  • % Done changed from 0 to 40

Thanks for reporting, I'm working on it

#2

Updated by Julio Montoya over 9 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)
  • % Done changed from 40 to 70
#3

Updated by Hubert Borderiou over 9 years ago

Hi,
the gradebook/index.php page is ok ^^
(see attached)
but there are still issue in the linear view page, I think
(see attached)
In this example, the score of classroom activity is right, according to the ratio of 20/100 of the global score.
But the score of Quiz is very difficult to understand, because it is the global quiz score without the ratio of the activity for the assessment.

#4

Updated by Julio Montoya over 9 years ago

I sent more details in the table so it will be more clear now (needs some cleanup because there are a lot of numbers)

http://code.google.com/p/chamilo/source/detail?r=5ac3f4106e11193ee6deda7ff04e08377a8fd177&repo=classic

#6

Updated by Julio Montoya over 9 years ago

  • Target version set to 1.9 Stable
#7

Updated by Yannick Warnier about 9 years ago

  • Target version changed from 1.9 Stable to 1.9 Beta
#8

Updated by Yannick Warnier about 9 years ago

#3630 also contains a few usability improvements.

There are still problems right now:
  • when creating 3 external exams and adding the corresponding students results, the "flat view" is empty (seems like it doesn't understand the fact that it has no assessment category)
  • then I create a category and try to move one of the external assessments inside it, and I get:
    Fatal error: Cannot use string offset as an array in /var/www/chamilo/main/gradebook/lib/fe/gradebooktable.class.php on line 262 Call Stack: 0.0021 1201872 1. {main}() /var/www/chamilo/main/gradebook/index.php:0 0.4839 31680512 2. SortableTable->display() /var/www/chamilo/main/gradebook/index.php:906 0.4839 31680600 3. SortableTable->return_table() /var/www/chamilo/main/inc/lib/sortable_table.class.php:209 0.4839 31680768 4. SortableTable->get_table_html() /var/www/chamilo/main/inc/lib/sortable_table.class.php:217 0.4906 32401072 5. GradebookTable->get_table_data() /var/www/chamilo/main/inc/lib/sortable_table.class.php:595 
#9

Updated by Yannick Warnier about 9 years ago

  • Target version changed from 1.9 Beta to 1.9 RC1
#10

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Julio Montoya
#11

Updated by Julio Montoya almost 9 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)
  • % Done changed from 70 to 80

Should be fixed now

#12

Updated by Yannick Warnier almost 9 years ago

Yannick Warnier wrote:

  • when creating 3 external exams and adding the corresponding students results, the "flat view" is empty (seems like it doesn't understand the fact that it has no assessment category)

This one is fixed.
However, if I don't use an evaluation "category" and I have thre external exams, I cannot edit the scoring system (main/gradebook/gradebook_scoring_system.php?cidReq=A&id_session=0&gidReq=0&selectcat=1). The pages (in Spanish) says "Editar las reglas de puntuaciĆ³n" but nothing more.
The rest of the page is blank. It should show options to edit grades (say "between 0 and 50 = bad", etc).
Creating an evaluation category doesn't help. I tried changing a few options in the admin but that didn't have any apparent effect on this page.

#13

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Needs testing to Assigned
  • Assignee set to Julio Montoya
  • % Done changed from 80 to 70

Yannick Warnier wrote:

  • then I create a category and try to move one of the external assessments inside it, and I get: [...]

This one has been fixed as well

#14

Updated by Yannick Warnier almost 9 years ago

I've changed the setting "Enable configuration of grades" (or something like that, I'm translating from Spanish here) and the blanck page gave me the right options.

If this option isn't enabled, then the "podium" icon shouldn't appear on main/gradebook/index.php. That would be enough to fix.

#15

Updated by Yannick Warnier almost 9 years ago

Also, the +/- icon for the evaluation category doesn't work (it doesn't hide the contents).

Finally, the icons of the elements embedded into one category should be aligned a little bit more to the right (see screenshot).

#16

Updated by Julio Montoya almost 9 years ago

I don't find that option "Enable configuration of grades"

The podium is hidden when this setting is off

teachers_can_change_score_settings

#17

Updated by Julio Montoya almost 9 years ago

you are right the +/- doesn't work anymore

#18

Updated by Julio Montoya almost 9 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)
  • % Done changed from 70 to 80

All the things mentioned in your screenshot are fixed except for comment 16

#19

Updated by Yannick Warnier almost 9 years ago

  • Target version changed from 1.9 RC1 to 1.9 Stable
#20

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Needs testing to Assigned
  • Assignee set to Julio Montoya

The setting that allowed me to modify the grades was gradebook_score_display_custom[my_display_custom], not the one you mention.

As such, I think both gradebook_score_display_custom[my_display_custom] and teachers_can_change_score_settings should be enabled in order to show the podium icon.

#21

Updated by Yannick Warnier almost 9 years ago

I think I understand where the problem is: I was testing as admin, so I saw the icon, but the content of that screen wa empty. It would be better to check the other setting too, so the admin doesn't see this icon either (it doesn't make sense if it sends him to an mpty page anyway).

#22

Updated by Yannick Warnier almost 9 years ago

Seems like the previous problems are solved but...

I just had this error:

Fatal error: Cannot use string offset as an array in /var/www/chamilo/main/gradebook/lib/fe/gradebooktable.class.php on line 289 Call Stack: 0.0002 658696 1. {main}() /var/www/chamilo/main/gradebook/index.php:0 0.1251 11016120 2. SortableTable->display() /var/www/chamilo/main/gradebook/index.php:903 0.1251 11016208 3. SortableTable->return_table() /var/www/chamilo/main/inc/lib/sortable_table.class.php:213 0.1251 11016376 4. SortableTable->get_table_html() /var/www/chamilo/main/inc/lib/sortable_table.class.php:221 0.1272 11284704 5. GradebookTable->get_table_data() /var/www/chamilo/main/inc/lib/sortable_table.class.php:599 

...while trying to add a exam out of any of the two categories I have (based on the case of my earlier screenshot).

I just reproduced it. The procedure is:
  • create a category (weight 100)
  • create an external exam inside this category (relative weight 20 or something like that)
  • now create an external exam out of this category (in the "default") (with a weight of 20 or so)
  • you get the error

Also, in the main page, it doesn't make sense to have the "%" sign next to the different weights ("Ponderation" column). Please remove the sign.

#23

Updated by Julio Montoya almost 9 years ago

I can't reproduce that fatal error

#24

Updated by Julio Montoya almost 9 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier
  • Target version changed from 1.9 Stable to 1.9 RC1
#25

Updated by Julio Montoya almost 9 years ago

should be fixed now

#26

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Needs more info to Assigned
OK. Works for me. I'm doing two improvements myself now:
  1. reduce the "normal-message" (blue box) to one line with an edit icon next to it
  2. remove the double occurence of the messages saying "Total weight must not be more than 100" and "The sum of all weights of activities must be 100" (I think they mean the same and the second one is enough) and add the percentage icon next to it to go and fix that (otherwise the relationship is not clear between the message and what one can do about it)
#27

Updated by Yannick Warnier almost 9 years ago

I'm also taking the global setting stuff in charge.

#28

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Assigned to Bug resolved
  • Assignee changed from Yannick Warnier to Julio Montoya

Done

Also available in: Atom PDF