Project

General

Profile

Bug #3855

Don't send e-mail to inactive accounts

Added by Bas Wijnen almost 9 years ago. Updated almost 8 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
31/08/2011
Due date:
% Done:

80%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Accounts which are set to inactive still receive e-mail with announcements from Chamilo when their account is (was) subscribed to the course where the announcement is made. This shouldn't happen; being inactive, they aren't allowed to log in and shouldn't be bothered with e-mails. Especially because they can no longer unsubscribe, being unable to log in.

Associated revisions

Revision 24064844 (diff)
Added by Julio Montoya over 8 years ago

Send announcements only to active users see #3855

Revision 5186a775 (diff)
Added by Julio Montoya almost 8 years ago

Should fix bug that enables inactive users to ask email passwords see #3855

Revision 4fa28caa (diff)
Added by Julio Montoya almost 8 years ago

Updating variable see #3855

History

#1

Updated by Julio Montoya over 8 years ago

  • Status changed from New to Needs more info
  • % Done changed from 0 to 50
#2

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.9 Stable to 1.9 Beta
#3

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.9 Beta to 1.9 RC1
#4

Updated by Yannick Warnier almost 8 years ago

  • Assignee set to Eric Petitdemange
#5

Updated by Eric Petitdemange almost 8 years ago

I created a confusion of the platform:
i/i (inactive learner) was active.
As administartor I ticked BOTH inactive yes and send email yes (inside the profile).

The email was sent.
The account is inactive is the message I get from the platform.
I think taht as soon as the trainee is set to inactive, no email should be sent at all ;)

The trainee can go to "Gestion" course through the hottest from main page, I suppose this course is opened so accessible for Anonymous. The other courses are visible but not accessible, thisis good.

I register the inactive trainee to a course not visible from hottest : no access => OK
I register to a course visible on hottest, but not opened : No access => OK ; vote impossible => OK
Annoucement not receive - Potential issue, as the annoucement was received twice with the same name (admin) instead of 1 coursenligne and 1 apprenant (I registered coursenligne, apprenant and inactif in this cours QRM global)

#6

Updated by Eric Petitdemange almost 8 years ago

A new test :)

As inactive (using i//i), if I click on I lost my password, there is an error message,saying that the email can't be sent, BUT, I received this by email :
Dear user :
You have asked to reset your password. If you did not ask, then ignore this mail.

-----------------------------------------------
Your registration data :
Username : i
Click here to recover your password : http://chamilodev.beeznest.com/main/auth/lostPassword.php?reset=c2f2211308db3278189b2f75b7127ddc&id=56
-----------------------------------------------

Your password is encrypted for security reasons. Thus, after pressing the link an e-mail will be sent to you again with your password.

Yours sincerely,
John Doe
Portal Admin - My campus

I follow the link and get
Portal unable to send email contact Administration.

but got :
This is your information to connect to http://chamilodev.beeznest.com/

Your registration data :
Username : i
Pass : GvQt6Aqa

The account is however still inactive so no big issue ;)

#7

Updated by Julio Montoya almost 8 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Eric Petitdemange to Julio Montoya
#8

Updated by Julio Montoya almost 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)

now you can't ask for a password if your user is inactive

#9

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Julio Montoya
  • % Done changed from 50 to 70

This one seems good to me.
As far as I could see, the language variable $SystemUnableToSendEmailContact for the "cannot deliver" message should include the contact as an "X" and seems to only be used in the login and lost password processes.
Probably changing it wouldn't have much impact on the code, but would definitely make it better. Something like:
"This platform was unable to send the email. Your account has been blocked. Please contact %s for more information."

#10

Updated by Julio Montoya almost 8 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Julio Montoya)
  • % Done changed from 70 to 80

Variable added and code was updated

#11

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs testing to Bug resolved
  • Assignee set to Julio Montoya

good for me

Also available in: Atom PDF