Project

General

Profile

Bug #3729

Warn about failure to create backup

Added by Bas Wijnen almost 9 years ago. Updated about 8 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Yoselyn Castillo
Category:
-
Target version:
Start date:
18/07/2011
Due date:
% Done:

90%

Estimated time:
10.00 h
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

If the archive/ directory is not writable, no backups can be made. To make matters worse, there is no warning, so the users thinks he has made a backup, but can't download it.

Related, if there is a problem like this, there should be a huge warning immediately after installing, so that it can be fixed before it leads to problems.

Associated revisions

Revision 13fd8d0f (diff)
Added by Julio Montoya almost 9 years ago

Minor fixing get_lang to Teacher fixes #3729

Revision cb8fdfeb (diff)
Added by Julio Montoya over 8 years ago

Adding message if archive is not writable see #3729

Revision d58c60ff (diff)
Added by Julio Montoya about 8 years ago

blocking the creation of backups if the archive folder is not writable see #3729

History

#1

Updated by Yannick Warnier almost 9 years ago

  • Target version set to 1.8.8.4
#2

Updated by Julio Montoya almost 9 years ago

  • Status changed from New to Needs testing
  • % Done changed from 0 to 90

Applied in changeset r15115.

#3

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Needs testing to New
  • % Done changed from 90 to 0

the commit doesn't seem to have any relationship with the task...

#4

Updated by Julio Montoya almost 9 years ago

You could check main/admin/system_status.php as an admin, You can see there some warnings.

We should show that info in the admin settings a red icon next to the "System Status" link with a number.
Telling the admin that there's a problem in the portal.
Something like:

System status (3!)

In fact we should work in a notification class because right now we have to hack the code in order to show notifications to users ...

#5

Updated by Julio Montoya almost 9 years ago

  • Status changed from New to Needs more info
#6

Updated by Yannick Warnier almost 9 years ago

  • Status changed from Needs more info to New
  • Target version changed from 1.8.8.4 to 1.9 Stable

Bah, let's move this to the next version, it's not that urgent and I'm definitely not motivated enough to go through the notification class right now but yes, we should find something like that.

The notification class has been described in more detail in some task or wiki around here, but it did not include anything like putting an alert for system warnings.

#7

Updated by Julio Montoya over 8 years ago

  • Status changed from New to Needs more info
  • % Done changed from 0 to 50

I just added a warning message in the main/admin/index.php like the "main/install message"

#8

Updated by Yannick Warnier about 8 years ago

  • Assignee set to Yoselyn Castillo

To review, making the permissions not writeable to trigger the error message. The error message should be translated already (if you use Spanish, it should be in Spanish) otherwise please report here.

#9

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.9 Stable to 1.9 Beta
#10

Updated by Yoselyn Castillo about 8 years ago

It doesn't work for me. If the archive/ directory is not writable, no backups can be made but it doesn't appear any warning.

#11

Updated by Julio Montoya about 8 years ago

I'm adding a warning message in the main/coursecopy/create_backup.php
I'm using a new function called api_check_archive_dir() that blocks the entire page if the archive page is not writable ...

#12

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.9 Beta to 1.9 RC1
#13

Updated by Yoselyn Castillo about 8 years ago

  • Status changed from Needs more info to Bug resolved
  • % Done changed from 50 to 90

It works fine, if the archive directory is not writeable, it appears warnings depending on the language of the course.

Also available in: Atom PDF