Project

General

Profile

Bug #3702

Social network invitations are sent as anonymous

Added by Yannick Warnier over 8 years ago. Updated about 5 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
Global / Others / Misc
Target version:
Start date:
15/07/2011
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Apparently invitations sent by e-mail are sent as the anonymous user or something like that (blurry report so far).


Related issues

Related to Chamilo LMS - Bug #7394: Le nom de l'admin est utilisé lors de l'envoie de message par l'outil "Message"Bug resolved12/11/2014

Actions

Associated revisions

Revision a8181c19 (diff)
Added by Yoselyn Castillo about 5 years ago

changing invitation sender-refs #3702

Revision 27096e2c (diff)
Added by Yoselyn Castillo about 5 years ago

fixing code when sending invitation -ref #3702

Revision 15abc597 (diff)
Added by Yoselyn Castillo about 5 years ago

fixing code when sending invitation -ref #3702

Revision d6a6d6ae (diff)
Added by Yannick Warnier about 5 years ago

Fix social network sender to use no-reply address if defined - refs #3702

History

#1

Updated by Julio Montoya over 8 years ago

  • Status changed from New to Needs more info
  • % Done changed from 0 to 20

need more feedback here, probably already fixed in 1.8.8.4 i sent a fix to the notification class:

http://code.google.com/p/chamilo/source/detail?r=e9d25d80e4d203fd8485c00222d968c8e688448e&repo=classic

#2

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.8.8.4 to 1.9 Stable

Moving to next version for feedback (it's a customer feedback, so it's going to take a while to get an answer)

#3

Updated by Yannick Warnier over 7 years ago

  • Target version changed from 1.9 Stable to 1.9 Beta
#4

Updated by Yannick Warnier over 7 years ago

  • Target version changed from 1.9 Beta to 1.9 RC1
#5

Updated by Yannick Warnier over 7 years ago

OK, got it. The sender of the e-mail should still be the campus (the "no-reply" address configured in the admin section, if it exists), but there should be a message saying to the person receiving the e-mail that he should click a link to get to the message and answer. Currently, it is unclear. Take the example of Facebook (but try making it full-text instead of HTML) notifications.

#6

Updated by Yannick Warnier over 7 years ago

And this isn't fixed by the commit mentionned, by the way.

#7

Updated by Yannick Warnier about 7 years ago

  • Target version changed from 1.9 RC1 to 1.9.2

Moving this to 1.9.2. I don't have the right information at hand on what is exactly the right thing to do. Adding Jérôme and Bas as observers for recommendations.

#8

Updated by Yannick Warnier about 7 years ago

  • Target version changed from 1.9.2 to 1.9.4
#9

Updated by Yannick Warnier almost 7 years ago

  • Target version changed from 1.9.4 to 2.0
#10

Updated by Yoselyn Castillo over 5 years ago

  • Status changed from Needs more info to Assigned
  • Assignee set to Yoselyn Castillo
#11

Updated by Yoselyn Castillo over 5 years ago

checking this..

#12

Updated by Yoselyn Castillo over 5 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Yoselyn Castillo to Yannick Warnier

I have tried in stable.chamilo.org
I have sent an invitation to a user. The invitation was successfully sent. The email was sent by yoselyn castillo(as sender) it is not anonymous. What i have to do? Keep this sender or back to anonymous? In my opinion we should make sender as anonymous(no'reply address as you said).
Let me know

#13

Updated by Yoselyn Castillo about 5 years ago

Yoselyn Castillo wrote:

I have tried in stable.chamilo.org
I have sent an invitation to a user. The invitation was successfully sent. The email was sent by yoselyn castillo(as sender) it is not anonymous. What i have to do? Keep this sender or back to anonymous? In my opinion we should make sender as anonymous(no'reply address as you said).
Let me know

What is the decision, yannick??

#14

Updated by Yannick Warnier about 5 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Yoselyn Castillo

Hi Yoselyn,

Yes, please set it back to the "no-reply" address of the chamilo campus, or the address configured in the admin section if there is no "no-reply" address.

#15

Updated by Yannick Warnier about 5 years ago

  • Target version changed from 2.0 to 1.9.10
#16

Updated by Yoselyn Castillo about 5 years ago

  • % Done changed from 20 to 70

change was sent to https://github.com/chamilo/chamilo-lms/pull/330
It is necessary to be checked, cause in my local pc i can not try sending emails. So it needs to be checked in stable.chamilo.org

#17

Updated by Yannick Warnier about 5 years ago

  • Status changed from Assigned to Needs testing
  • Assignee deleted (Yoselyn Castillo)
#18

Updated by Yannick Warnier about 5 years ago

  • Category set to Global / Others / Misc
  • Assignee set to Yoselyn Castillo

I have merged your change. Please review on stable.chamilo.org and report.

#19

Updated by Yannick Warnier about 5 years ago

  • % Done changed from 70 to 90
#20

Updated by Yannick Warnier about 5 years ago

  • Status changed from Needs testing to Assigned
  • Assignee changed from Yoselyn Castillo to Yannick Warnier

OK, I tried it on stable.chamilo.org but it didn't work. I set a "no-reply" address of "" but I received the following mail:

De:    John Doe <webmaster@beeznest.com>
Reply-to:    John Doe <webmaster@beeznest.com>
À:    Yannick Warnier <y@beeznest.com>
Sujet:    Invitation
Date:    Mon, 13 Oct 2014 02:07:54 +0200 (12/10/14 19:07:54)

You have a new invitation from John Doe

dfvdfvs

See invitation
You have received this notification because you are subscribed or involved in it to change your notification preferences please click here: https://stable.chamilo.org/main/auth/profile.php
#21

Updated by Yannick Warnier about 5 years ago

  • Status changed from Assigned to Bug resolved
  • Assignee changed from Yannick Warnier to Yoselyn Castillo
  • % Done changed from 90 to 100

I've fixed the last bit (constants were missing a self:: prefix).

Also available in: Atom PDF