Project

General

Profile

Bug #3641

Teacher missing from group member selection list

Added by Bas Wijnen about 8 years ago. Updated almost 7 years ago.

Status:
Bug resolved
Priority:
High
Assignee:
-
Category:
-
Target version:
Start date:
22/06/2011
Due date:
% Done:

30%

Estimated time:
1.00 h
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Since the upgrade of 1.8.7 to 1.8.8.2, I noticed that teachers are no longer in the list of people who can be group member or group manager. This is a result of calling fill_groups_list, which removes all non-students. Here's a fix in understandable format (I hope), a computer-readable patch will follow after I manage to import the repository.

This is a hack; I haven't looked at other things calling fill_groups_list. Possibly they don't need to filter either, and no option is required (but instead the filter_only_students call is moved to the places where it is required). Personally I think that would be cleaner, because the name fill_groups_list doesn't suggest that the teachers are omitted. In fact, this bug shows that it isn't clear that they are, and people expect to get them in the list when calling this function.

So if you agree, I'll write a patch to do something else than below, namely remove the line from fill_groups_list, and add it to callers which need it (if any).

main/group/group_edit.php:220
- $complete_user_list = GroupManager :: fill_groups_list($current_group['id']);
+ $complete_user_list = GroupManager :: fill_groups_list($current_group['id'], true);
inc/lib/groupmanager.lib.php:1534+1591
- public static function fill_groups_list ($group_ids) {
+ public static function fill_groups_list ($group_ids,$with_tutors=false) {
+ if (!$with_tutors)
$complete_user_list = self :: filter_only_students($complete_user_list);

History

#1

Updated by Marko Kastelic about 8 years ago

related to:
http://support.chamilo.org/issues/1949

should be fixed

#2

Updated by Bas Wijnen about 8 years ago

This is indeed related, but not the same.

While it is acceptable to omit teachers as possible group members, it is a problem to omit them from the list of group tutors.

The thing that is fixed is that people who are teachers, but who are students in the course will indeed behave as students in the group selection. What is not fixed is that both the list of tutors and the list of members cannot contain course tutors. This means that course teachers cannot be assigned as group tutor. It may make sense to disallow students to be group tutors (but it may (in rare cases?) be useful to allow this). However, teachers should normally be group tutors, so that must be possible.

#3

Updated by Marko Kastelic about 8 years ago

quote from issue 1949:

is ok for me that teachers can't be tutors they are already teachers and can modify everything in the course

but i can see where is your the problem (?): if you enroll the platform user as teacher to the course, thus teacher cannot 'own' the group, so cannot be listed in the group list, group cannot be flagged as 'my group', but can still access/modify any of the group content.

so, you want one course(subject) with many equivalent teachers(lecturers) that are 'sharing' the same course content?

Can you please give us a scenario (see samples below) for the execution? From your description i can see what you want, but can't understand why.

samples:
a) one course, one (main) teacher, extendend rights for tutors/assistants (empowerment for ordinary course users, that can also be teachers on the platform)
b) one course/subject, many equivalent teachers, sequential execution of the lectures as : beggining with 1st teacher, than 2nd, than 3rd ,... in closed thematics blocks for full course execution time (so every of then takes 1/3 of available time), but each of them is at the same time a tutor of his/her own group for the full time of the course. /i will use a session with 2 to 4 courses, depending on organisation of the execution: 1 common, other for 'groups /
c) ...

yannick ?

#4

Updated by Bas Wijnen about 8 years ago

There are two situations in our school where this would be useful:

c. For a certain level, there are say 60 students. This means two classes of 30 students, each with their own lectures from their own teacher (which may or may not be the same person for both groups). The topics are the same, and it is useful to create a single course for them. However, sometimes one teacher wants to do things that the other doesn't. For such cases, we use groups in the course; one per class. It seems logical to show the class's teacher as the tutor for their class.

d. Our students have to do a large project at the end, which is divided between subjects. We have created a single course for "physics projects", which contains all groups of (2 or 3) students which do the project on physics. Each of those groups has a tutor, which is one of the physics teachers. The most important thing in this case is that it is clear who the tutor is, and this seems like the right place to show this.

Also, in both cases it is troublesome that the teacher doesn't get items (in the drop box, for example) that are directed to the group.

While I think these are both good use cases, which deserve support, I also welcome suggestions of how to organise things differently in Chamilo to handle these things optimally.

#5

Updated by Yannick Warnier almost 8 years ago

  • Target version set to 1.8.8.4
#6

Updated by Julio Montoya almost 8 years ago

  • Status changed from New to Needs more info

Bas Wijnen wrote:

There are two situations in our school where this would be useful:

c. For a certain level, there are say 60 students. This means two classes of 30 students, each with their own lectures from their own teacher (which may or may not be the same person for both groups). The topics are the same, and it is useful to create a single course for them. However, sometimes one teacher wants to do things that the other doesn't. For such cases, we use groups in the course; one per class. It seems logical to show the class's teacher as the tutor for their class.

d. Our students have to do a large project at the end, which is divided between subjects. We have created a single course for "physics projects", which contains all groups of (2 or 3) students which do the project on physics. Each of those groups has a tutor, which is one of the physics teachers. The most important thing in this case is that it is clear who the tutor is, and this seems like the right place to show this.

Also, in both cases it is troublesome that the teacher doesn't get items (in the drop box, for example) that are directed to the group.

While I think these are both good use cases, which deserve support, I also welcome suggestions of how to organise things differently in Chamilo to handle these things optimally.

You can create 2 sessions with the same course related. If you want 2 courses with the same "base" but the teacher/coach will add/remove what he want.

#7

Updated by Yannick Warnier almost 8 years ago

Bas, are you satisfied with this solution or do you need something different?

#8

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs more info to Bug resolved

Automatically closing

#9

Updated by Jan Beerden over 7 years ago

We are using Chamilo 1.8.8.4 and stil have this bug.
A group under a course cannot have a teacher as group tutor.

We also have a group with 3 tutors from before the upgrade to 1.8.8.4, but when I go to the settings the list with group tutors contains 3 "empty" items.

#10

Updated by Jan Derriks almost 7 years ago

August 2012, installed LMS1.9 and one of the first complaints from teachers: I cannot add me and collegues in a group! So I installed this patch again.

Is it so hard to select the students from the list and keep the teachers in?

We have courses/projects where students enroll themselves and teachers are in groups also (to make announcements to seperate teacher groups).

I vote for default "allow teachers in groups" code. It is easy to change the "true" into "false". Maybe another admin config switch?

Also available in: Atom PDF