Bug #3544
Remove fix.css and other stylesheets loaded "post-style"
Description
In 1.8.8.2, we added a series of CSS "fixes" which are applied "after" the normal stylesheets have been loaded. This goes against the logic of CSS but I didn't realize it at the time. Stylesheets are "cascading" by nature in CSS, which means they can be redefined to customize one basic style. However, "fixing" them after that customization is blocking possibilities to customize it.
Instead, we should have a common base and, on top of this common base, apply the customizations inside the stylesheets themselves.
Right now, adding a new stylesheet (based on the "chamilo" style) to one portal means: copying the chamilo style to a new directory, possibly updating fix_chamilo.css (root file, not accessible through web CSS upload) to customize the logo space, and then still modify (not accessible either through web upload) the main/inc/header.inc.php. This is not acceptable as it is and will probably get us some very angry comments from administrators.
Associated revisions
Removing the "fix" CSS files see #3544
Fixing include base_chamilo.css calls see #3544
History
Updated by Julio Montoya almost 10 years ago
Updated by - Status changed from New to Assigned
- Assignee set to Julio Montoya
yeah I also had a bad feeling while editing a theme for tests (unidad editorial).
There should be only a base.css, base_chamilo.css, and base_classic.css
And a rework of all CSS in order to delete repetitions.
Updated by Julio Montoya almost 10 years ago
- % Done changed from 0 to 70
lot of CSS changes were sent
fix.css and fix_chamilo were deleted there are only the base.css base_classic.css and base_chamilo.css
Updated by Julio Montoya almost 10 years ago
- Status changed from Assigned to Needs more info
- Assignee changed from Julio Montoya to Yannick Warnier
I reduce the chamilo_XXX default.css files from 4500 lines to 260 lines all the rest is in the base_chamilo.css or base.css
Updated by Julio Montoya almost 10 years ago
- % Done changed from 70 to 80
Removing base_chamilo.css calls in php code and including in the default.css files seee
Fixing chamilo_X themes see #3544