Project

General

Profile

Bug #3544

Remove fix.css and other stylesheets loaded "post-style"

Added by Yannick Warnier about 8 years ago. Updated almost 8 years ago.

Status:
Bug resolved
Priority:
Urgent
Category:
-
Target version:
Start date:
02/06/2011
Due date:
30/06/2011
% Done:

80%

Estimated time:
2.00 h
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
5

Description

In 1.8.8.2, we added a series of CSS "fixes" which are applied "after" the normal stylesheets have been loaded. This goes against the logic of CSS but I didn't realize it at the time. Stylesheets are "cascading" by nature in CSS, which means they can be redefined to customize one basic style. However, "fixing" them after that customization is blocking possibilities to customize it.

Instead, we should have a common base and, on top of this common base, apply the customizations inside the stylesheets themselves.

Right now, adding a new stylesheet (based on the "chamilo" style) to one portal means: copying the chamilo style to a new directory, possibly updating fix_chamilo.css (root file, not accessible through web CSS upload) to customize the logo space, and then still modify (not accessible either through web upload) the main/inc/header.inc.php. This is not acceptable as it is and will probably get us some very angry comments from administrators.

Associated revisions

Revision 757a3528 (diff)
Added by Julio Montoya about 8 years ago

Fixing chamilo_X themes see #3544

Revision c4101dcf (diff)
Added by Julio Montoya about 8 years ago

Removing the "fix" CSS files see #3544

Revision c8a37b6b (diff)
Added by Julio Montoya about 8 years ago

Fixing include base_chamilo.css calls see #3544

History

#1

Updated by Julio Montoya about 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya

yeah I also had a bad feeling while editing a theme for tests (unidad editorial).
There should be only a base.css, base_chamilo.css, and base_classic.css

And a rework of all CSS in order to delete repetitions.

#2

Updated by Julio Montoya about 8 years ago

  • % Done changed from 0 to 70

lot of CSS changes were sent

fix.css and fix_chamilo were deleted there are only the base.css base_classic.css and base_chamilo.css

#3

Updated by Julio Montoya about 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yannick Warnier

I reduce the chamilo_XXX default.css files from 4500 lines to 260 lines all the rest is in the base_chamilo.css or base.css

#5

Updated by Julio Montoya about 8 years ago

  • % Done changed from 70 to 80

Removing base_chamilo.css calls in php code and including in the default.css files seee

http://code.google.com/p/chamilo/source/detail?r=677c2c237da6622640fc8edbbbd4d17e619da53a&repo=classic

#6

Updated by Julio Montoya almost 8 years ago

  • Status changed from Needs more info to Bug resolved

Also available in: Atom PDF