Project

General

Profile

Feature #342

How about to add "Remember me"

Added by Carlos Vargas almost 10 years ago. Updated about 6 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
03/12/2009
Due date:
% Done:

0%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

How about to add "rember me" when I longin?

History

#1

Updated by Yannick Warnier over 9 years ago

  • Subject changed from How about to add "rember me" to How about to add "Remember me"
  • Status changed from New to Assigned
  • Priority changed from Normal to Low
  • Target version changed from 1.8.7 to 1.8.7.1

So that would change your setting to not close the session when you close your browser? Why not, indeed... I'm saving this one for later.

#2

Updated by Yannick Warnier over 9 years ago

  • Target version changed from 1.8.7.1 to 1.8.8 stable
#3

Updated by Yannick Warnier over 8 years ago

  • Target version changed from 1.8.8 stable to 1.8.8.4
#4

Updated by Yannick Warnier about 8 years ago

  • Target version changed from 1.8.8.4 to 1.9 Stable
#5

Updated by Julio Montoya over 7 years ago

  • Status changed from Assigned to New
  • Target version changed from 1.9 Stable to 1.9.2
#6

Updated by Julio Montoya about 7 years ago

  • Target version changed from 1.9.2 to 3.0

This will require a DB change in order to allow that behaviour

#7

Updated by Yannick Warnier about 7 years ago

Julio A. Montoya wrote:

This will require a DB change in order to allow that behaviour

I don't think so. It should just be changing the time the cookie stays valid when starting a session.
That would be in the main/inc/lib/chamilo_session.class.php::session_lifetime() function.

When checking the box, add a month or so to the cookie, hacking the end_time() function to check on $_SESSION['extended_session'] or something like that (which you have to set after calling session_start()). At least I guess it should be enough. Given the fact that this library was rewritten (and this is definitely a good thing), it should be possible to "really" change the session lifetime by setting $_configuration['session_lifetime'] to a very short time (like 2 minutes) and check if that works when adding a month (86400*31) to the session expiry.

#8

Updated by Julio Montoya about 7 years ago

Julio A. Montoya wrote:

This will require a DB change in order to allow that behaviour

I said that because maybe somebody don't want that feature. So you will need a config setting in order to turn it off

#9

Updated by Yannick Warnier about 7 years ago

Julio A. Montoya wrote:

Julio A. Montoya wrote:

This will require a DB change in order to allow that behaviour

I said that because maybe somebody don't want that feature. So you will need a config setting in order to turn it off

Ah, of course :-)

#10

Updated by Julio Montoya about 6 years ago

The "Remember me" feature was already implemented in silex serach search for RememberMeServiceProvider

#11

Updated by Yannick Warnier about 6 years ago

This last comment is not very clear for somebody external. What you mean is "this was implemented in Chamilo 1.10 thanks to the integration of Silex", right?

#12

Updated by Julio Montoya about 6 years ago

Yannick Warnier wrote:

This last comment is not very clear for somebody external. What you mean is "this was implemented in Chamilo 1.10 thanks to the integration of Silex", right?

No, what I meant is that this feature (remember me) was implemented in the Silex project as a service called RememberMeServiceProvider that plays with the SecurityServiceProvider (that we use in 1.10). The configuration of this service:

https://github.com/fabpot/Silex/blob/master/src/Silex/Provider/RememberMeServiceProvider.php

in Chamilo 1.10 is missing.

#13

Updated by Yannick Warnier about 6 years ago

See, I knew you could make it clearer :-p

Also available in: Atom PDF