Project

General

Profile

Bug #3367

Publish LP link on session's course home page

Added by Marko Kastelic over 8 years ago. Updated about 7 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
Learning paths / Lecciones
Target version:
Start date:
04/05/2011
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

Publishing as proposed with http://www.chamilo.org/en/node/1209 will work with 1.8.8 to


Files

tracking.lib.php (173 KB) tracking.lib.php Yoselyn Castillo, 08/08/2012 05:32

Associated revisions

Revision 8b634590 (diff)
Added by Julio Montoya about 7 years ago

Should allow LP shortcuts in a session course see #3367

Revision 08dea70c (diff)
Added by Yoselyn Castillo about 7 years ago

Minor - Fixing array validation see #3367

Revision d0cd85d7 (diff)
Added by Julio Montoya about 7 years ago

Should fix lp shortcut bug see #3367

History

#1

Updated by Yannick Warnier over 7 years ago

  • Target version set to 1.9.2
#2

Updated by Julio Montoya about 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
#3

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs testing
  • Assignee changed from Julio Montoya to Yoselyn Castillo
  • % Done changed from 0 to 80

It works now. You can add LP shortcuts even if you use sessions ...

#4

Updated by Yoselyn Castillo about 7 years ago

Yes, you can add LP shortcuts even if you use sessions...But i am not sure what was the bug, in session's course home page i still can't access the tab Learning Path.
In the other hand, it appears the following error in the test(session) home page

Warning: Invalid argument supplied for foreach() in /var/www/chamilodev.beeznest.com/www/main/inc/lib/tracking.lib.php on line 2455 Call Stack: 0.0026 903720 1. {main}() /var/www/chamilodev.beeznest.com/www/main/session/index.php:0 1.8721 46393648 2. Tracking::show_user_progress() /var/www/chamilodev.beeznest.com/www/main/session/index.php:437

Upload the tracking.lib.php file in order to fix it

#5

Updated by Marko Kastelic about 7 years ago

Yoselyn Castillo wrote:

Yes, you can add LP shortcuts even if you use sessions...But i am not sure what was the bug, in session's course home page i still can't access the tab Learning Path.

if you publish link/shortcut to LP on course home, and course is part of a session, this link have to be shown on the session's home too (as the links, ...)

#6

Updated by Marko Kastelic about 7 years ago

first part is ok. Publishing / unpublishing link can be controled from within session course (for the session course specific one, marked with yellow star). But still not from the course itself. To compare, try with http link publishing.

#7

Updated by Julio Montoya about 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Marko Kastelic

ok, so you want to have full control of the LP links in the main course? If that's the case I will disable the option to turn on the LP link in the LP, so it will work exactly as the Link tool..

I also added that tracking.lib.php fix

#8

Updated by Marko Kastelic about 7 years ago

actually a little bit differently;

  • from the main course: publish/unpublish link to LP (as it works now). This link is visible from the session (course) too , but without yellow star (yellow star == session course specific item). This link should not be controlled (publish/unpublish) by the session course LP tools (link for publishing should be disabled)
  • from the session course: full control over publishing on session defined LP's. But when link in published, should be marked with yellow star.

( 'main' course is used as a base, can be 'reused' in many session with the same 'base', but with session specific elements/resources/items/tools. Yellow star is used for distinguish base items from session specific ones. )

#9

Updated by Marko Kastelic about 7 years ago

  • Assignee changed from Marko Kastelic to Julio Montoya
#10

Updated by Julio Montoya about 7 years ago

  • Status changed from Needs more info to Needs testing
  • Assignee deleted (Julio Montoya)

great! now is more clear I sent some fixes

#11

Updated by Marko Kastelic about 7 years ago

  • Assignee set to Julio Montoya

hm, when copying LP with link published on course home, visibility of the link is copied too, so you got link of the copy published at the same time. But publishing control does not show that state (gray icon). If you use link publishing control again you got another copy of the link on course home. Link publishing control controls visibility of only one of the links, so you cannot remove one that was created on LP copy.
... when LP is copied, the state of link visibility should be 'not published'

#12

Updated by Julio Montoya about 7 years ago

  • Assignee deleted (Julio Montoya)

When a LP is copied the link should NOT be copied, what do you think about that?

#13

Updated by Marko Kastelic about 7 years ago

  • Assignee set to Yannick Warnier

yes, that would be fine.
And i'm thinking about another option (if it is possible), to gain control over link publishing from the course session, if the link is not published from the 'main' course (but as "session-specific"). This would make publishing links from the course session possible (even if not in the main course).

On the other hand, i'm increasingly inclined to one of the previous variants, where publishing links were independent from the course and from a course session.

I will assign this one to Yannick for a while ...

#14

Updated by Yannick Warnier about 7 years ago

I won't review it right now, but just to remind you of that, if you make any change to how the sessions are handling contents, these changes should be described here Tools_and_sessions

#15

Updated by Yannick Warnier about 7 years ago

  • Category set to Learning paths / Lecciones
  • Status changed from Needs testing to Bug resolved
  • Assignee changed from Yannick Warnier to Julio Montoya
  • % Done changed from 80 to 100

Moved the last suggestion to #5433 in order to close this one here. I'm assuming the bug is fixed. I haven't tried it (but you seem to have discussed it long enough for me to believe in the fact that you might have solved it).

Also available in: Atom PDF